From patchwork Thu Jun 12 11:53:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sricharan R X-Patchwork-Id: 31827 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f71.google.com (mail-oa0-f71.google.com [209.85.219.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 06AE220AE6 for ; Thu, 12 Jun 2014 11:59:38 +0000 (UTC) Received: by mail-oa0-f71.google.com with SMTP id n16sf5698783oag.10 for ; Thu, 12 Jun 2014 04:59:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:subject:date:message-id :in-reply-to:references:mime-version:cc:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:content-type :content-transfer-encoding; bh=hievOJ1b9RxzqnrixIpO/YYHU+6+cNtozm6448QTr5k=; b=mm4oZp1YwKoxnORnPvfxBfdOZC8B1wW8zKaMtUvoxxEDIkBGqkpIHNANAwMrGGx9eF IcHaoeCRidGuWOf4kadpkSk7PnTeriOtOJgx7Wh4fibwGjjMCsUjXWn9VvPA2iWqyx+b Yg3rPssi+COq2pbbagPfak66BAOo5fJJz7C5goDEgZC2MhL416/gQ7x4SYAlrbTIHI5l 61IWX922oLxAPj7432+sS4swqOec03Y2FGXte/kjUFZikZAOB0c8TbojJwSBc1ARmeIU d9c0fHQV5Lmcy1aWTLSgJVWRhJ0scKlmnthMTqZCFsLTtXn5xwbAyhx0EBMjIl5UxYah 1N9A== X-Gm-Message-State: ALoCoQkEEbr9dkVkDBTH3nnnPlNyywijTS/IsTrXJM+FCNZmjtV50zbqwSRJxK4Y1Qc40B2G3oMy X-Received: by 10.183.11.102 with SMTP id eh6mr3536553obd.37.1402574378638; Thu, 12 Jun 2014 04:59:38 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.109.68 with SMTP id k62ls649110qgf.99.gmail; Thu, 12 Jun 2014 04:59:38 -0700 (PDT) X-Received: by 10.58.220.230 with SMTP id pz6mr24471418vec.9.1402574378457; Thu, 12 Jun 2014 04:59:38 -0700 (PDT) Received: from mail-vc0-f179.google.com (mail-vc0-f179.google.com [209.85.220.179]) by mx.google.com with ESMTPS id 20si235487vdd.100.2014.06.12.04.59.38 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 12 Jun 2014 04:59:38 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.179 as permitted sender) client-ip=209.85.220.179; Received: by mail-vc0-f179.google.com with SMTP id id10so673642vcb.10 for ; Thu, 12 Jun 2014 04:59:38 -0700 (PDT) X-Received: by 10.58.132.70 with SMTP id os6mr459971veb.36.1402574378331; Thu, 12 Jun 2014 04:59:38 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp397294vcb; Thu, 12 Jun 2014 04:59:38 -0700 (PDT) X-Received: by 10.224.88.66 with SMTP id z2mr32550402qal.86.1402574377864; Thu, 12 Jun 2014 04:59:37 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id b3si810289qak.97.2014.06.12.04.59.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Jun 2014 04:59:37 -0700 (PDT) Received-SPF: none (google.com: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org does not designate permitted sender hosts) client-ip=2001:1868:205::9; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wv3de-0005nk-2l; Thu, 12 Jun 2014 11:57:50 +0000 Received: from devils.ext.ti.com ([198.47.26.153]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wv3cA-0004rZ-Om for linux-arm-kernel@lists.infradead.org; Thu, 12 Jun 2014 11:56:20 +0000 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id s5CBtpuJ009129; Thu, 12 Jun 2014 06:55:51 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s5CBtpdA023096; Thu, 12 Jun 2014 06:55:51 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.174.1; Thu, 12 Jun 2014 06:55:51 -0500 Received: from uda0393807.india.ti.com. (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s5CBtEbt008910; Thu, 12 Jun 2014 06:55:48 -0500 From: Sricharan R To: , , , Subject: [PATCH V2 06/19] irqchip: crossbar: remove IS_ERR_VALUE check Date: Thu, 12 Jun 2014 17:23:14 +0530 Message-ID: <1402574007-13987-7-git-send-email-r.sricharan@ti.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1402574007-13987-1-git-send-email-r.sricharan@ti.com> References: <1402574007-13987-1-git-send-email-r.sricharan@ti.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140612_045618_914114_B5B2B80A X-CRM114-Status: UNSURE ( 9.09 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -5.7 (-----) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-5.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [198.47.26.153 listed in wl.mailspike.net] -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [198.47.26.153 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders Cc: nm@ti.com, linux@arm.linux.org.uk, jason@lakedaemon.net, tony@atomide.com, rnayak@ti.com, r.sricharan@ti.com, santosh.shilimkar@ti.com, tglx@linutronix.de X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: r.sricharan@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.179 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Nishanth Menon IS_ERR_VALUE makes sense only *if* there could be valid values in negative error range. But in the cases that we do use it, there is no such case. Just remove the same. Signed-off-by: Nishanth Menon --- drivers/irqchip/irq-crossbar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index de021638..c5415ae 100644 --- a/drivers/irqchip/irq-crossbar.c +++ b/drivers/irqchip/irq-crossbar.c @@ -110,15 +110,15 @@ static int crossbar_domain_xlate(struct irq_domain *d, unsigned long *out_hwirq, unsigned int *out_type) { - unsigned long ret; + int ret; ret = get_prev_map_irq(intspec[1]); - if (!IS_ERR_VALUE(ret)) + if (ret >= 0) goto found; ret = allocate_free_irq(intspec[1]); - if (IS_ERR_VALUE(ret)) + if (ret < 0) return ret; found: