From patchwork Thu Jun 12 11:53:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sricharan R X-Patchwork-Id: 31817 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ig0-f197.google.com (mail-ig0-f197.google.com [209.85.213.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A9C7720AE6 for ; Thu, 12 Jun 2014 11:56:45 +0000 (UTC) Received: by mail-ig0-f197.google.com with SMTP id a13sf6146444igq.8 for ; Thu, 12 Jun 2014 04:56:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=9o/o83CL17vW/T/MbNlOccwPv3k1vmLbIzY/NJwy9L8=; b=VdFj328O07gEfNBVY/YhCRc0npGhRaJEewIm9EFGQD8Qg6EIom6xQ4SfWV0Vh2mi29 /1YZ3qIhRF6qWLgq3AVc5vc7ZZOvmP1qv0spOo6dZUo35v27dK97ZmRJzABFmehIgQ6L 8WEwECloISBG1nvVOmx8dIuF0xTBjiMgkQc2bHEYpZrAm7YCXMziFBPU38wgeYT7uoLT nl36ocQT/3ahQh2l1pKtTJlW5jQl1WvQrHI94n+lYftM0hQtlDrDUEo3MyS3Kn/cg+4d BoIFdEGJ7WrDgO5qraQfg1pvsWxtphcK0G8kj+Onqt8nHb00sFDv2UAGmq8jrYI0Rogx 3Aeg== X-Gm-Message-State: ALoCoQk6ZBd56Y9TjKOSW4cmlVfEFXW4kZHQAjXnl3euyXWReh2sYdEqtR/1n/3GLWtSM6Mupk0C X-Received: by 10.182.191.73 with SMTP id gw9mr599576obc.50.1402574205230; Thu, 12 Jun 2014 04:56:45 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.109.247 with SMTP id l110ls2906119qgf.90.gmail; Thu, 12 Jun 2014 04:56:45 -0700 (PDT) X-Received: by 10.58.29.106 with SMTP id j10mr1214852veh.31.1402574205121; Thu, 12 Jun 2014 04:56:45 -0700 (PDT) Received: from mail-vc0-f178.google.com (mail-vc0-f178.google.com [209.85.220.178]) by mx.google.com with ESMTPS id em7si238897vdb.53.2014.06.12.04.56.45 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 12 Jun 2014 04:56:45 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.178 as permitted sender) client-ip=209.85.220.178; Received: by mail-vc0-f178.google.com with SMTP id ij19so671451vcb.37 for ; Thu, 12 Jun 2014 04:56:45 -0700 (PDT) X-Received: by 10.58.132.70 with SMTP id os6mr449553veb.36.1402574204996; Thu, 12 Jun 2014 04:56:44 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp397125vcb; Thu, 12 Jun 2014 04:56:44 -0700 (PDT) X-Received: by 10.68.254.70 with SMTP id ag6mr12009347pbd.33.1402574204055; Thu, 12 Jun 2014 04:56:44 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bi1si6155337pbb.209.2014.06.12.04.56.43; Thu, 12 Jun 2014 04:56:43 -0700 (PDT) Received-SPF: none (google.com: linux-omap-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933618AbaFLL4a (ORCPT + 6 others); Thu, 12 Jun 2014 07:56:30 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:32784 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933586AbaFLL41 (ORCPT ); Thu, 12 Jun 2014 07:56:27 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s5CBtubp025222; Thu, 12 Jun 2014 06:55:56 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s5CBtuFC023113; Thu, 12 Jun 2014 06:55:56 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.174.1; Thu, 12 Jun 2014 06:55:55 -0500 Received: from uda0393807.india.ti.com. (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s5CBtEbu008910; Thu, 12 Jun 2014 06:55:52 -0500 From: Sricharan R To: , , , CC: , , , , , , , Subject: [PATCH V2 07/19] irqchip: crossbar: fix sparse warnings Date: Thu, 12 Jun 2014 17:23:15 +0530 Message-ID: <1402574007-13987-8-git-send-email-r.sricharan@ti.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1402574007-13987-1-git-send-email-r.sricharan@ti.com> References: <1402574007-13987-1-git-send-email-r.sricharan@ti.com> MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: r.sricharan@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.178 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Nishanth Menon There is absolutely no need for crossbar driver to expose functions and variables into global namespace. So make them all static Fixes sparse warnings: drivers/irqchip/irq-crossbar.c:129:29: warning: symbol 'routable_irq_domain_ops' was not declared. Should it be static? drivers/irqchip/irq-crossbar.c:252:5: warning: symbol 'dra_irqs_unused' was not declared. Should it be static? drivers/irqchip/irq-crossbar.c:253:22: warning: symbol 'cb_dra_data' was not declared. Should it be static? drivers/irqchip/irq-crossbar.c:261:12: warning: symbol 'irqcrossbar_init' was not declared. Should it be static? Signed-off-by: Nishanth Menon --- drivers/irqchip/irq-crossbar.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index c5415ae..5da9d36 100644 --- a/drivers/irqchip/irq-crossbar.c +++ b/drivers/irqchip/irq-crossbar.c @@ -16,6 +16,7 @@ #include #include #include +#include #define IRQ_FREE -1 #define IRQ_RESERVED -2 @@ -126,7 +127,7 @@ found: return 0; } -const struct irq_domain_ops routable_irq_domain_ops = { +static const struct irq_domain_ops routable_irq_domain_ops = { .map = crossbar_domain_map, .unmap = crossbar_domain_unmap, .xlate = crossbar_domain_xlate @@ -249,8 +250,8 @@ err1: } /* irq number 10 cannot be used because of hw bug */ -int dra_irqs_unused[] = { 10 }; -struct crossbar_data cb_dra_data = { dra_irqs_unused, +static int dra_irqs_unused[] = { 10 }; +static struct crossbar_data cb_dra_data = { dra_irqs_unused, ARRAY_SIZE(dra_irqs_unused), 0 }; static const struct of_device_id crossbar_match[] __initconst = {