From patchwork Mon Nov 3 10:09:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 39999 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f69.google.com (mail-ee0-f69.google.com [74.125.83.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 664DA20560 for ; Mon, 3 Nov 2014 10:10:10 +0000 (UTC) Received: by mail-ee0-f69.google.com with SMTP id c41sf2628629eek.4 for ; Mon, 03 Nov 2014 02:10:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=RNR64ScePWekSlLUU8MyujwOAGjg5sJ0LGS/GLjMLG4=; b=QJj8a8/gtgJEcUX7MOfNtjfLdlv47lRcbWa5NNVhKYe7rdsYkK+J8PMdO/+lNyR/1o cDLivpyLaqoF56sCTXcvebu7TCxIy6zSZsBl5xC25JkzA6TjQVZOBESF1k//yedup8iY CNEAqAKhiDk88TlVSFi3eno2N/Afzzmb6p1lwDPOys9Z0bTYMWaVsLLOHyE5ElkeUJS4 2CZ/bH4OGtz9kMQZeg73uXRqpcWYxVIAXfJgUY2EEXUqys5N3ye9i8KFm231qdAJl7Sc k7XvLgGyUqHm7j7vtxVXN+p9YGXbF09ZRahjQuBSP3m+aUaaLnn4GRibjpbtbBOZnkxY 2jAg== X-Gm-Message-State: ALoCoQkdjv/gUVFpMfw7EMNruTFwJIZau7yxFeJuskzDYw4kwbpnzhnE0VbPjSdtfHlYA9PFMEbJ X-Received: by 10.180.93.35 with SMTP id cr3mr2678197wib.2.1415009409644; Mon, 03 Nov 2014 02:10:09 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.43.34 with SMTP id t2ls765291lal.2.gmail; Mon, 03 Nov 2014 02:10:09 -0800 (PST) X-Received: by 10.112.139.165 with SMTP id qz5mr11540637lbb.96.1415009409119; Mon, 03 Nov 2014 02:10:09 -0800 (PST) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com. [209.85.215.41]) by mx.google.com with ESMTPS id jc4si11778491lbc.137.2014.11.03.02.10.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 03 Nov 2014 02:10:08 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by mail-la0-f41.google.com with SMTP id s18so4611916lam.0 for ; Mon, 03 Nov 2014 02:10:08 -0800 (PST) X-Received: by 10.152.116.102 with SMTP id jv6mr49765249lab.40.1415009408740; Mon, 03 Nov 2014 02:10:08 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.84.229 with SMTP id c5csp211994lbz; Mon, 3 Nov 2014 02:10:01 -0800 (PST) X-Received: by 10.70.26.35 with SMTP id i3mr42712374pdg.84.1415009400462; Mon, 03 Nov 2014 02:10:00 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id xy2si9102314pbb.122.2014.11.03.02.09.59 for ; Mon, 03 Nov 2014 02:10:00 -0800 (PST) Received-SPF: none (google.com: devicetree-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751781AbaKCKJ7 (ORCPT + 4 others); Mon, 3 Nov 2014 05:09:59 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:41984 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbaKCKJ6 (ORCPT ); Mon, 3 Nov 2014 05:09:58 -0500 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id sA3A9vMe026819; Mon, 3 Nov 2014 04:09:57 -0600 Received: from DLEE70.ent.ti.com (dlemailx.itg.ti.com [157.170.170.113]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id sA3A9vCp014727; Mon, 3 Nov 2014 04:09:57 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.174.1; Mon, 3 Nov 2014 04:09:56 -0600 Received: from localhost.localdomain (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id sA3A9sRb017768; Mon, 3 Nov 2014 04:09:55 -0600 From: Roger Quadros To: CC: , , , , Roger Quadros Subject: [PATCH v2] pinctrl: dra: dt-bindings: Fix output pull up/down Date: Mon, 3 Nov 2014 12:09:52 +0200 Message-ID: <1415009392-6627-1-git-send-email-rogerq@ti.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1414752745-13696-1-git-send-email-rogerq@ti.com> References: <1414752745-13696-1-git-send-email-rogerq@ti.com> MIME-Version: 1.0 Sender: devicetree-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: devicetree@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: rogerq@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , For PIN_OUTPUT_PULLUP and PIN_OUTPUT_PULLDOWN we must not set the PULL_DIS bit which disables the PULLs. PULL_ENA is a 0 and using it in an OR operation is a NOP, so don't use it in the PIN_OUTPUT_PULLUP/DOWN macros. Fixes: 23d9cec07c58 ("pinctrl: dra: dt-bindings: Fix pull enable/disable") Signed-off-by: Roger Quadros Acked-by: Nishanth Menon --- include/dt-bindings/pinctrl/dra.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/dt-bindings/pinctrl/dra.h b/include/dt-bindings/pinctrl/dra.h index 3d33794..7448edf 100644 --- a/include/dt-bindings/pinctrl/dra.h +++ b/include/dt-bindings/pinctrl/dra.h @@ -40,8 +40,8 @@ /* Active pin states */ #define PIN_OUTPUT (0 | PULL_DIS) -#define PIN_OUTPUT_PULLUP (PIN_OUTPUT | PULL_ENA | PULL_UP) -#define PIN_OUTPUT_PULLDOWN (PIN_OUTPUT | PULL_ENA) +#define PIN_OUTPUT_PULLUP (PULL_UP) +#define PIN_OUTPUT_PULLDOWN (0) #define PIN_INPUT (INPUT_EN | PULL_DIS) #define PIN_INPUT_SLEW (INPUT_EN | SLEWCONTROL) #define PIN_INPUT_PULLUP (PULL_ENA | INPUT_EN | PULL_UP)