From patchwork Mon Dec 9 09:21:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 180990 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp4097714ile; Mon, 9 Dec 2019 01:20:56 -0800 (PST) X-Google-Smtp-Source: APXvYqxeLsHMlz3RHG2eRWOpQxsgAENhA4jlMsW61cNIZJ5JehZFQiXDStdd4BWQXiv9AuiELKFw X-Received: by 2002:a9d:7f12:: with SMTP id j18mr21533185otq.17.1575883256396; Mon, 09 Dec 2019 01:20:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575883256; cv=none; d=google.com; s=arc-20160816; b=xWEI9LdAZAHgHpDpl31kpXxR5Yqg/Hinx+6Ni190ntBl2/Ln3YVGbTM+9CZHZjiIV5 bmOVKkTYPMRzzVwwt4tYx2tGwW2bZNC+7yR3olk5APAXka/OLYawNm+45P6YEueINGPl 1IwD4oIbqt4GkIhDOJQ8Tetau11NFdA3uIiHif0StxTv9OsQzp7Z82flrRCJ+7I7avp0 nlAH3km5vlpukZjJtTTNdB9nCmwyGI1qSewTHas2HgC60TLQWeDtRzWgxgLncsIfg4yd Wyq95K+18JHIRdPiTB2YUaH34rdwNcDcadUF4a5WyVnHkLJl1R8hfe3abzpjbdSY7RyX k5Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=62DDuOo04TbPHTLK9JrEpoRquiITZMIbCCFCFJ1RQQY=; b=O8QHa/UFvtISOD7mVkIcS8P/I9HqJBsS56bjTIxDMuokASYVr5Mc1ql5U9lqEvcVV/ XXJ9mpA6rFKCLMkFJA0oxzfIQGyWsGpHk9SANVMK8+k/4g/BeCTiuOOs0tSAuG7Lo0zk Hn+Q3Rny3SSHWgaM67n+9bKeoDRTSPZbcHCHKvc9GJGKOjoGzK0IIWB5oWqHUs4451Pv x0FSSfseJE719Pd2J2UYPzET29NDOsiFAe2xqlzDu7M+0BVvNHlu59BgIjzvy/Zn6Th2 VjUOSqBbvx4J6ovMdIg/HSYjAjennpw33v2nC8RHx2PjgeRRyAOS0ll8B/Vn+tx6PR7K GwwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=oGNJxuWx; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p14si12178607ota.71.2019.12.09.01.20.56; Mon, 09 Dec 2019 01:20:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=oGNJxuWx; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727547AbfLIJUz (ORCPT + 4 others); Mon, 9 Dec 2019 04:20:55 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:49456 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726377AbfLIJUz (ORCPT ); Mon, 9 Dec 2019 04:20:55 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id xB99Kjdq025907; Mon, 9 Dec 2019 03:20:45 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1575883245; bh=62DDuOo04TbPHTLK9JrEpoRquiITZMIbCCFCFJ1RQQY=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=oGNJxuWxlJcrpHirekmw8baxM8dsTpm6PIFpTWEjjXFR264jSha0vgPsUBB2J1QVi ZTKnY8N6Dm+SEUPVAdYdLNQy8+ffHCnndTI+0J4xOUb8pDx+tV3zU5izjD1Dt97xqH kAfEWj3Z89HI8y3ng21NM4XfZ0RAzweFn2QRRpXQ= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id xB99KjoV062979 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 9 Dec 2019 03:20:45 -0600 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Mon, 9 Dec 2019 03:20:45 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Mon, 9 Dec 2019 03:20:45 -0600 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id xB99Kccx087697; Mon, 9 Dec 2019 03:20:42 -0600 From: Kishon Vijay Abraham I To: Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Arnd Bergmann , Andrew Murray CC: , , , , Kishon Vijay Abraham I Subject: [PATCH 01/13] PCI: cadence: Remove stray "pm_runtime_put_sync()" in error path Date: Mon, 9 Dec 2019 14:51:35 +0530 Message-ID: <20191209092147.22901-2-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191209092147.22901-1-kishon@ti.com> References: <20191209092147.22901-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org commit bd22885aa188f135fd9 ("PCI: cadence: Refactor driver to use as a core library") while refactoring the Cadence PCIe driver to be used as library, removed pm_runtime_get_sync() from cdns_pcie_ep_setup() and cdns_pcie_host_setup() but missed to remove the corresponding pm_runtime_put_sync() in the error path. Fix it here. Fixes: commit bd22885aa188f135fd9 ("PCI: cadence: Refactor driver to use as a core library") Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/cadence/pcie-cadence-ep.c | 2 -- drivers/pci/controller/cadence/pcie-cadence-host.c | 2 -- 2 files changed, 4 deletions(-) -- 2.17.1 diff --git a/drivers/pci/controller/cadence/pcie-cadence-ep.c b/drivers/pci/controller/cadence/pcie-cadence-ep.c index 1c173dad67d1..560f22b4d165 100644 --- a/drivers/pci/controller/cadence/pcie-cadence-ep.c +++ b/drivers/pci/controller/cadence/pcie-cadence-ep.c @@ -473,7 +473,5 @@ int cdns_pcie_ep_setup(struct cdns_pcie_ep *ep) pci_epc_mem_exit(epc); err_init: - pm_runtime_put_sync(dev); - return ret; } diff --git a/drivers/pci/controller/cadence/pcie-cadence-host.c b/drivers/pci/controller/cadence/pcie-cadence-host.c index 9b1c3966414b..ccf55e143e1d 100644 --- a/drivers/pci/controller/cadence/pcie-cadence-host.c +++ b/drivers/pci/controller/cadence/pcie-cadence-host.c @@ -275,7 +275,5 @@ int cdns_pcie_host_setup(struct cdns_pcie_rc *rc) pci_free_resource_list(&resources); err_init: - pm_runtime_put_sync(dev); - return ret; }