| Message ID | 20231125092938.16535-3-andreas@kemnade.info |
|---|---|
| State | New |
| Headers | show |
| Series | mfd: twl: system-power-controller | expand |
Hi Andreas, kernel test robot noticed the following build warnings: [auto build test WARNING on robh/for-next] [also build test WARNING on lee-mfd/for-mfd-next linus/master v6.7-rc2 next-20231124] [cannot apply to tmlind-omap/for-next lee-mfd/for-mfd-fixes] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andreas-Kemnade/dt-bindings-mfd-ti-twl-Document-system-power-controller/20231125-173426 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20231125092938.16535-3-andreas%40kemnade.info patch subject: [PATCH 2/6] twl-core: add power off implementation for twl603x config: xtensa-randconfig-r081-20231125 (https://download.01.org/0day-ci/archive/20231125/202311252254.j0JQBIvl-lkp@intel.com/config) compiler: xtensa-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231125/202311252254.j0JQBIvl-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202311252254.j0JQBIvl-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/mfd/twl-core.c:690:6: warning: no previous prototype for 'twl6030_power_off' [-Wmissing-prototypes] 690 | void twl6030_power_off(void) | ^~~~~~~~~~~~~~~~~ vim +/twl6030_power_off +690 drivers/mfd/twl-core.c 689 > 690 void twl6030_power_off(void) 691 { 692 #define APP_DEVOFF (1<<0) 693 #define CON_DEVOFF (1<<1) 694 #define MOD_DEVOFF (1<<2) 695 696 int err; 697 u8 val; 698 699 err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val, 700 TWL6030_PHOENIX_DEV_ON); 701 if (err) { 702 pr_err("I2C error %d reading PHOENIX_DEV_ON\n", err); 703 return; 704 } 705 706 val |= APP_DEVOFF | CON_DEVOFF | MOD_DEVOFF; 707 708 err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val, 709 TWL6030_PHOENIX_DEV_ON); 710 if (err) 711 pr_err("TWL6030 Unable to power off\n"); 712 } 713
Hi Andreas, kernel test robot noticed the following build warnings: [auto build test WARNING on robh/for-next] [also build test WARNING on lee-mfd/for-mfd-next linus/master v6.7-rc2 next-20231124] [cannot apply to tmlind-omap/for-next lee-mfd/for-mfd-fixes] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andreas-Kemnade/dt-bindings-mfd-ti-twl-Document-system-power-controller/20231125-173426 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20231125092938.16535-3-andreas%40kemnade.info patch subject: [PATCH 2/6] twl-core: add power off implementation for twl603x config: x86_64-randconfig-122-20231126 (https://download.01.org/0day-ci/archive/20231127/202311270558.j38P20an-lkp@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231127/202311270558.j38P20an-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202311270558.j38P20an-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> drivers/mfd/twl-core.c:690:6: sparse: sparse: symbol 'twl6030_power_off' was not declared. Should it be static? vim +/twl6030_power_off +690 drivers/mfd/twl-core.c 689 > 690 void twl6030_power_off(void) 691 { 692 #define APP_DEVOFF (1<<0) 693 #define CON_DEVOFF (1<<1) 694 #define MOD_DEVOFF (1<<2) 695 696 int err; 697 u8 val; 698 699 err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val, 700 TWL6030_PHOENIX_DEV_ON); 701 if (err) { 702 pr_err("I2C error %d reading PHOENIX_DEV_ON\n", err); 703 return; 704 } 705 706 val |= APP_DEVOFF | CON_DEVOFF | MOD_DEVOFF; 707 708 err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val, 709 TWL6030_PHOENIX_DEV_ON); 710 if (err) 711 pr_err("TWL6030 Unable to power off\n"); 712 } 713
diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c index 6e384a79e3418..3eef285eac535 100644 --- a/drivers/mfd/twl-core.c +++ b/drivers/mfd/twl-core.c @@ -687,6 +687,31 @@ static void twl_remove(struct i2c_client *client) twl_priv->ready = false; } +void twl6030_power_off(void) +{ +#define APP_DEVOFF (1<<0) +#define CON_DEVOFF (1<<1) +#define MOD_DEVOFF (1<<2) + + int err; + u8 val; + + err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val, + TWL6030_PHOENIX_DEV_ON); + if (err) { + pr_err("I2C error %d reading PHOENIX_DEV_ON\n", err); + return; + } + + val |= APP_DEVOFF | CON_DEVOFF | MOD_DEVOFF; + + err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val, + TWL6030_PHOENIX_DEV_ON); + if (err) + pr_err("TWL6030 Unable to power off\n"); +} + + static struct of_dev_auxdata twl_auxdata_lookup[] = { OF_DEV_AUXDATA("ti,twl4030-gpio", 0, "twl4030-gpio", NULL), { /* sentinel */ }, @@ -852,6 +877,15 @@ twl_probe(struct i2c_client *client) goto free; } + if (twl_class_is_6030()) { + if (of_device_is_system_power_controller(client->dev.of_node)) { + if (!pm_power_off) + pm_power_off = twl6030_power_off; + else + dev_warn(&client->dev, "Poweroff callback already assigned\n"); + } + } + status = of_platform_populate(node, NULL, twl_auxdata_lookup, &client->dev); diff --git a/include/linux/mfd/twl.h b/include/linux/mfd/twl.h index c062d91a67d92..85dc406173dba 100644 --- a/include/linux/mfd/twl.h +++ b/include/linux/mfd/twl.h @@ -461,6 +461,7 @@ static inline int twl6030_mmc_card_detect(struct device *dev, int slot) #define TWL4030_PM_MASTER_GLOBAL_TST 0xb6 +#define TWL6030_PHOENIX_DEV_ON 0x06 /*----------------------------------------------------------------------*/ /* Power bus message definitions */
If the system-power-controller property is there, enable power off. Implementation is based on a Linux v3.0 vendor kernel. Signed-off-by: Andreas Kemnade <andreas@kemnade.info> --- drivers/mfd/twl-core.c | 34 ++++++++++++++++++++++++++++++++++ include/linux/mfd/twl.h | 1 + 2 files changed, 35 insertions(+)