From patchwork Thu Nov 29 17:46:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 152425 Delivered-To: patches@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp2671905ljp; Thu, 29 Nov 2018 09:47:08 -0800 (PST) X-Received: by 2002:a2e:8786:: with SMTP id n6-v6mr1861806lji.100.1543513628858; Thu, 29 Nov 2018 09:47:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543513628; cv=none; d=google.com; s=arc-20160816; b=SffcU2eITjMyj8gEB/R+yYNjNPtxHku5qXs7U7j+WUcZQbcb1HJKyIy4Tjf3tzJdj/ 1CmZed7ubAxJptf8Muy2w2Bzde14WU5fJ5eKJTZOePREPVNPUMCB+0zDw+6lNeHZa4sE 5k6PfeLSVaoa4xsWD8TyCwltYYXOjJ+uQz4ie4Rzf1zxwcYhQboAmpGG0rmK+EHrrHr3 xmRAelVG5SNc4QiPha4UUdDRNiy32JePSm2Nut7t0F2m2BagBym6eyEeXBMzDlhZMlCa /v25uU6U4oB5n/SAGQ8ctYrMnMsQG7In/8hfuI9B7cXrKOq6PJwU+fpsIpuGdEcRyE/7 g2FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature; bh=Ah0MzEFLiAebhgGCxaTOnP2NoihwEgVHVQARU010jgY=; b=qvyAtpG1frVIGb8TQ6D+BZi707V8juNipgR7bGOIR7TCHNep2gIqRv3FamJlkPll1D 9sEUGZp/drDzZ9vHXreX2e988C6jKgYZCxOeD4nvfXw6JncPsmkgl6hIMdiIKdgZnpW6 j1BUuxWZMxBKXAYlYPkzVeCSbPDzac6VhoaL7ePrQF2VApW7ZYyKnPy9nXei2CBIecIZ cVqX1Q8WuZsJnxdsX4QR7QH/WDs+U+YAuqeRYa+2fanXD54M/RrtK8zxjPWCuWKPz9O/ YmQVkNz6V9qzwsP7j8U2L2vJaAA+lr16zLR2YmwtV8GFAYxgSAfPMQm0zoZVEVBJwuK2 4utg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cjRkAYcx; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id 4sor799768lfa.29.2018.11.29.09.47.08 for (Google Transport Security); Thu, 29 Nov 2018 09:47:08 -0800 (PST) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cjRkAYcx; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=Ah0MzEFLiAebhgGCxaTOnP2NoihwEgVHVQARU010jgY=; b=cjRkAYcxlwPkS+DphqxfX14Hrs0Ze/xOzzcpnv5fh0gkO6SXqrnsua6azAt2dQpWiy R/a5q48a/EEwNdakpPMOpX0wpBdJdFu5C3oDliseBLah6XoHfKqjjWMtyx0mkl0PQtT3 R0qAIy8s61hBIV//ooOKMR/ozsjSxFRqARh6I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Ah0MzEFLiAebhgGCxaTOnP2NoihwEgVHVQARU010jgY=; b=HmU+14SKWWncRNynqEwBnl3xrmbd5Aw2jPrzcpfvZkD/+FFhGi0qxD+chKWEcEZyOA 9kBRZyL52EXRxN7mnYZ73LdmSJ/TGsZzgfiTo2grKG4BcCSVDPqtlbDRDBScoAoob7p1 nHjxaOglg3jpvYHfnpcJ8uKRm7/7+UWH8rIV/4NLppmXPxP3GdLDeEIQYuHD/v1KeIXz Qm5icASHsTbKiYZdfKiJEyTbkooyWhETdWbMUzGiMpqDuktajm6wibgnuYvFtqRXCl0A ANI7DVUmMlVlEwv7Sk3U5dkGuq4NPPyqyQG5iW4XFsblV6Zji1L4mGgHdi5HOYJaeRDO Th7Q== X-Gm-Message-State: AA+aEWZItxqwlpIdRFuwIjDOnCAM76UAOtDTMldbgoC+o/+ppfmO9q/u I6ebs1mPzkek2dQFbft1AjrLrc0A X-Google-Smtp-Source: AFSGD/X5nDjSI31ktjUY344OXaV3l4VkV/AONaDnwyjpdNrpbl7DbUpF2CYR6nFbSep6F2QJWOHzYw== X-Received: by 2002:a19:750a:: with SMTP id y10mr1623514lfe.43.1543513628271; Thu, 29 Nov 2018 09:47:08 -0800 (PST) Return-Path: Received: from localhost.localdomain (h-158-174-22-210.NA.cust.bahnhof.se. [158.174.22.210]) by smtp.gmail.com with ESMTPSA id j76-v6sm393983ljb.12.2018.11.29.09.47.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Nov 2018 09:47:07 -0800 (PST) From: Ulf Hansson To: "Rafael J . Wysocki" , Sudeep Holla , Lorenzo Pieralisi , Mark Rutland , Daniel Lezcano , linux-pm@vger.kernel.org Cc: "Raju P . L . S . S . S . N" , Stephen Boyd , Tony Lindgren , Kevin Hilman , Lina Iyer , Ulf Hansson , Viresh Kumar , Vincent Guittot , Geert Uytterhoeven , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v10 00/27] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) Date: Thu, 29 Nov 2018 18:46:33 +0100 Message-Id: <20181129174700.16585-1-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.17.1 Over the years this series have been iterated and discussed at various Linux conferences and LKML. In this new v10, a quite significant amount of changes have been made to address comments from v8 and v9. A summary is available below, although let's start with a brand new clarification of the motivation behind this series. For ARM64/ARM based platforms CPUs are often arranged in a hierarchical manner. >From a CPU idle state perspective, this means some states may be shared among a group of CPUs (aka CPU cluster). To deal with idle management of a group of CPUs, sometimes the kernel needs to be involved to manage the last-man standing algorithm, simply because it can't rely solely on power management FWs to deal with this. Depending on the platform, of course. There are a couple of typical scenarios for when the kernel needs to be in control, dealing with synchronization of when the last CPU in a cluster is about to enter a deep idle state. 1) The kernel needs to carry out so called last-man activities before the CPU cluster can enter a deep idle state. This may for example involve to configure external logics for wakeups, as the GIC may no longer be functional once a deep cluster idle state have been entered. Likewise, these operations may need to be restored, when the first CPU wakes up. 2) Other more generic I/O devices, such as an MMC controller for example, may be a part of the same power domain as the CPU cluster, due to a shared power-rail. For these scenarios, when the MMC controller is in use dealing with an MMC request, a deeper idle state of the CPU cluster may needs to be temporarily disabled. This is needed to retain the MMC controller in a functional state, else it may loose its register-context in the middle of serving a request. In this series, we are extending the generic PM domain (aka genpd) to be used for also CPU devices. Hence the goal is to re-use much of its current code to help us manage the last-man standing synchronization. Moreover, as we already use genpd to model power domains for generic I/O devices, both 1) and 2) can be address with its help. Moreover, to address these problems for ARM64 DT based platforms, we are deploying support for genpd and runtime PM to the PSCI FW driver - and finally we make some updates to two ARM64 DTBs, as to deploy the new PSCI CPU topology layout. The series has been tested on the QCOM 410c dragonboard and the Hisilicon Hikey board. You may also find the code at: git.linaro.org/people/ulf.hansson/linux-pm.git next Kind regards Ulf Hansson Changes in v10: - Quite significant changes have been to the PSCI driver deployment. According to an agreement with Lorenzo, the hierarchical CPU layout for PSCI should be orthogonal to whether the PSCI FW supports OSI or not. This has been taken care of in this version. - Drop the generic attach/detach helpers of CPUs to genpd, instead make that related code internal to PSCI, for now. - Fix "BUG: sleeping for invalid context" for hotplug, as reported by Raju. - Addressed various comments from version 8 and 9. - Clarified changelogs and re-wrote the cover-letter to better explain the motivations behind these changes. Changes in v9: - Collect only a subset from the changes in v8. - Patch 3 is new, documenting existing genpd flags. Future wise, this means when a new genpd flag is invented, we must also properly document it. - No changes have been made to the patches picked from v8. - Dropped the text from v8 cover-letter[1], to avoid confusion. When posting v10 (or whatever the next version containing the rest becomes), I am going re-write the cover-letter to clarify, more exactly, the problems this series intends to solve. The earlier text was simply too vague. [1] https://lwn.net/Articles/758091/ Changes in v8: - Added some tags for reviews and acks. - Cleanup timer patch (patch6) according to comments from Rafael. - Rebased series on top of v4.18rc1 - it applied cleanly, except for patch 5. - While adopting patch 5 to new genpd changes, I took the opportunity to improve the new function description a bit. - Corrected malformed SPDX-License-Identifier in patch20. Changes in v7: - Addressed comments concerning the PSCI changes from Mark Rutland, which moves the psci firmware driver to a new firmware subdir and change to force PSCI PC mode during boot to cope with kexec'ed booted kernels. - Added some maintainers in cc for the timer/nohz patches. - Minor update to the new genpd governor, taking into account the state's poweroff latency while validating the sleep duration time. - Addressed a problem pointed out by Geert Uytterhoeven, around calling pm_runtime_get|put() for CPUs that has not been attached to a CPU PM domain. - Re-based on Linus' latest master. Lina Iyer (5): timer: Export next wakeup time of a CPU dt: psci: Update DT bindings to support hierarchical PSCI states cpuidle: dt: Support hierarchical CPU idle states drivers: firmware: psci: Support hierarchical CPU idle states arm64: dts: Convert to the hierarchical CPU topology layout for MSM8916 Ulf Hansson (22): PM / Domains: Add generic data pointer to genpd_power_state struct PM / Domains: Add support for CPU devices to genpd PM / Domains: Add genpd governor for CPUs of: base: Add of_get_cpu_state_node() to get idle states for a CPU node ARM/ARM64: cpuidle: Let back-end init ops take the driver as input drivers: firmware: psci: Move psci to separate directory MAINTAINERS: Update files for PSCI drivers: firmware: psci: Split psci_dt_cpu_init_idle() drivers: firmware: psci: Simplify state node parsing drivers: firmware: psci: Simplify error path of psci_dt_init() drivers: firmware: psci: Announce support for OS initiated suspend mode drivers: firmware: psci: Prepare to use OS initiated suspend mode drivers: firmware: psci: Prepare to support PM domains drivers: firmware: psci: Add support for PM domains using genpd drivers: firmware: psci: Add hierarchical domain idle states converter drivers: firmware: psci: Introduce psci_dt_topology_init() drivers: firmware: psci: Add a helper to attach a CPU to its PM domain drivers: firmware: psci: Attach the CPU's device to its PM domain drivers: firmware: psci: Manage runtime PM in the idle path for CPUs drivers: firmware: psci: Support CPU hotplug for the hierarchical model arm64: kernel: Respect the hierarchical CPU topology in DT for PSCI arm64: dts: hikey: Convert to the hierarchical CPU topology layout .../devicetree/bindings/arm/psci.txt | 166 ++++++++ MAINTAINERS | 2 +- arch/arm/include/asm/cpuidle.h | 4 +- arch/arm/kernel/cpuidle.c | 5 +- arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 87 +++- arch/arm64/boot/dts/qcom/msm8916.dtsi | 57 ++- arch/arm64/include/asm/cpu_ops.h | 4 +- arch/arm64/include/asm/cpuidle.h | 6 +- arch/arm64/kernel/cpuidle.c | 6 +- arch/arm64/kernel/setup.c | 3 + drivers/base/power/domain.c | 74 +++- drivers/base/power/domain_governor.c | 61 ++- drivers/cpuidle/cpuidle-arm.c | 2 +- drivers/cpuidle/dt_idle_states.c | 5 +- drivers/firmware/Kconfig | 15 +- drivers/firmware/Makefile | 3 +- drivers/firmware/psci/Kconfig | 13 + drivers/firmware/psci/Makefile | 4 + drivers/firmware/{ => psci}/psci.c | 240 ++++++++--- drivers/firmware/psci/psci.h | 23 ++ drivers/firmware/{ => psci}/psci_checker.c | 0 drivers/firmware/psci/psci_pm_domain.c | 389 ++++++++++++++++++ drivers/of/base.c | 35 ++ drivers/soc/qcom/spm.c | 3 +- include/linux/of.h | 8 + include/linux/pm_domain.h | 19 +- include/linux/psci.h | 6 +- include/linux/tick.h | 8 + include/uapi/linux/psci.h | 5 + kernel/time/tick-sched.c | 13 + 30 files changed, 1163 insertions(+), 103 deletions(-) create mode 100644 drivers/firmware/psci/Kconfig create mode 100644 drivers/firmware/psci/Makefile rename drivers/firmware/{ => psci}/psci.c (76%) create mode 100644 drivers/firmware/psci/psci.h rename drivers/firmware/{ => psci}/psci_checker.c (100%) create mode 100644 drivers/firmware/psci/psci_pm_domain.c -- 2.17.1