mbox series

[0/3] PM / devfreq: Add devfreq_frequency tracepoint to track frequency change

Message ID 20201008075403.26181-1-cw00.choi@samsung.com
Headers show
Series PM / devfreq: Add devfreq_frequency tracepoint to track frequency change | expand

Message

Chanwoo Choi Oct. 8, 2020, 7:54 a.m. UTC 
Add devfreq_tracepoint to track the correct timing of frequency change
with following information:
- device name
- current frequency
- previous frequency
- load when change frequency
- tracepoint path : /sys/kernel/debug/tracing/events/devfreq_frequency

And add devfreq_update_target() function to unify the frequency change code
on both devfreq core and devfreq passive governor because there are redundant
duplicate code. Lastly, Use fixed indentation size to improve readability
for 'devfreq_monitor' tracepoint.

Matthias already sent the patch[1]. Make patch3 by editing patch[1].
[1]https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2108015.html

Chanwoo Choi (2):
  trace: events: devfreq: Use fixed indentation size to improve readability
  PM / devfreq: Unify frequency change to devfreq_update_target func

Matthias Kaehlcke (1):
  PM / devfreq: Add tracepoint for frequency changes

 drivers/devfreq/devfreq.c          | 37 +++++++++++++++++++++-----
 drivers/devfreq/governor.h         |  1 +
 drivers/devfreq/governor_passive.c | 42 +++++++-----------------------
 include/trace/events/devfreq.h     | 30 ++++++++++++++++++++-
 4 files changed, 70 insertions(+), 40 deletions(-)

Comments

Chanwoo Choi Oct. 19, 2020, 11:04 a.m. UTC | #1 
On 10/8/20 4:54 PM, Chanwoo Choi wrote:
> Add devfreq_tracepoint to track the correct timing of frequency change
> with following information:
> - device name
> - current frequency
> - previous frequency
> - load when change frequency
> - tracepoint path : /sys/kernel/debug/tracing/events/devfreq_frequency
> 
> And add devfreq_update_target() function to unify the frequency change code
> on both devfreq core and devfreq passive governor because there are redundant
> duplicate code. Lastly, Use fixed indentation size to improve readability
> for 'devfreq_monitor' tracepoint.
> 
> Matthias already sent the patch[1]. Make patch3 by editing patch[1].
> [1]https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2108015.html
> 
> Chanwoo Choi (2):
>   trace: events: devfreq: Use fixed indentation size to improve readability
>   PM / devfreq: Unify frequency change to devfreq_update_target func
> 
> Matthias Kaehlcke (1):
>   PM / devfreq: Add tracepoint for frequency changes
> 
>  drivers/devfreq/devfreq.c          | 37 +++++++++++++++++++++-----
>  drivers/devfreq/governor.h         |  1 +
>  drivers/devfreq/governor_passive.c | 42 +++++++-----------------------
>  include/trace/events/devfreq.h     | 30 ++++++++++++++++++++-
>  4 files changed, 70 insertions(+), 40 deletions(-)
> 

Applied them. Thanks.