| Message ID | 20210107121754.3295-1-martin.kepplinger@puri.sm |
|---|---|
| Headers | show |
| Series | imx8mq: updates for the interconnect fabric | expand |
On Thu, Jan 07, 2021 at 01:17:49PM +0100, Martin Kepplinger wrote: > revision history: > v4: (thanks Shawn, Georgi and Greg) > * reorder to have dt-bindings doc before code addition > * add newline between dt nodes > * removed "interconnect: imx8mq: Use icc_sync_state" from the patchset > since it's part of gregkh/char-misc.git > * Add acks > > v3: (thanks Krysztof and Georgi) > * drop the defconfig cycling patch and fix the interconnect enable config > * add the noc node to imx8mq only > * add missing signed-off-by > * https://lore.kernel.org/linux-arm-kernel/20201210100906.18205-1-martin.kepplinger@puri.sm/T/#t > > v2: (thanks Lucas) > * reorder and clean up defconfig changes > * use "dram" for the interconnect path name and document it > * https://lore.kernel.org/linux-arm-kernel/20201201123932.12312-1-martin.kepplinger@puri.sm/T/#t > > v1: > * https://lore.kernel.org/linux-arm-kernel/20201201100124.4676-1-martin.kepplinger@puri.sm/T/#t > > thanks, > martin > > > Leonard Crestez (1): > arm64: dts: imx8mq: Add NOC node > > Martin Kepplinger (4): > arm64: dts: imx8mq: Add interconnect provider property > dt-bindings: mxsfb: Add interconnect bindings for LCDIF path > arm64: dts: imx8mq: Add interconnect for lcdif > arm64: defconfig: Enable interconnect for imx8mq I only received 3 patches, 1/5, 4/5 and 5/5. Shawn
On 11.01.21 05:51, Shawn Guo wrote: > On Thu, Jan 07, 2021 at 01:17:49PM +0100, Martin Kepplinger wrote: >> revision history: >> v4: (thanks Shawn, Georgi and Greg) >> * reorder to have dt-bindings doc before code addition >> * add newline between dt nodes >> * removed "interconnect: imx8mq: Use icc_sync_state" from the patchset >> since it's part of gregkh/char-misc.git >> * Add acks >> >> v3: (thanks Krysztof and Georgi) >> * drop the defconfig cycling patch and fix the interconnect enable config >> * add the noc node to imx8mq only >> * add missing signed-off-by >> * https://lore.kernel.org/linux-arm-kernel/20201210100906.18205-1-martin.kepplinger@puri.sm/T/#t >> >> v2: (thanks Lucas) >> * reorder and clean up defconfig changes >> * use "dram" for the interconnect path name and document it >> * https://lore.kernel.org/linux-arm-kernel/20201201123932.12312-1-martin.kepplinger@puri.sm/T/#t >> >> v1: >> * https://lore.kernel.org/linux-arm-kernel/20201201100124.4676-1-martin.kepplinger@puri.sm/T/#t >> >> thanks, >> martin >> >> >> Leonard Crestez (1): >> arm64: dts: imx8mq: Add NOC node >> >> Martin Kepplinger (4): >> arm64: dts: imx8mq: Add interconnect provider property >> dt-bindings: mxsfb: Add interconnect bindings for LCDIF path >> arm64: dts: imx8mq: Add interconnect for lcdif >> arm64: defconfig: Enable interconnect for imx8mq > > I only received 3 patches, 1/5, 4/5 and 5/5. > > Shawn > strange as they made it to the lists, see https://lore.kernel.org/linux-arm-kernel/20210107121754.3295-1-martin.kepplinger@puri.sm/ but I can resend into this thread. martin
On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote: > Add interconnect ports for lcdif to set bus capabilities. > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 89e7de2e7f7a..9300be8c9b53 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -11,6 +11,7 @@ > #include "dt-bindings/input/input.h" > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/thermal/thermal.h> > +#include <dt-bindings/interconnect/imx8mq.h> > #include "imx8mq-pinfunc.h" > > / { > @@ -522,6 +523,8 @@ > <&clk IMX8MQ_VIDEO_PLL1>, > <&clk IMX8MQ_VIDEO_PLL1_OUT>; > assigned-clock-rates = <0>, <0>, <0>, <594000000>; > + interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>; > + interconnect-names = "dram"; Hmm, two interconnect phandles but only one name? Shawn > status = "disabled"; > > port@0 { > -- > 2.20.1 >
On 15.01.21 10:47, Shawn Guo wrote: > On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote: >> Add interconnect ports for lcdif to set bus capabilities. >> >> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> >> --- >> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> index 89e7de2e7f7a..9300be8c9b53 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> @@ -11,6 +11,7 @@ >> #include "dt-bindings/input/input.h" >> #include <dt-bindings/interrupt-controller/arm-gic.h> >> #include <dt-bindings/thermal/thermal.h> >> +#include <dt-bindings/interconnect/imx8mq.h> >> #include "imx8mq-pinfunc.h" >> >> / { >> @@ -522,6 +523,8 @@ >> <&clk IMX8MQ_VIDEO_PLL1>, >> <&clk IMX8MQ_VIDEO_PLL1_OUT>; >> assigned-clock-rates = <0>, <0>, <0>, <594000000>; >> + interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>; >> + interconnect-names = "dram"; > > Hmm, two interconnect phandles but only one name? > Well it's one interconnect path that would more accurately be named "lcdif-dram" if that's what you mean. I removed "lcdif-" because it's the lcdif node, but maybe we should name it lcdif-dram after all. at least that's how others describe it. martin
On Fri, Jan 15, 2021 at 10:57:02AM +0100, Martin Kepplinger wrote: > > > On 15.01.21 10:47, Shawn Guo wrote: > > On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote: > > > Add interconnect ports for lcdif to set bus capabilities. > > > > > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > > > --- > > > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > index 89e7de2e7f7a..9300be8c9b53 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > @@ -11,6 +11,7 @@ > > > #include "dt-bindings/input/input.h" > > > #include <dt-bindings/interrupt-controller/arm-gic.h> > > > #include <dt-bindings/thermal/thermal.h> > > > +#include <dt-bindings/interconnect/imx8mq.h> > > > #include "imx8mq-pinfunc.h" > > > / { > > > @@ -522,6 +523,8 @@ > > > <&clk IMX8MQ_VIDEO_PLL1>, > > > <&clk IMX8MQ_VIDEO_PLL1_OUT>; > > > assigned-clock-rates = <0>, <0>, <0>, <594000000>; > > > + interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>; > > > + interconnect-names = "dram"; > > > > Hmm, two interconnect phandles but only one name? > > > > Well it's one interconnect path that would more accurately be named > "lcdif-dram" if that's what you mean. I removed "lcdif-" because it's the > lcdif node, but maybe we should name it lcdif-dram after all. at least > that's how others describe it. Ha, sorry, I misunderstood the interconnects property. Shawn
On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote: > Add interconnect ports for lcdif to set bus capabilities. > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> Applied, thanks.
On Thu, Jan 07, 2021 at 01:17:54PM +0100, Martin Kepplinger wrote: > Enable INTERCONNECT_IMX8MQ in order to make interconnect more widely > available. > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > Acked-by: Georgi Djakov <georgi.djakov@linaro.org> Applied, thanks.
revision history: v4: (thanks Shawn, Georgi and Greg) * reorder to have dt-bindings doc before code addition * add newline between dt nodes * removed "interconnect: imx8mq: Use icc_sync_state" from the patchset since it's part of gregkh/char-misc.git * Add acks v3: (thanks Krysztof and Georgi) * drop the defconfig cycling patch and fix the interconnect enable config * add the noc node to imx8mq only * add missing signed-off-by * https://lore.kernel.org/linux-arm-kernel/20201210100906.18205-1-martin.kepplinger@puri.sm/T/#t v2: (thanks Lucas) * reorder and clean up defconfig changes * use "dram" for the interconnect path name and document it * https://lore.kernel.org/linux-arm-kernel/20201201123932.12312-1-martin.kepplinger@puri.sm/T/#t v1: * https://lore.kernel.org/linux-arm-kernel/20201201100124.4676-1-martin.kepplinger@puri.sm/T/#t thanks, martin Leonard Crestez (1): arm64: dts: imx8mq: Add NOC node Martin Kepplinger (4): arm64: dts: imx8mq: Add interconnect provider property dt-bindings: mxsfb: Add interconnect bindings for LCDIF path arm64: dts: imx8mq: Add interconnect for lcdif arm64: defconfig: Enable interconnect for imx8mq .../devicetree/bindings/display/mxsfb.txt | 6 ++++ arch/arm64/boot/dts/freescale/imx8mq.dtsi | 28 +++++++++++++++++++ arch/arm64/configs/defconfig | 2 ++ 3 files changed, 36 insertions(+)