| Message ID | 20230109002935.244320-1-dmitry.baryshkov@linaro.org |
|---|---|
| Headers | show |
| Series | clk/interconnect: qcom: finish migration of IP0 to clocks | expand |
On 9.01.2023 01:29, Dmitry Baryshkov wrote: > Move the const ignore_list definition out of the > of_count_icc_providers() function. This prevents the following stack > frame size warnings if the list is expanded: > > drivers/interconnect/core.c:1082:12: warning: stack frame size (1216) exceeds limit (1024) in 'of_count_icc_providers' [-Wframe-larger-than] > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > drivers/interconnect/core.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c > index 25debded65a8..df77d2f6215d 100644 > --- a/drivers/interconnect/core.c > +++ b/drivers/interconnect/core.c > @@ -1079,15 +1079,16 @@ void icc_provider_del(struct icc_provider *provider) > } > EXPORT_SYMBOL_GPL(icc_provider_del); > > +static const struct of_device_id __maybe_unused ignore_list[] = { > + { .compatible = "qcom,sc7180-ipa-virt" }, > + { .compatible = "qcom,sdx55-ipa-virt" }, > + {} > +}; > + > static int of_count_icc_providers(struct device_node *np) > { > struct device_node *child; > int count = 0; > - const struct of_device_id __maybe_unused ignore_list[] = { > - { .compatible = "qcom,sc7180-ipa-virt" }, > - { .compatible = "qcom,sdx55-ipa-virt" }, > - {} > - }; > > for_each_available_child_of_node(np, child) { > if (of_property_read_bool(child, "#interconnect-cells") &&
On Mon, 9 Jan 2023 02:29:23 +0200, Dmitry Baryshkov wrote: > Commits 2f3724930eb4 ("interconnect: qcom: sc7180: Drop IP0 > interconnects") and 2fb251c26560 ("interconnect: qcom: sdx55: Drop IP0 > interconnects") removed IP0 interconnects (and ipa-virt devices support) > in favour of the RPMH clocks. Follow this example for other platforms > defining IP0 RPMH resource. While we are at it, remove several leftover > from the mentioned patches. > > [...] Applied, thanks! [11/12] arm64: dts: qcom: sm8150: drop the virtual ipa-virt device commit: 88efcc060edbb277bf80768de8c2f63651d74b90 [12/12] arm64: dts: qcom: sm8250: drop the virtual ipa-virt device commit: 6af6827fb0c412581f89d5c0c865892ddf984fab Best regards,
Commits 2f3724930eb4 ("interconnect: qcom: sc7180: Drop IP0 interconnects") and 2fb251c26560 ("interconnect: qcom: sdx55: Drop IP0 interconnects") removed IP0 interconnects (and ipa-virt devices support) in favour of the RPMH clocks. Follow this example for other platforms defining IP0 RPMH resource. While we are at it, remove several leftover from the mentioned patches. Changes since v2: - Fixed the stack frame size warning by moving the ignore_list out of the function to the rodata section. Changes since v1: - Reorder patches to put clock patch after the interconnect patches (Alex) - Add comments in place of removed defines (Alex) - Drop ipa-virt nodes from device trees - Add removed ipa-virt nodes to the blacklist in of_count_icc_providers to let icc_sync_state work even with non-updated device trees. Dmitry Baryshkov (12): interconnect: qcom: sdx55: drop IP0 remnants interconnect: qcom: sc7180: drop IP0 remnants interconnect: move ignore_list out of of_count_icc_providers() interconnect: qcom: sm8150: Drop IP0 interconnects interconnect: qcom: sm8250: Drop IP0 interconnects interconnect: qcom: sc8180x: Drop IP0 interconnects interconnect: qcom: sc8280xp: Drop IP0 interconnects dt-bindings: interconnect: qcom: Remove ipa-virt compatibles dt-bindings: interconnect: qcom: drop IPA_CORE related defines clk: qcom: rpmh: define IPA clocks where required arm64: dts: qcom: sm8150: drop the virtual ipa-virt device arm64: dts: qcom: sm8250: drop the virtual ipa-virt device .../bindings/interconnect/qcom,rpmh.yaml | 3 -- arch/arm64/boot/dts/qcom/sm8150.dtsi | 7 ---- arch/arm64/boot/dts/qcom/sm8250.dtsi | 7 ---- drivers/clk/qcom/clk-rpmh.c | 4 ++ drivers/interconnect/core.c | 14 ++++--- drivers/interconnect/qcom/sc7180.h | 4 +- drivers/interconnect/qcom/sc8180x.c | 38 ------------------- drivers/interconnect/qcom/sc8180x.h | 4 +- drivers/interconnect/qcom/sc8280xp.c | 25 ------------ drivers/interconnect/qcom/sc8280xp.h | 4 +- drivers/interconnect/qcom/sdx55.h | 4 +- drivers/interconnect/qcom/sm8150.c | 21 ---------- drivers/interconnect/qcom/sm8150.h | 4 +- drivers/interconnect/qcom/sm8250.c | 21 ---------- drivers/interconnect/qcom/sm8250.h | 4 +- .../dt-bindings/interconnect/qcom,sc7180.h | 3 -- .../dt-bindings/interconnect/qcom,sc8180x.h | 3 -- .../dt-bindings/interconnect/qcom,sc8280xp.h | 4 +- include/dt-bindings/interconnect/qcom,sdx55.h | 2 - .../dt-bindings/interconnect/qcom,sm8150.h | 3 -- .../dt-bindings/interconnect/qcom,sm8250.h | 3 -- 21 files changed, 27 insertions(+), 155 deletions(-)