mbox series

[v2,0/2] i2c: Reduce use of i2c_of_match_device()

Message ID 20250213114613.2646933-1-andriy.shevchenko@linux.intel.com
Headers show
Series i2c: Reduce use of i2c_of_match_device() | expand

Message

Andy Shevchenko Feb. 13, 2025, 11:45 a.m. UTC 
The i2c_of_match_device() was developed as internal API and was exported just
in case well before we get an idea of the generic helper for getting driver
data for the matched device. For all the times of i2c_of_match_device() being
exported there were _only_ three users, two of which had been already converted
to better API. For preventing the use of i2c_of_match_device(), make it private
to I²C subsystem.

This is assumed to go via I²C tree, but can be done differently taking into
account the immutable tag or branch for involved subsystems.

In v2:
- collected tags (Sebastian)
- removed one leftover in the first patch

Andy Shevchenko (2):
  power: ip5xxx_power: Make use of i2c_get_match_data()
  i2c: Unexport i2c_of_match_device()

 drivers/i2c/i2c-core-of.c           |  1 -
 drivers/i2c/i2c-core.h              |  9 +++++++++
 drivers/power/supply/ip5xxx_power.c |  7 ++-----
 include/linux/i2c.h                 | 11 -----------
 4 files changed, 11 insertions(+), 17 deletions(-)

Comments

Vladimir Zapolskiy Feb. 13, 2025, 12:09 p.m. UTC | #1 
On 2/13/25 13:45, Andy Shevchenko wrote:
> Get matching data in one step by switching to use i2c_get_match_data().
> 
> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>

--
Best wishes,
Vladimir