mbox series

[0/6] RK3576 thermal sensor support, including OTP trim adjustments

Message ID 20250216-rk3576-tsadc-upstream-v1-0-6ec969322a14@collabora.com
Headers show
Series RK3576 thermal sensor support, including OTP trim adjustments | expand

Message

Nicolas Frattaroli Feb. 15, 2025, 11:34 p.m. UTC 
This series adds support for the RK3576's thermal sensor.

The sensor has six channels, providing measurements for the package
temperature, the temperature of the big cores, the temperature of the
little cores, and the GPU, NPU and DDR controller.

In addition to adding support for the sensor itself, the series also
adds support for reading thermal trim values out of the device tree.
Most of this functionality is not specific to this SoC, but needed to be
implemented to make the sensors a little more accurate in order to
investigate whether the TRM swapped GPU and DDR or downstream swapped
GPU and DDR in terms of channel IDs, as downstream disagrees with what's
in the TRM, and the difference is so small and hard to pin down with
testing that the constant offset between the two sensors was a little
annoying for me to deal with.

I ended up going with the channel assignment the TRM lists, as I see the
DDR sensor get a larger deviation from baseline temperatures during memory
stress tests (stress-ng --memrate 8 --memrate-flush) than what the TRM
claims is the GPU sensor but downstream claims is the DDR sensor. Input
from Rockchip engineers on whether the TRM is right or wrong welcome.

The trim functionality is only used by RK3576 at the moment. Code to
handle other SoCs can rely on the shared otp reading and perhaps even
the IP revision specific function, but may need its own IP revision
specific functions added as well. Absent trim functionality in other
SoCs should not interfere with the modified common code paths.

Patch 1 adds the RK3576 compatible to the bindings.

Patch 2 adds the basic thermal nodes required to get temperature
readings and device throttling to the rk3576.dtsi device tree.

Patch 3 adds support for this SoC's thermal chip to the driver. It is a
port of the downstream commit adding support for this.

Patch 4 adds some documentation for imminent additional functionality to
the binding, namely the trim value stuff.

Patch 5 adds the requisite OTP cells and tsadc nodes to the SoC's device
tree, conforming with the bindings modified in Patch 4.

Patch 6 adds support for reading these OTP values in the
rockchip_thermal driver, and makes use of them. The code is mostly new
upstream code written by me, using downstream code as reference.

This series depends on Heiko's OTP series[1]. You can grab yourself a
spicy linux-next based tree from [2] with both changesets if you just
want to give it a spin on your own board.

[1]: https://lore.kernel.org/linux-rockchip/20250210224510.1194963-1-heiko@sntech.de/
[2]: https://gitlab.collabora.com/fratti/linux/-/tree/rk3576-thermal-adc-4

Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
---
Nicolas Frattaroli (5):
      dt-bindings: rockchip-thermal: Add RK3576 compatible
      arm64: dts: rockchip: Add thermal nodes to RK3576
      dt-bindings: thermal: rockchip: document otp thermal trim
      arm64: dts: rockchip: Add thermal trim OTP and tsadc nodes
      thermal: rockchip: support reading trim values from OTP

Ye Zhang (1):
      thermal: rockchip: Support RK3576 SoC in the thermal driver

 .../bindings/thermal/rockchip-thermal.yaml         |  45 ++++
 arch/arm64/boot/dts/rockchip/rk3576.dtsi           | 239 +++++++++++++++++-
 drivers/thermal/rockchip_thermal.c                 | 280 +++++++++++++++++++--
 3 files changed, 540 insertions(+), 24 deletions(-)
---
base-commit: 6f5eb5a1b91efbc9317ac7a55c5c9e74be3e358d
change-id: 20250215-rk3576-tsadc-upstream-7e0c193f768a
prerequisite-message-id: <20250210224510.1194963-1-heiko@sntech.de>
prerequisite-patch-id: 8b8d7c74c83755b87a59b37dfa1c335a84f4fbda
prerequisite-patch-id: 39def5e1f0f4ae6f182cf50b42e1e43a90d0991d
prerequisite-patch-id: bf402264f426cb53f5a40b36dea74e0e2def5621
prerequisite-patch-id: fb7a67402ea0d8792cbcefed9239ad141689e33a
prerequisite-patch-id: ae942d1f9e0e9d8e0b0ca493b8ec0bd5994365ae
prerequisite-patch-id: 12e5d422403737e300ba9563f7d4338e356d0299

Best regards,