mbox series

[0/2] power: supply: max77705: Fix two static checker issues

Message ID 94f55158-1776-4f2f-9296-e307e83d569a@stanley.mountain
Headers show
Series power: supply: max77705: Fix two static checker issues | expand

Message

Dan Carpenter March 21, 2025, 2:34 p.m. UTC 
Fix some error handling and an error code bug.

Dan Carpenter (2):
  power: supply: max77705: Fix workqueue error handling in probe
  power: supply: max77705: Fix error code in max77705_get_health()

 drivers/power/supply/max77705_charger.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

Comments

Sebastian Reichel April 28, 2025, 11:30 p.m. UTC | #1 
Hi,

On Tue, Apr 29, 2025 at 12:18:43AM +0200, Sebastian Reichel wrote:
> On Fri, 21 Mar 2025 17:34:00 +0300, Dan Carpenter wrote:
> > Fix some error handling and an error code bug.
> > 
> > Dan Carpenter (2):
> >   power: supply: max77705: Fix workqueue error handling in probe
> >   power: supply: max77705: Fix error code in max77705_get_health()
> > 
> > drivers/power/supply/max77705_charger.c | 22 +++++++++++++++-------
> >  1 file changed, 15 insertions(+), 7 deletions(-)
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/2] power: supply: max77705: Fix workqueue error handling in probe
>       commit: 11741b8e382d34b13277497ab91123d8b0b5c2db

I've queued it, since it improves the driver. But the workqueue also
needs to be released when the module is removed. So I think the
destroy_workqueue() should happen via devm_add_action_or_reset()
instead of what this patch is doing.

Greetings,

-- Sebastian