From patchwork Thu Oct 20 06:53:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 78411 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp628785qge; Wed, 19 Oct 2016 23:52:16 -0700 (PDT) X-Received: by 10.98.193.2 with SMTP id i2mr18746326pfg.155.1476946336275; Wed, 19 Oct 2016 23:52:16 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s3si43546721pfi.277.2016.10.19.23.52.14; Wed, 19 Oct 2016 23:52:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751481AbcJTGwM (ORCPT + 14 others); Thu, 20 Oct 2016 02:52:12 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:55919 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753391AbcJTGwM (ORCPT ); Thu, 20 Oct 2016 02:52:12 -0400 X-Greylist: delayed 530 seconds by postgrey-1.27 at vger.kernel.org; Thu, 20 Oct 2016 02:52:11 EDT Received: from beagle.diag.org (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-10.nifty.com with ESMTP id u9K6pTOh030296; Thu, 20 Oct 2016 15:51:30 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com u9K6pTOh030296 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1476946290; bh=E7+M08DoQJQx5y7nhXyOCxxMHynAvaQhTFqgyem80EA=; h=From:To:Cc:Subject:Date:From; b=OVwC3mk/D1qZkxEMIYr+MYH/UKjxsLVaW1V2DW0f6RAW0R/5I0AVcbWc8drGcnN7Q HsENTa/JxT4syO5XBDqljBQQmZHRlKFcwI6HLkDsqxcw/mzz7vxyJD6WzG419yAFt+ OGNRO1rmoNGt4xB9xMFKtHCUOSxMf2U79fSZJXfKQ0W5x16A+omzE0uxQQMtRqpDVs G1uOUYqnxqj44rU0y1DT8S39tpXKZCWghohv+vhzp2RMIeU4nD+qJO5cfz0OH6RtPV ga5q3Mv6NtowC1MDI350Kk9nQvTNf5wk1P32utcAxdjPWft0IMiwoGJKWz+xboFjx2 3N4UxEa10YaBg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-pm@vger.kernel.org Cc: Masahiro Yamada , Stephen Boyd , linux-kernel@vger.kernel.org, Nishanth Menon , Len Brown , Greg Kroah-Hartman , "Rafael J. Wysocki" , Pavel Machek , Viresh Kumar Subject: [PATCH] PM / OPP: fix debug/error messages in dev_pm_opp_of_get_sharing_cpus() Date: Thu, 20 Oct 2016 15:53:56 +0900 Message-Id: <1476946436-27425-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org These comments are wrong because _of_get_opp_desc_node() returns an operating-points-v2 node. Commit a6eed752f5fb ("PM / OPP: passing NULL to PTR_ERR()") fixed static checker warnings, and reworded the messages at the same time (but the latter was not mentioned in the git-log). Restore the correct messages, dropping __func__. We can grep the message string, so the function name would not carry much value. Signed-off-by: Masahiro Yamada --- drivers/base/power/opp/of.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/base/power/opp/of.c b/drivers/base/power/opp/of.c index 6480137..92e6d53 100644 --- a/drivers/base/power/opp/of.c +++ b/drivers/base/power/opp/of.c @@ -562,7 +562,7 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, /* Get OPP descriptor node */ np = _of_get_opp_desc_node(cpu_dev); if (!np) { - dev_dbg(cpu_dev, "%s: Couldn't find cpu_dev node.\n", __func__); + dev_dbg(cpu_dev, "Couldn't find opp node.\n"); return -ENOENT; } @@ -587,8 +587,7 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, /* Get OPP descriptor node */ tmp_np = _of_get_opp_desc_node(tcpu_dev); if (!tmp_np) { - dev_err(tcpu_dev, "%s: Couldn't find tcpu_dev node.\n", - __func__); + dev_err(tcpu_dev, "Couldn't find opp node.\n"); ret = -ENOENT; goto put_cpu_node; }