From patchwork Fri May 18 10:31:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 136279 Delivered-To: patches@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp1056519lji; Fri, 18 May 2018 03:31:48 -0700 (PDT) X-Received: by 2002:a2e:2283:: with SMTP id i125-v6mr5612982lji.47.1526639508744; Fri, 18 May 2018 03:31:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526639508; cv=none; d=google.com; s=arc-20160816; b=Xf/DwN3uM20h3U+hn1dsPrghCAg+y9u+X2lcuFBQi4pA81aJU1tUxCpkir5t+u+gQH Ww14T9hhFSob71+IuWZqQULZaClyiClFPlB2LGcCiaTl690ag8p6+EYyV9WTnDw/zud1 5xLDccw5Bt9lWA9TS36XsXc31rZIZ/HKaFu48XODyZrbt+biM2HuW0+LempKHaYCM0pB Tc8LWJxlhEBY5tcXMsCQ2sO1jA6BkIj+3XrG7aOSAgT9CG8boz3Ltxm0/D5SgbBF9jl5 fWDaZ+ry5RelD9tvy3afN4lsiOMm4aOpuyphKVk1zJJd7XwCH5uI58K8iSFkQDIiWx6Q MgHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=RPhKlg5dvZpNzCvJuZWRD2r+4coRtPy1rCugMyAhTzk=; b=ubaWehlCek5FNWTfV42GLh3REmMbfqDG/a7YrdlYazlOVjwtl0NF3zamztiU9xF2Y2 xl1RNx2li4joUaRQQWyBs0ewBY8wtVfl0awgxhXSeS2rDpulqypOeRRxJlF0u3PzjnRa vkQqaXeBrbc++4dXNyfTaRU8JHEm5dqKq9yH97dp1gzCsZ2+idtUeA5xfWUW2m/LDnZX R51ANfs0JLk7Qlvatjmx5HqfYtROroDaG2fhokmjF6Wc/+lbsXxMhTm91Fy1I6tIfyw8 VmWA4euQ6nFqVqQ5PBEdTjHTOZhlvlmcQ6EIBjKvD3gAY7l0VeKdNGbL7nDXg+RgM0L4 1mwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PsO2ofpj; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id u8-v6sor1744516ljg.101.2018.05.18.03.31.48 for (Google Transport Security); Fri, 18 May 2018 03:31:48 -0700 (PDT) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PsO2ofpj; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RPhKlg5dvZpNzCvJuZWRD2r+4coRtPy1rCugMyAhTzk=; b=PsO2ofpjBYwRdxZ4mbNfW3jvo4qW66HdVRL1oy5hkczANz5wED/fh4nygCXznJDCVB gXTIj1v3XJGCy6bfvilz4jjO7heoLOis7WWlOG4MbNrVpZjwZqxcsxFvVmJEHGzrZGHG ImHFI2D4yiStK+g8m2PHzqEuzhbM1geaq4thY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RPhKlg5dvZpNzCvJuZWRD2r+4coRtPy1rCugMyAhTzk=; b=dCW8xBzVqB0FQlvyjG8cWAvYHjkaMCleq4GfYZNk9BbslS4Tlv2WrSzzF3DPjHcA2F Gl9n/QtftQhek2T7MTHpHWMniPSQ6NPs5Ac9Q+WFfu/1MzzjTyRi2BI+bW/PH5b4NmQn SMNGOAplIjvlNA6KzKv9FcFMYUwyslOQ1dSbaj5XX1M/eutJD4KYo0iOMI0eKBBrCUr3 2GWHRFix3dYzR49SQQnUy0meLc0vTbZLsYyFZ5eKbOHVgdxNO4vPMdfXrypnIoNsFbYI cV/qLXMIlo1zMc/Y/Azf93EHigkcjB2wBYzAR1vJ9N/W7WQI6F4ZxFOndOdzFVESU8sO aUGA== X-Gm-Message-State: ALKqPwdIB4ba8ulSGd+caQqHjUO3982itSrAXLZLMyWPfzVR33US1QrO 3AE1DpsyUWRAw4XuW7GIvAtBc/8l X-Google-Smtp-Source: AB8JxZr2hIzXfxG7I9BP9a8HDr3UDRB+UeMrabZpIjsCL9BeUCmjLFKw73Tl8Kv+ZETL48PRIrtilQ== X-Received: by 2002:a2e:9f56:: with SMTP id v22-v6mr5253112ljk.42.1526639508531; Fri, 18 May 2018 03:31:48 -0700 (PDT) Return-Path: Received: from localhost.localdomain (h-158-174-22-210.NA.cust.bahnhof.se. [158.174.22.210]) by smtp.gmail.com with ESMTPSA id u14-v6sm393447lfk.55.2018.05.18.03.31.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 18 May 2018 03:31:47 -0700 (PDT) From: Ulf Hansson To: "Rafael J . Wysocki" , linux-pm@vger.kernel.org Cc: Ulf Hansson , Greg Kroah-Hartman , Jon Hunter , Geert Uytterhoeven , Todor Tomov , Rajendra Nayak , Viresh Kumar , Vincent Guittot , Kevin Hilman , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: [PATCH 1/9] PM / Domains: Drop extern declarations of functions in pm_domain.h Date: Fri, 18 May 2018 12:31:22 +0200 Message-Id: <1526639490-12167-2-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1526639490-12167-1-git-send-email-ulf.hansson@linaro.org> References: <1526639490-12167-1-git-send-email-ulf.hansson@linaro.org> Using "extern" to declare a function in a public header file is somewhat pointless, but also doesn't hurt. However, to make all the function declarations in pm_domain.h to be consistent, let's drop the use of "extern". Signed-off-by: Ulf Hansson --- include/linux/pm_domain.h | 51 +++++++++++++++++++++-------------------------- 1 file changed, 23 insertions(+), 28 deletions(-) -- 2.7.4 diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h index 4e57640..c847e9a 100644 --- a/include/linux/pm_domain.h +++ b/include/linux/pm_domain.h @@ -143,21 +143,17 @@ static inline struct generic_pm_domain_data *dev_gpd_data(struct device *dev) return to_gpd_data(dev->power.subsys_data->domain_data); } -extern int __pm_genpd_add_device(struct generic_pm_domain *genpd, - struct device *dev, - struct gpd_timing_data *td); - -extern int pm_genpd_remove_device(struct generic_pm_domain *genpd, - struct device *dev); -extern int pm_genpd_add_subdomain(struct generic_pm_domain *genpd, - struct generic_pm_domain *new_subdomain); -extern int pm_genpd_remove_subdomain(struct generic_pm_domain *genpd, - struct generic_pm_domain *target); -extern int pm_genpd_init(struct generic_pm_domain *genpd, - struct dev_power_governor *gov, bool is_off); -extern int pm_genpd_remove(struct generic_pm_domain *genpd); -extern int dev_pm_genpd_set_performance_state(struct device *dev, - unsigned int state); +int __pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev, + struct gpd_timing_data *td); +int pm_genpd_remove_device(struct generic_pm_domain *genpd, struct device *dev); +int pm_genpd_add_subdomain(struct generic_pm_domain *genpd, + struct generic_pm_domain *new_subdomain); +int pm_genpd_remove_subdomain(struct generic_pm_domain *genpd, + struct generic_pm_domain *target); +int pm_genpd_init(struct generic_pm_domain *genpd, + struct dev_power_governor *gov, bool is_off); +int pm_genpd_remove(struct generic_pm_domain *genpd); +int dev_pm_genpd_set_performance_state(struct device *dev, unsigned int state); extern struct dev_power_governor simple_qos_governor; extern struct dev_power_governor pm_domain_always_on_gov; @@ -215,8 +211,8 @@ static inline int pm_genpd_add_device(struct generic_pm_domain *genpd, } #ifdef CONFIG_PM_GENERIC_DOMAINS_SLEEP -extern void pm_genpd_syscore_poweroff(struct device *dev); -extern void pm_genpd_syscore_poweron(struct device *dev); +void pm_genpd_syscore_poweroff(struct device *dev); +void pm_genpd_syscore_poweron(struct device *dev); #else static inline void pm_genpd_syscore_poweroff(struct device *dev) {} static inline void pm_genpd_syscore_poweron(struct device *dev) {} @@ -240,14 +236,13 @@ int of_genpd_add_provider_simple(struct device_node *np, int of_genpd_add_provider_onecell(struct device_node *np, struct genpd_onecell_data *data); void of_genpd_del_provider(struct device_node *np); -extern int of_genpd_add_device(struct of_phandle_args *args, - struct device *dev); -extern int of_genpd_add_subdomain(struct of_phandle_args *parent, - struct of_phandle_args *new_subdomain); -extern struct generic_pm_domain *of_genpd_remove_last(struct device_node *np); -extern int of_genpd_parse_idle_states(struct device_node *dn, - struct genpd_power_state **states, int *n); -extern unsigned int of_genpd_opp_to_performance_state(struct device *dev, +int of_genpd_add_device(struct of_phandle_args *args, struct device *dev); +int of_genpd_add_subdomain(struct of_phandle_args *parent, + struct of_phandle_args *new_subdomain); +struct generic_pm_domain *of_genpd_remove_last(struct device_node *np); +int of_genpd_parse_idle_states(struct device_node *dn, + struct genpd_power_state **states, int *n); +unsigned int of_genpd_opp_to_performance_state(struct device *dev, struct device_node *opp_node); int genpd_dev_pm_attach(struct device *dev); @@ -304,9 +299,9 @@ struct generic_pm_domain *of_genpd_remove_last(struct device_node *np) #endif /* CONFIG_PM_GENERIC_DOMAINS_OF */ #ifdef CONFIG_PM -extern int dev_pm_domain_attach(struct device *dev, bool power_on); -extern void dev_pm_domain_detach(struct device *dev, bool power_off); -extern void dev_pm_domain_set(struct device *dev, struct dev_pm_domain *pd); +int dev_pm_domain_attach(struct device *dev, bool power_on); +void dev_pm_domain_detach(struct device *dev, bool power_off); +void dev_pm_domain_set(struct device *dev, struct dev_pm_domain *pd); #else static inline int dev_pm_domain_attach(struct device *dev, bool power_on) {