From patchwork Sat Dec 12 10:57:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 342869 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp1348699jai; Sat, 12 Dec 2020 02:59:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJz10DvYLYgEcA61pQW/JKA2AZHT9lyiFCHBjwDqtHTxY/fTwBn2i4YVuMur3dLfUe3NagcR X-Received: by 2002:a17:906:fc3:: with SMTP id c3mr15255351ejk.474.1607770760656; Sat, 12 Dec 2020 02:59:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607770760; cv=none; d=google.com; s=arc-20160816; b=k9vJTTV4Z+5/peICwPKaGmhAj5E7j5osGErC+wWVTiCsS6bPkJ62hpDeRLSy/L5YLE Yx+dmTVFUc5ilK1bFR6whDuAqL6XtDzJEUDR4gBvfV8nwnZYxWQWb/IldK9hCeg+j8iS ajc9U/tDtF0pumSD59LDB/yiKhmvbJ+vhVY3k5mO49ZOB8dGp/nsQCIgJQq7vx4HSkpe HNg/uPKdbDhTXWE5ZmL2cvZcnjFnE1us6elXpBzbZzH/7zrJP8Sn406MJpnEY64MRbX1 HZM7EOOGFozHTW0E3YFaBVo9bcmopgu/9Do193k6deNrwmtk/tzhvSrWVtc/EEsjYO7E Wnvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=U9ki1Yt4gjIfiYkS0P/4SKvIacQ9wKk9cuDvKvw5s1A=; b=fzCEULjlokHYEJbWHmjJpTMAEZFDKEPCgX7TOzugdxQRHESbcO9p7yFsheyrInIIPp YqkY9t1YStogcxOojXazIlywO/+4psmqTLaK9ssgQIY2WBebzb4e3RGM1U0tCHEgYmVG bP9kbhrBmScqb9lKQIq7bDSj2FF0F6W1LHpHBJEl3oAmg8WDXMhZGvdXkZDYSJtw63HU jTmnFYw54ylfJuGnLkl3xqk7lw+To3zGkI5qXFDSyagH4rEC6dApFv5TfMNVFj6gTSxf KeE4s3LOWX4pyw1JPu85GOJpBfWPGlx8O2uV7w3VJ3P0N4R9bqmxCBBUKrsj7XA/GnCU cWlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=V1cRNEcv; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp1si6354112ejc.21.2020.12.12.02.59.20; Sat, 12 Dec 2020 02:59:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=V1cRNEcv; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438853AbgLLK6L (ORCPT + 8 others); Sat, 12 Dec 2020 05:58:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438856AbgLLK6F (ORCPT ); Sat, 12 Dec 2020 05:58:05 -0500 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41351C061794 for ; Sat, 12 Dec 2020 02:57:25 -0800 (PST) Received: by mail-lf1-x142.google.com with SMTP id w13so17965649lfd.5 for ; Sat, 12 Dec 2020 02:57:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=U9ki1Yt4gjIfiYkS0P/4SKvIacQ9wKk9cuDvKvw5s1A=; b=V1cRNEcv/63CSwMTY5HdzFgTOXrLNfnAD6jxwYDIZgdQ6BaGd0ECcNDU2dyIthVkhZ vxCoUz5zOq4S83Uz/D2OD/x+XDF34PRmN7zvFMvPt5ZczVUPabamei65vuIQxvz/U2sh vRu4tfjLqSE8arKhxalPBHcXRWBVQU1uvyRwOw5qDOegVUI4Xi6RC+gqfmwgh3xChGRU 3oCzsAp5hafSsEk4GkyLaLFqbPux/+ChNU2jdGqbQykPwFfnqsQt8xXduLWv9aSi8ABw qWHrXeskl60dumiBGuefooFu3V3yN1NFl7CmJ5WLPSGZDk6asQJUmJe543Sf+67tj6Yu 6Hgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=U9ki1Yt4gjIfiYkS0P/4SKvIacQ9wKk9cuDvKvw5s1A=; b=IJX9xJ0YhToZwJsAbhwpTeinB8O4HJrBCcifnuXcKvixeWhSaXLqNJml8Q4RbBwIYr +cafh7p+XoPjh2fbhp6JKhmVLQH2Om7T6dydi1c186/SO+QwFjgbhes4lmgIy1RQs5up AzlUIPpiiCUjBRDjx5DC2fRUVFhLGETOVfdu1X/1UUjQGhyolaCc9nExWsMh1on69iiJ nwdhSxPbv+qnl2ljWMn+S/Uw/GNnQxQDUx4L7vxPNTUqYIpF55hTJ6Kurg3FOKABYluz WbpNy2q4mgq9j+El3vLq0s9mKsusX3cZCb76aFQTxTMm8nSWYf+mDilbzuj96+CSn0y+ SgJQ== X-Gm-Message-State: AOAM530wRotwLxvevoD4AOYmydqePCWqwuwkNAP7zFlIoUNRdz1N4PHF xxknplxp7kGKUed8UYNcard87g== X-Received: by 2002:a05:651c:200a:: with SMTP id s10mr6808399ljo.492.1607770643811; Sat, 12 Dec 2020 02:57:23 -0800 (PST) Received: from localhost.bredbandsbolaget (c-92d7225c.014-348-6c756e10.bbcust.telenor.se. [92.34.215.146]) by smtp.gmail.com with ESMTPSA id j2sm490674lfe.213.2020.12.12.02.57.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Dec 2020 02:57:23 -0800 (PST) From: Linus Walleij To: Sebastian Reichel , Marcus Cooper Cc: linux-pm@vger.kernel.org, Linus Walleij Subject: [PATCH 3/5] power: supply: ab8500_charger: Oneshot threaded IRQs Date: Sat, 12 Dec 2020 11:57:10 +0100 Message-Id: <20201212105712.2727842-4-linus.walleij@linaro.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201212105712.2727842-1-linus.walleij@linaro.org> References: <20201212105712.2727842-1-linus.walleij@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Make sure the threaded IRQs requested by the charger are flagged as "oneshot". Usually this is what you want, and since the interrupts are shared with the USB phy on the AB8500 we will get a conflict like this if we don't, since the phy request them threaded oneshot: genirq: Flags mismatch irq 83. 00004084 (USB_LINK_STATUS vs. 00006084 (usb-link-status) ab8500-charger ab8500-charger.0: failed to request USB_LINK_STATUS IRQ 83: -16 Cc: Marcus Cooper Signed-off-by: Linus Walleij --- drivers/power/supply/ab8500_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.26.2 diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c index 47f1ce1012f4..d4b7bd68451b 100644 --- a/drivers/power/supply/ab8500_charger.c +++ b/drivers/power/supply/ab8500_charger.c @@ -3596,7 +3596,7 @@ static int ab8500_charger_probe(struct platform_device *pdev) } ret = request_threaded_irq(irq, NULL, ab8500_charger_irq[i].isr, - IRQF_SHARED | IRQF_NO_SUSPEND, + IRQF_SHARED | IRQF_NO_SUSPEND | IRQF_ONESHOT, ab8500_charger_irq[i].name, di); if (ret != 0) {