diff mbox series

[v3,1/7] extcon: max8997: Add CHGINS and CHGRM interrupt handling

Message ID 20201222070520.710096-1-timon.baetz@protonmail.com
State Superseded
Headers show
Series [v3,1/7] extcon: max8997: Add CHGINS and CHGRM interrupt handling | expand

Commit Message

Timon Baetz Dec. 22, 2020, 7:31 a.m. UTC
This allows the MAX8997 charger to set the current limit depending on
the detected extcon charger type.

Signed-off-by: Timon Baetz <timon.baetz@protonmail.com>
---
 drivers/extcon/extcon-max8997.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Krzysztof Kozlowski Dec. 22, 2020, 8:37 a.m. UTC | #1
On Tue, Dec 22, 2020 at 07:31:32AM +0000, Timon Baetz wrote:
> Add of_compatible ("maxim,max8997-muic") to the mfd_cell to have a
> of_node set in the extcon driver.
> 
> Add of_compatible ("maxim,max8997-battery") to the mfd_cell to configure
> the charger driver.
> 
> Signed-off-by: Timon Baetz <timon.baetz@protonmail.com>
> ---
>  drivers/mfd/max8997.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
Lee Jones Dec. 22, 2020, 9:55 a.m. UTC | #2
On Tue, 22 Dec 2020, Timon Baetz wrote:

> Add of_compatible ("maxim,max8997-muic") to the mfd_cell to have a
> of_node set in the extcon driver.
> 
> Add of_compatible ("maxim,max8997-battery") to the mfd_cell to configure
> the charger driver.
> 
> Signed-off-by: Timon Baetz <timon.baetz@protonmail.com>
> ---
>  drivers/mfd/max8997.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.
Timon Baetz Feb. 11, 2021, 9:11 p.m. UTC | #3
On Tue, 22 Dec 2020 09:55:22 +0000, Lee Jones wrote:
> On Tue, 22 Dec 2020, Timon Baetz wrote:

> 

> > Add of_compatible ("maxim,max8997-muic") to the mfd_cell to have a

> > of_node set in the extcon driver.

> >

> > Add of_compatible ("maxim,max8997-battery") to the mfd_cell to configure

> > the charger driver.

> >

> > Signed-off-by: Timon Baetz <timon.baetz@protonmail.com>

> > ---

> >  drivers/mfd/max8997.c | 4 ++--

> >  1 file changed, 2 insertions(+), 2 deletions(-)  

> 

> Applied, thanks.


Once https://lore.kernel.org/lkml/20210130172747.2022977-1-timon.baetz@protonmail.com/
gets accepted, this is not needed anymore. Can this be reverted or
should I create a new patch?

Thanks,
Timon
Lee Jones Feb. 12, 2021, 9:37 a.m. UTC | #4
On Thu, 11 Feb 2021, Timon Baetz wrote:

> On Tue, 22 Dec 2020 09:55:22 +0000, Lee Jones wrote:
> > On Tue, 22 Dec 2020, Timon Baetz wrote:
> > 
> > > Add of_compatible ("maxim,max8997-muic") to the mfd_cell to have a
> > > of_node set in the extcon driver.
> > >
> > > Add of_compatible ("maxim,max8997-battery") to the mfd_cell to configure
> > > the charger driver.
> > >
> > > Signed-off-by: Timon Baetz <timon.baetz@protonmail.com>
> > > ---
> > >  drivers/mfd/max8997.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)  
> > 
> > Applied, thanks.
> 
> Once https://lore.kernel.org/lkml/20210130172747.2022977-1-timon.baetz@protonmail.com/
> gets accepted, this is not needed anymore. Can this be reverted or
> should I create a new patch?

Please submit a revert with the reasons why.
diff mbox series

Patch

diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
index 337b0eea4e62..e1408075ef7d 100644
--- a/drivers/extcon/extcon-max8997.c
+++ b/drivers/extcon/extcon-max8997.c
@@ -44,6 +44,8 @@  static struct max8997_muic_irq muic_irqs[] = {
 	{ MAX8997_MUICIRQ_ChgDetRun,	"muic-CHGDETRUN" },
 	{ MAX8997_MUICIRQ_ChgTyp,	"muic-CHGTYP" },
 	{ MAX8997_MUICIRQ_OVP,		"muic-OVP" },
+	{ MAX8997_PMICIRQ_CHGINS,	"pmic-CHGINS" },
+	{ MAX8997_PMICIRQ_CHGRM,	"pmic-CHGRM" },
 };
 
 /* Define supported cable type */
@@ -538,6 +540,8 @@  static void max8997_muic_irq_work(struct work_struct *work)
 	case MAX8997_MUICIRQ_DCDTmr:
 	case MAX8997_MUICIRQ_ChgDetRun:
 	case MAX8997_MUICIRQ_ChgTyp:
+	case MAX8997_PMICIRQ_CHGINS:
+	case MAX8997_PMICIRQ_CHGRM:
 		/* Handle charger cable */
 		ret = max8997_muic_chg_handler(info);
 		break;