diff mbox series

[thermal-next,v2,1/2] thermal: qcom: tsens: init debugfs only with successful probe

Message ID 20210429010518.13319-2-ansuelsmth@gmail.com
State New
Headers show
Series Minor fix for qcom tsens driver | expand

Commit Message

Ansuel Smith April 29, 2021, 1:05 a.m. UTC
calibrate and tsens_register can fail or PROBE_DEFER. This will cause a
double or a wrong init of the debugfs information. Init debugfs only
with successful probe fixing warning about directory already present.

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
 drivers/thermal/qcom/tsens.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comments

Thara Gopinath May 10, 2021, 12:41 p.m. UTC | #1
On 4/28/21 9:05 PM, Ansuel Smith wrote:
> calibrate and tsens_register can fail or PROBE_DEFER. This will cause a

> double or a wrong init of the debugfs information. Init debugfs only

> with successful probe fixing warning about directory already present.

> 

> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>


Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org>


-- 
Warm Regards
Thara
> ---

>   drivers/thermal/qcom/tsens.c | 9 ++++++---

>   1 file changed, 6 insertions(+), 3 deletions(-)

> 

> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c

> index d8ce3a687b80..b37d5fd71f3a 100644

> --- a/drivers/thermal/qcom/tsens.c

> +++ b/drivers/thermal/qcom/tsens.c

> @@ -845,8 +845,6 @@ int __init init_common(struct tsens_priv *priv)

>   	if (tsens_version(priv) >= VER_0_1)

>   		tsens_enable_irq(priv);

>   

> -	tsens_debug_init(op);

> -

>   err_put_device:

>   	put_device(&op->dev);

>   	return ret;

> @@ -1057,7 +1055,12 @@ static int tsens_probe(struct platform_device *pdev)

>   		}

>   	}

>   

> -	return tsens_register(priv);

> +	ret = tsens_register(priv);

> +

> +	if (!ret)

> +		tsens_debug_init(pdev);

> +

> +	return ret;

>   }

>   

>   static int tsens_remove(struct platform_device *pdev)

>
diff mbox series

Patch

diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
index d8ce3a687b80..b37d5fd71f3a 100644
--- a/drivers/thermal/qcom/tsens.c
+++ b/drivers/thermal/qcom/tsens.c
@@ -845,8 +845,6 @@  int __init init_common(struct tsens_priv *priv)
 	if (tsens_version(priv) >= VER_0_1)
 		tsens_enable_irq(priv);
 
-	tsens_debug_init(op);
-
 err_put_device:
 	put_device(&op->dev);
 	return ret;
@@ -1057,7 +1055,12 @@  static int tsens_probe(struct platform_device *pdev)
 		}
 	}
 
-	return tsens_register(priv);
+	ret = tsens_register(priv);
+
+	if (!ret)
+		tsens_debug_init(pdev);
+
+	return ret;
 }
 
 static int tsens_remove(struct platform_device *pdev)