From patchwork Sat Mar 12 04:36:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Cohen X-Patchwork-Id: 551055 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2583BC433EF for ; Sat, 12 Mar 2022 04:37:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230322AbiCLEiG (ORCPT ); Fri, 11 Mar 2022 23:38:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229502AbiCLEiG (ORCPT ); Fri, 11 Mar 2022 23:38:06 -0500 Received: from mail-0201.mail-europe.com (mail-0201.mail-europe.com [51.77.79.158]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F15915A20E for ; Fri, 11 Mar 2022 20:37:01 -0800 (PST) Date: Sat, 12 Mar 2022 04:36:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail2; t=1647059817; bh=UdpFS6g8t/sfigVRjnlG7mj5G3nr7GIWn+0FHNn7FF8=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID; b=fDlvTRj2emWHiPwixHIo73iFx69Q7zlCSQAfiLI1jI5nmcAH6lwcEUYsPsNgTb7W9 ginjFqWZchzpUsItj1rxInLib4pY2H/pa7epX08lNb08AyONIsLd+/0tWxI5+KJ44W 5jmlOya7Pp5OnwhRhLVeBP2nWXNHCdFwyBBcFx81LRguBnck+Eg6fOKqnLxiRaeebX SimeLd1Jq2SPqSOpIcgm4DPvtWILHC3XZLsy0lJaA3tT5ExeANHvGf1Ko0bKV7PAFr nBQ/YxJqyePN5VLVPDrb9+aTxWs2ooIQsJVFpGysDfw9vH8+5CVfSMLFapKR7Xw4sS RE8myk2/9PAHg== To: rafael@kernel.org, pavel@ucw.cz, len.brown@intel.com From: David Cohen Cc: David Cohen , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Reply-To: David Cohen Subject: [PATCH v2] PM: fix dynamic debug within pm_pr_debug() Message-ID: <20220312043624.40732-1-dacohen@pm.me> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Currently, pm_pr_debug() and pm_deferred_pr_debug() use __pm_pr_debug() to filter pm debug messages based on pm_debug_messages_on flag. According to __pm_pr_debug() implementation, pm_deferred_pr_debug() indirectly calls printk_deferred() within __pm_pr_debug() which doesn't support dynamic debug, but pm_pr_debug() indirectly calls pr_debug() which does support dynamic debug. The problem is if we enable/disable dynamic debug inside __pm_pr_debug() it will affect all pm_pr_debug() calls at once, so we can't individually control them. This patch changes __pm_pr_debug() implementation into macros to make pr_debug() to be directly called by all pm_pr_debug() cases. As a direct side effect all pm_pr_debug() can be individually controlled by dynamic debug feature. Signed-off-by: David Cohen --- include/linux/suspend.h | 19 +++++++++++++++---- kernel/power/main.c | 29 ----------------------------- 2 files changed, 15 insertions(+), 33 deletions(-) -- 2.35.1 diff --git a/include/linux/suspend.h b/include/linux/suspend.h index 300273ff40cc..d727d3c867e3 100644 --- a/include/linux/suspend.h +++ b/include/linux/suspend.h @@ -542,22 +542,33 @@ static inline void unlock_system_sleep(void) {} #ifdef CONFIG_PM_SLEEP_DEBUG extern bool pm_print_times_enabled; extern bool pm_debug_messages_on; -extern __printf(2, 3) void __pm_pr_dbg(bool defer, const char *fmt, ...); +#define __pm_pr_dbg(fmt, ...) \ + do { \ + if (pm_debug_messages_on) \ + pr_debug("PM: " fmt, ##__VA_ARGS__); \ + } while(0) +#define __pm_deferred_pr_dbg(fmt, ...) \ + do { \ + if (pm_debug_messages_on) \ + printk_deferred(KERN_DEBUG "PM: " fmt, ##__VA_ARGS__); \ + } while(0) #else #define pm_print_times_enabled (false) #define pm_debug_messages_on (false) #include -#define __pm_pr_dbg(defer, fmt, ...) \ +#define __pm_pr_dbg(fmt, ...) \ + no_printk(KERN_DEBUG fmt, ##__VA_ARGS__) +#define __pm_deferred_pr_dbg(fmt, ...) \ no_printk(KERN_DEBUG fmt, ##__VA_ARGS__) #endif #define pm_pr_dbg(fmt, ...) \ - __pm_pr_dbg(false, fmt, ##__VA_ARGS__) + __pm_pr_dbg(fmt, ##__VA_ARGS__) #define pm_deferred_pr_dbg(fmt, ...) \ - __pm_pr_dbg(true, fmt, ##__VA_ARGS__) + __pm_deferred_pr_dbg(fmt, ##__VA_ARGS__) #ifdef CONFIG_PM_AUTOSLEEP diff --git a/kernel/power/main.c b/kernel/power/main.c index 7e646079fbeb..5242bf2ee469 100644 --- a/kernel/power/main.c +++ b/kernel/power/main.c @@ -545,35 +545,6 @@ static int __init pm_debug_messages_setup(char *str) } __setup("pm_debug_messages", pm_debug_messages_setup); -/** - * __pm_pr_dbg - Print a suspend debug message to the kernel log. - * @defer: Whether or not to use printk_deferred() to print the message. - * @fmt: Message format. - * - * The message will be emitted if enabled through the pm_debug_messages - * sysfs attribute. - */ -void __pm_pr_dbg(bool defer, const char *fmt, ...) -{ - struct va_format vaf; - va_list args; - - if (!pm_debug_messages_on) - return; - - va_start(args, fmt); - - vaf.fmt = fmt; - vaf.va = &args; - - if (defer) - printk_deferred(KERN_DEBUG "PM: %pV", &vaf); - else - printk(KERN_DEBUG "PM: %pV", &vaf); - - va_end(args); -} - #else /* !CONFIG_PM_SLEEP_DEBUG */ static inline void pm_print_times_init(void) {} #endif /* CONFIG_PM_SLEEP_DEBUG */