| Message ID | 20220507125443.2766939-4-daniel.lezcano@linexp.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | thermal OF rework | expand |
On Sat, May 7, 2022 at 2:55 PM Daniel Lezcano <daniel.lezcano@linexp.org> wrote: > > The pr_err already tells it is an error, it is pointless to add the > 'Error:' string in the messages. Remove them. > > Cc: Alexandre Bailon <abailon@baylibre.com> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc; Eduardo Valentin <eduval@amazon.com> > Signed-off-by: Daniel Lezcano <daniel.lezcano@linexp.org> > --- > drivers/thermal/thermal_core.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c > index 1a405854748a..dc5a03d51f5c 100644 > --- a/drivers/thermal/thermal_core.c > +++ b/drivers/thermal/thermal_core.c > @@ -1197,23 +1197,23 @@ thermal_zone_device_register(const char *type, int trips, int mask, > struct thermal_governor *governor; > > if (!type || strlen(type) == 0) { > - pr_err("Error: No thermal zone type defined\n"); > + pr_err("No thermal zone type defined\n"); > return ERR_PTR(-EINVAL); > } > > if (type && strlen(type) >= THERMAL_NAME_LENGTH) { > - pr_err("Error: Thermal zone name (%s) too long, should be under %d chars\n", > + pr_err("Thermal zone name (%s) too long, should be under %d chars\n", > type, THERMAL_NAME_LENGTH); > return ERR_PTR(-EINVAL); > } > > if (trips > THERMAL_MAX_TRIPS || trips < 0 || mask >> trips) { > - pr_err("Error: Incorrect number of thermal trips\n"); > + pr_err("Incorrect number of thermal trips\n"); > return ERR_PTR(-EINVAL); > } > > if (!ops) { > - pr_err("Error: Thermal zone device ops not defined\n"); > + pr_err("Thermal zone device ops not defined\n"); > return ERR_PTR(-EINVAL); > } > > -- Do these need to be pr_err() messages at all? They all seem to be debug-type messages regarding thermal zone drivers.
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index 1a405854748a..dc5a03d51f5c 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -1197,23 +1197,23 @@ thermal_zone_device_register(const char *type, int trips, int mask, struct thermal_governor *governor; if (!type || strlen(type) == 0) { - pr_err("Error: No thermal zone type defined\n"); + pr_err("No thermal zone type defined\n"); return ERR_PTR(-EINVAL); } if (type && strlen(type) >= THERMAL_NAME_LENGTH) { - pr_err("Error: Thermal zone name (%s) too long, should be under %d chars\n", + pr_err("Thermal zone name (%s) too long, should be under %d chars\n", type, THERMAL_NAME_LENGTH); return ERR_PTR(-EINVAL); } if (trips > THERMAL_MAX_TRIPS || trips < 0 || mask >> trips) { - pr_err("Error: Incorrect number of thermal trips\n"); + pr_err("Incorrect number of thermal trips\n"); return ERR_PTR(-EINVAL); } if (!ops) { - pr_err("Error: Thermal zone device ops not defined\n"); + pr_err("Thermal zone device ops not defined\n"); return ERR_PTR(-EINVAL); }
The pr_err already tells it is an error, it is pointless to add the 'Error:' string in the messages. Remove them. Cc: Alexandre Bailon <abailon@baylibre.com> Cc: Kevin Hilman <khilman@baylibre.com> Cc; Eduardo Valentin <eduval@amazon.com> Signed-off-by: Daniel Lezcano <daniel.lezcano@linexp.org> --- drivers/thermal/thermal_core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)