diff mbox series

[18/32] power: supply: max77650-charger: Convert to platform remove callback returning void

Message ID 20230918133700.1254499-19-u.kleine-koenig@pengutronix.de
State Accepted
Commit cd25ac3e3200626680dac92c9784cce4d59fdc6b
Headers show
Series power: supply: Convert to platform remove callback returning void | expand

Commit Message

Uwe Kleine-König Sept. 18, 2023, 1:36 p.m. UTC
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
 drivers/power/supply/max77650-charger.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff mbox series


diff --git a/drivers/power/supply/max77650-charger.c b/drivers/power/supply/max77650-charger.c
index e8c25da40ab2..818e13c613e3 100644
--- a/drivers/power/supply/max77650-charger.c
+++ b/drivers/power/supply/max77650-charger.c
@@ -345,13 +345,11 @@  static int max77650_charger_probe(struct platform_device *pdev)
 	return max77650_charger_enable(chg);
-static int max77650_charger_remove(struct platform_device *pdev)
+static void max77650_charger_remove(struct platform_device *pdev)
 	struct max77650_charger_data *chg = platform_get_drvdata(pdev);
-	return 0;
 static const struct of_device_id max77650_charger_of_match[] = {
@@ -366,7 +364,7 @@  static struct platform_driver max77650_charger_driver = {
 		.of_match_table = max77650_charger_of_match,
 	.probe = max77650_charger_probe,
-	.remove = max77650_charger_remove,
+	.remove_new = max77650_charger_remove,