diff mbox series

[1/2] pmdomain: ti-sci: set the GENPD_FLAG_ACTIVE_WAKEUP flag for all PM domains

Message ID 20241008-8250-omap-no-console-suspend-v1-1-e7f0365c02f0@bootlin.com
State New
Headers show
Series [1/2] pmdomain: ti-sci: set the GENPD_FLAG_ACTIVE_WAKEUP flag for all PM domains | expand

Commit Message

Thomas Richard Oct. 8, 2024, 9:34 a.m. UTC
With this flag, if a device is marked on the wakeup path, the corresponding
PM domain is kept powered on.

Suggested-by: Théo Lebrun <theo.lebrun@bootlin.com>
Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
---
 drivers/pmdomain/ti/ti_sci_pm_domains.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Richard Oct. 10, 2024, 7:12 a.m. UTC | #1
On 10/9/24 15:17, Ulf Hansson wrote:
> On Tue, 8 Oct 2024 at 11:34, Thomas Richard <thomas.richard@bootlin.com> wrote:
>>
>> With this flag, if a device is marked on the wakeup path, the corresponding
>> PM domain is kept powered on.
> 
> Perhaps extend this with some more information that it fixes a problem
> for the uart console too?

Yes, I'll send a v2 (only the patch 1/2) with a more verbose commit message.

> 
>>
>> Suggested-by: Théo Lebrun <theo.lebrun@bootlin.com>
>> Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
> 
> Should we add a stable/fixes tag?

I guess no.
The first implementation, which was reverted, didn't have a stable/fixes
tag.

Regards,

Thomas
diff mbox series

Patch

diff --git a/drivers/pmdomain/ti/ti_sci_pm_domains.c b/drivers/pmdomain/ti/ti_sci_pm_domains.c
index 1510d5ddae3d..38448b4a035a 100644
--- a/drivers/pmdomain/ti/ti_sci_pm_domains.c
+++ b/drivers/pmdomain/ti/ti_sci_pm_domains.c
@@ -186,6 +186,7 @@  static int ti_sci_pm_domain_probe(struct platform_device *pdev)
 
 				pd->pd.power_off = ti_sci_pd_power_off;
 				pd->pd.power_on = ti_sci_pd_power_on;
+				pd->pd.flags |= GENPD_FLAG_ACTIVE_WAKEUP;
 				pd->idx = args.args[0];
 				pd->parent = pd_provider;