[RFC,10/22] KVM: x86: Make APERFMPERF a governed feature

Message ID	20241121185315.3416855-11-mizhang@google.com
State	New
Headers	show Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B7031DFE3F for <linux-pm@vger.kernel.org>; Thu, 21 Nov 2024 18:53:35 +0000 (UTC) Reply-To: Mingwei Zhang <mizhang@google.com> Date: Thu, 21 Nov 2024 18:53:02 +0000 In-Reply-To: <20241121185315.3416855-1-mizhang@google.com> Precedence: bulk Mime-Version: 1.0 References: <20241121185315.3416855-1-mizhang@google.com> Message-ID: <20241121185315.3416855-11-mizhang@google.com> Subject: [RFC PATCH 10/22] KVM: x86: Make APERFMPERF a governed feature From: Mingwei Zhang <mizhang@google.com> To: Sean Christopherson <seanjc@google.com>, Paolo Bonzini <pbonzini@redhat.com>, Huang Rui <ray.huang@amd.com>, "Gautham R. Shenoy" <gautham.shenoy@amd.com>, Mario Limonciello <mario.limonciello@amd.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>, Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>, Len Brown <lenb@kernel.org> Cc: "H. Peter Anvin" <hpa@zytor.com>, Perry Yuan <perry.yuan@amd.com>, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Jim Mattson <jmattson@google.com>, Mingwei Zhang <mizhang@google.com> Content-Type: text/plain; charset="UTF-8"
Series	KVM: x86: Virtualize IA32_APERF and IA32_MPERF MSRs \| expand [RFC,00/22] KVM: x86: Virtualize IA32_APERF and IA32_MPERF MSRs [RFC,01/22] x86/aperfmperf: Introduce get_host_[am]perf() [RFC,02/22] x86/aperfmperf: Introduce set_guest_[am]perf() [RFC,03/22] x86/aperfmperf: Introduce restore_host_[am]perf() [RFC,04/22] x86/msr: Adjust remote reads of IA32_[AM]PERF by the per-cpu host offset [RFC,05/22] KVM: x86: Introduce kvm_vcpu_make_runnable() [RFC,06/22] KVM: x86: INIT may transition from HALTED to RUNNABLE [RFC,07/22] KVM: nSVM: Nested #VMEXIT may transition from HALTED to RUNNABLE [RFC,08/22] KVM: nVMX: Nested VM-exit may transition from HALTED to RUNNABLE [RFC,09/22] KVM: x86: Introduce KVM_X86_FEATURE_APERFMPERF [RFC,10/22] KVM: x86: Make APERFMPERF a governed feature [RFC,11/22] KVM: x86: Initialize guest [am]perf at vcpu power-on [RFC,12/22] KVM: x86: Load guest [am]perf into hardware MSRs at vcpu_load() [RFC,13/22] KVM: x86: Load guest [am]perf when leaving halt state [RFC,14/22] KVM: x86: Introduce kvm_user_return_notifier_register() [RFC,15/22] KVM: x86: Restore host IA32_[AM]PERF on userspace return [RFC,16/22] KVM: x86: Save guest [am]perf checkpoint on HLT [RFC,17/22] KVM: x86: Save guest [am]perf checkpoint on vcpu_put() [RFC,18/22] KVM: x86: Update aperfmperf on host-initiated MP_STATE transitions [RFC,19/22] KVM: x86: Allow host and guest access to IA32_[AM]PERF [RFC,20/22] KVM: VMX: Pass through guest reads of IA32_[AM]PERF [RFC,21/22] KVM: SVM: Pass through guest reads of IA32_[AM]PERF [RFC,22/22] KVM: x86: Enable guest usage of X86_FEATURE_APERFMPERF

Message ID

20241121185315.3416855-11-mizhang@google.com

State

New

Headers

Reply-To: Mingwei Zhang <mizhang@google.com>
Date: Thu, 21 Nov 2024 18:53:02 +0000
In-Reply-To: <20241121185315.3416855-1-mizhang@google.com>
Precedence: bulk
Mime-Version: 1.0
References: <20241121185315.3416855-1-mizhang@google.com>
Message-ID: <20241121185315.3416855-11-mizhang@google.com>
Subject: [RFC PATCH 10/22] KVM: x86: Make APERFMPERF a governed feature
From: Mingwei Zhang <mizhang@google.com>
To: Sean Christopherson <seanjc@google.com>,
 Paolo Bonzini <pbonzini@redhat.com>,
	Huang Rui <ray.huang@amd.com>, "Gautham R. Shenoy" <gautham.shenoy@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
 "Rafael J. Wysocki" <rafael@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
 Len Brown <lenb@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Perry Yuan <perry.yuan@amd.com>,
 kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	Jim Mattson <jmattson@google.com>, Mingwei Zhang <mizhang@google.com>
Content-Type: text/plain; charset="UTF-8"

Series

KVM: x86: Virtualize IA32_APERF and IA32_MPERF MSRs | expand

Commit Message

Mingwei Zhang Nov. 21, 2024, 6:53 p.m. UTC

From: Jim Mattson <jmattson@google.com>

KVM must verify both host support and guest CPUID enumeration before
enabling guest access to APERFMPERF.

This verification is deferred until the implementation of guest
APERFMPERF is complete.

This declaration enables "guest_can_use(vcpu,
X86_FEATURE_APERFMPERF)". Otherwise, that expression results in a
compile-time error.

Signed-off-by: Jim Mattson <jmattson@google.com>
Reviewed-by: Mingwei Zhang <mizhang@google.com>
Signed-off-by: Mingwei Zhang <mizhang@google.com>
---
 arch/x86/kvm/governed_features.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/kvm/governed_features.h b/arch/x86/kvm/governed_features.h
index ad463b1ed4e4a..fa77d655d2355 100644
--- a/arch/x86/kvm/governed_features.h
+++ b/arch/x86/kvm/governed_features.h
@@ -17,6 +17,7 @@  KVM_GOVERNED_X86_FEATURE(PFTHRESHOLD)
 KVM_GOVERNED_X86_FEATURE(VGIF)
 KVM_GOVERNED_X86_FEATURE(VNMI)
 KVM_GOVERNED_X86_FEATURE(LAM)
+KVM_GOVERNED_X86_FEATURE(APERFMPERF)
 
 #undef KVM_GOVERNED_X86_FEATURE
 #undef KVM_GOVERNED_FEATURE

[RFC,10/22] KVM: x86: Make APERFMPERF a governed feature

Commit Message

Patch