| Message ID | 20241213013051.11095-3-shimrrashai@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: Add Firefly ITX-3588J Board | expand |
On 13/12/2024 02:30, Shimrra Shai wrote: > Signed-off-by: Shimrra Shai <shimrrashai@gmail.com> > --- Explain why this is draft, what does it even mean. Do you expect any review or not? Please run scripts/checkpatch.pl and fix reported warnings. Then please run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index 753199a12..9ee96acdc 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -190,6 +190,11 @@ properties: - const: firefly,firefly-rk3399 - const: rockchip,rk3399 + - description: Firefly ITX-3588J + items: + - const: firefly,itx-3588j + - const: rockchip,rk3588 + - description: Firefly ROC-RK3308-CC items: - const: firefly,roc-rk3308-cc
Signed-off-by: Shimrra Shai <shimrrashai@gmail.com> --- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)