From patchwork Sat Feb 15 00:52:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 865457 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F428156C7B; Sat, 15 Feb 2025 00:53:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739580781; cv=none; b=JAOE5qGsNobhY3di0LjMOWec1S0X98OI/ir7DDgTEvW8yo9tfZK4RwOwGGelZJcPGyCti7igDHoglXTC0SdNKJ7mInRAEIULDG5C0qLEhYJloJ3lR4CHlkXLxz+e2Mi2U+Lj2RzZs7kYapQRJxQjklojqk8V2YlxB6ckw0Rwev8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739580781; c=relaxed/simple; bh=Nl9jZl9M/WSE1cA0Dz+sYCnF1EoJjkOcHvDt7rY8vnY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BiBkoSMXh2nBbKSoRZZlqydS8UzVfiM38Ck/QjZZzy5pimHHBxx0Jl7aloa/pnpO05kqqQ7zLx+FutGjIYmcTY8IugACSLN+ACZc7jeIOGINRDwtIDcYhcHVBBqSMLqM4yG3bjc5OQi0S+vVUgvc6zkWO5ACjtusNFAQ1tCzpFY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oxEM/oWi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oxEM/oWi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DBEDC4CEE9; Sat, 15 Feb 2025 00:53:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739580781; bh=Nl9jZl9M/WSE1cA0Dz+sYCnF1EoJjkOcHvDt7rY8vnY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oxEM/oWiYiES4gPiDboBdxbzvlSTY53Bo9f1YXL4JJjIn06r2fGY5yMwW7pgRtIL4 re8kQCld7LMqCLVe0KBwiXWe/ZaNP8mqkDbz6Kv4lTQ7ngiIG3NuZT1QlRHAIOnnjK qGvxKLYD3YoaPW8IczM35Ro9HT/a+ER8u53AA/Au5Pg3cx/GpukejDktC7FqKYtjRH rD6byH1BVrlVP/6OX7EwNBqVHlGxq8LTxgAAYlO7E+kQLLdjis7hyBtil5yxoVzx1s Uuq22foNMDaJoCG7EhjBmO6YXZtNW/hvj+2bI9wJPGI9XAP4tqdU0TXFuChCgh99ki HeXSjb4XSGutw== From: Mario Limonciello To: "Gautham R . Shenoy" , Perry Yuan Cc: Dhananjay Ugwekar , linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)), linux-pm@vger.kernel.org (open list:CPU FREQUENCY SCALING FRAMEWORK), Mario Limonciello , Dhananjay Ugwekar Subject: [PATCH v2 05/17] cpufreq/amd-pstate: Drop `cppc_cap1_cached` Date: Fri, 14 Feb 2025 18:52:32 -0600 Message-ID: <20250215005244.1212285-6-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250215005244.1212285-1-superm1@kernel.org> References: <20250215005244.1212285-1-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Mario Limonciello The `cppc_cap1_cached` variable isn't used at all, there is no need to read it at initialization for each CPU. Reviewed-by: Dhananjay Ugwekar Signed-off-by: Mario Limonciello Reviewed-by: Gautham R. Shenoy --- drivers/cpufreq/amd-pstate.c | 5 ----- drivers/cpufreq/amd-pstate.h | 2 -- 2 files changed, 7 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 044091806f14f..e5983e5c77ba2 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1510,11 +1510,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) if (ret) return ret; WRITE_ONCE(cpudata->cppc_req_cached, value); - - ret = rdmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_CAP1, &value); - if (ret) - return ret; - WRITE_ONCE(cpudata->cppc_cap1_cached, value); } ret = amd_pstate_set_epp(cpudata, cpudata->epp_default); if (ret) diff --git a/drivers/cpufreq/amd-pstate.h b/drivers/cpufreq/amd-pstate.h index 8421c83c07919..1a52582dbac9d 100644 --- a/drivers/cpufreq/amd-pstate.h +++ b/drivers/cpufreq/amd-pstate.h @@ -74,7 +74,6 @@ struct amd_aperf_mperf { * AMD P-State driver supports preferred core featue. * @epp_cached: Cached CPPC energy-performance preference value * @policy: Cpufreq policy value - * @cppc_cap1_cached Cached MSR_AMD_CPPC_CAP1 register value * * The amd_cpudata is key private data for each CPU thread in AMD P-State, and * represents all the attributes and goals that AMD P-State requests at runtime. @@ -103,7 +102,6 @@ struct amd_cpudata { /* EPP feature related attributes*/ u8 epp_cached; u32 policy; - u64 cppc_cap1_cached; bool suspended; u8 epp_default; };