From patchwork Wed Jun 11 07:52:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 896182 Received: from AS8PR03CU001.outbound.protection.outlook.com (mail-westeuropeazon11012058.outbound.protection.outlook.com [52.101.71.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2164238144; Wed, 11 Jun 2025 07:54:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.71.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749628478; cv=fail; b=h+Ok7zEo22XhK5DKA3Gw6f8vc7+uZSNPSrrO7ZXglP5kN0oUjNys8x2Ody0Jnu/xk1/sftlUl0APbeKq3oBMGYM+FyjLZUu1EeFZqH941mznurwPdvmX3FF3Ggfsc1OMJqlYThwG8fqXLbnsgKwkQqDUWBqLfXWiMWQNa/ddSro= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749628478; c=relaxed/simple; bh=ldhQUzKL1K8CWVN+YNscRImer5utthg6GiFfwHcmPaE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=iEA9hmrPz+p0DPoanV77q5yltqqLtA/8bUN0lNRgLch48aO+OkSkmhG06JBEdw6ACTf0MUUjf9Cjxcbn84B4Hj2ufZturR5E/yuc5ik2ZX7XJn3SI/OqUyGPJpKxTIH1OUa/8V3h9+leGKNQMGLl1xz1C13PcfoHHdaKuwbiHpA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=qCWOtKVR; arc=fail smtp.client-ip=52.101.71.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="qCWOtKVR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F1Z61NYP1DHzm56EpwpqxLi4qAMEEhJ3fOBoSNubTPUq6yD7Dn8kdabj5X8f5VcFWnoUquS1259DevJEmgK/PEDFJN5AQFFP/wcfTiQmmI4H8+wbbK0/gLLL/iLyIwax8FtOTq6Qo2sgZTy5Vq+rrkt7DyxHFhwxoNVmqwb1iTiJtUZNt1LYSWRjV7uABeDqDlX83uXtP72fOlbv91r74HUjr5EwAUvK2B6SwxauK0tHdXVzC7qYmOIMalR3ztLOa8ULdu5AWRO9XMtXsSTKnHbsDYMFtGnf5H0XD49mei6KhsOePJVB34rvqsfcY3C+zAASPMyEqLttrEZDfWJU/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bOL8wmKpAgw8ZVXa4lFBGUS0w4cwiRMAsMBXTbbruWA=; b=NezdRTdJYB73Mv4rr/OyDgT3EQb/oJWOzL9W5fXlNAAYy5Pds5PZhIMOPhUMjXoES3ua+6uaGD3OWn5ALuKaJ/3dGb5imIeG+fwBY0RmnLvw49uG5VequlObG1tVWh80ED80SFvxOpeR96CMGDmWVQ5R6d4HCSM9jdXlWGi/5v4L2/pFSkJXwazX/ekQ6ip/sus8rN09YjB+8q3TamgWSUmJBMyXKJIudFIkNzzu4LiXTZ7cey35+CPHVklusrKiaZ5GTnKjpxFMGTipLKpO/nqViChfwOcMQF94UT232tqpDAumaST2K4u7+3NSGVbqunI9POLS+Ug14j6UnxMEdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bOL8wmKpAgw8ZVXa4lFBGUS0w4cwiRMAsMBXTbbruWA=; b=qCWOtKVRICbdpQqK38B1r98BiF9hPmF45uHYopkYNsbqP5pf3nKkCafBACZm7h+sFzDS6ZcH4bCtbCq+g/ZYrazR6uIfdsHes+m0HN7y8hG2ELgVAETHvW5A6+3+Sc15hSLmH7rG2hW/joKYjtalyBrmlZwu5V8l+z2xfjjhxCJ9IyUZ23RoCgm+s/JMaZs6A8Z9LePA6SGxyCMADzFfNTiPUrR/luUiP4epfYsfmA8LIw2rkIXKjbBsOEzVdndzX378q+pXDGJRV+qAHiPrUDhIKsbypvBWFDwnucn6xrXLGFWoe3KIC6V0prJTCCl5ox618cEKt7D46Sza7WjaCw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB9PR04MB8346.eurprd04.prod.outlook.com (2603:10a6:10:24d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.18; Wed, 11 Jun 2025 07:54:34 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8813.024; Wed, 11 Jun 2025 07:54:34 +0000 From: "Peng Fan (OSS)" Date: Wed, 11 Jun 2025 15:52:45 +0800 Subject: [PATCH 3/3] cpufreq: scmi-cpufreq: Enable perf limits notification only supported Message-Id: <20250611-scmi-perf-v1-3-df2b548ba77c@nxp.com> References: <20250611-scmi-perf-v1-0-df2b548ba77c@nxp.com> In-Reply-To: <20250611-scmi-perf-v1-0-df2b548ba77c@nxp.com> To: Sudeep Holla , Cristian Marussi , "Rafael J. Wysocki" , Viresh Kumar Cc: arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749628374; l=2509; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=MGDElYttVmCn6iSeKiaCycZJIb/by6vQcfrvx8hUUVM=; b=trLWyOJ8m5F65HntAaDiEl8gvM0dtLAPevaxmHn/KSJ9+ib+HkgtJEM6TAMKmSpk8HZVQyDw/ oM34EWByGMsCdxlNQyDaUwcgJNjLb++MARE2w6dqcgOkuhbJ4pIIz7b X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR04CA0209.apcprd04.prod.outlook.com (2603:1096:4:187::12) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB9PR04MB8346:EE_ X-MS-Office365-Filtering-Correlation-Id: e64f8955-1f28-45f8-be06-08dda8bd3492 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?ahLcL8swKhDT/006AkpaOLWirTu98zm?= =?utf-8?q?hiv47vs8/0d41DFXl97yE+i4sw3b1bHy4lBqniGE7ASPEmJ1EE5/xtdWw7SJbzI+F?= =?utf-8?q?Yfn7+fRNl7CCrX8vBn0jI4QoNP+wZOshZDiOue/bXklR5KSTVITztonga5b7FtuKN?= =?utf-8?q?KtqRHbrl4X4FzCO1ORSHBcqfO+dZEfbm5/njFi+64EHY1hALc7h1Qb0cV+DxLQNmv?= =?utf-8?q?EQ8M0gjvPTHQ0mz69zIgfVPESovqWSAwr4ifjz/j9m6/mCpWXZw6i1NFrSLALL0jY?= =?utf-8?q?O4hkgmQmvS0bPZYlazVCQs0e0QxuZ6cmQeObBMhEz9eR6uF9b4la1027NA5KzACmd?= =?utf-8?q?92k1Wb2xy1TakzT4+KjgDH20mkP/B3MVTnNCveBa66KbVQmAEIYFZXOAsDrmbdQWt?= =?utf-8?q?RsIFjY5N4pbbHRsyIZAyqLUWl2OssJrUh0nShsvecvrWRIs3iOo+qJz4jkBAkty0j?= =?utf-8?q?j0xJ9V2tTujN6O/4UtdkPJqlEbS4e4hrDoRFJ/k06qGvr+ZraFPrefxpjS69nhbIK?= =?utf-8?q?/a+OqhB7Wk8NyP5yJl8h83qVyGRxLzE5kuJuTllM8H94rXeKbEOxtdKaV+B2HzKg2?= =?utf-8?q?zLGlVJxL7hEfeRvgC8sWY3chvuyapKHCFLAGLWmilnoBbNkrJ3sEfV270Gak4Mb+J?= =?utf-8?q?dGO/TEcwtkSyjQpGqC6MXSxdkz30otk+zQXHSDjMNfAOAb610lbzEXFePcGSKGzLh?= =?utf-8?q?byzMHKAqYCcsYZHIMWsj4PsTi+PLOnd1+sjK+lyCTxDyaJ17ZgbkSDHstsQZjg206?= =?utf-8?q?FOPgwEXdfugUAbqAELnpvbsGIqp04LHae/zM/A2eScanIE7gQ/1W3vzNyXHEyNlYa?= =?utf-8?q?Nv/SlHIH6XMtqaTuyQzv4JxfmNDuovujDQdczB/7q+lXubwTwkIXUJ1YKLW1UfJho?= =?utf-8?q?ugVnlbWSPgcaqaN4qMFqZ2Pr9cRlVVrTvh5Jq3eJSvHTcac5rEPZsrtNIagNWYghh?= =?utf-8?q?+aQyUsxskgpwHCyBLQq/X5ApgVL7ChlMM3Iwbqh2rjxrzKiHLl4ItMM45R3TGFq2H?= =?utf-8?q?qrRRbtFRGzF3xYv2w1RN4Y7eoZ3YP8NNVlVILgdqxTJOwXgKwYyQTKNjhqJiso++i?= =?utf-8?q?k0cOABED74Lr0NpHJam9hqcuhhv00LUGOChssHI1qWqVyCTxPy6DIfihAp1cnf2JY?= =?utf-8?q?frc6sfUh0ydanBqb7oH0tU6SrlFnPuUNBuPFDjgKJXxdCGZON+fZhHzccBszdWG0X?= =?utf-8?q?iY3oSMWBpZv+jGP5R4XyaAGWGI6jDc9O6hXT1iJKoS7cysUW7SMU7N2wSRGBU/9n3?= =?utf-8?q?w3QfdxOWlVSOPfTnBgXb+sEWwTvwXo/49pqJ5fnvUETSPRBsqjOEHYeKL6kv/vkjs?= =?utf-8?q?ag8AUYHH1hIec2Jc2betfpp/CYze7nuVD6HOts0dHYfM+/j0WzRPMjd60vrJZCUEM?= =?utf-8?q?0KEo3WhkUTqtJHikBLYH2xHBZpvbCwGkw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8459.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?XYsNWblnroczqm6DdZhHVMN2Adba?= =?utf-8?q?is1/WppYUI3+vAOc4vV6mUxd4E7dx6+rK+h2zWJlbzN73DyKOPgPl/sMOogMGgFSm?= =?utf-8?q?2U/15Qk91moXfoa0RtomjMNX2M+2dJM1dWxVn+4SIBvJRmxeGi1wO30KPNIAWAXVH?= =?utf-8?q?ZYnE04LvzhF2tVNnMCC40Xww6QtSmUQ9RZtBSUTewMW/EtEU2iHrJ1YXynJC0tJIK?= =?utf-8?q?/r8cbVmmHMhwJX6UlEpq/Qh/6lmGQnMuKB9+sX4Fki3N0vqmX/y8W0jwrQ48F0T9D?= =?utf-8?q?lam93F9qQvFrI3YGZVf5m3RSqRHe+eHSFFC6gWB1z5O/9jHKoUgEyelZalaQba4ea?= =?utf-8?q?BkgFz9C/EQ+KURfdgcBjlqcyfttQgn1FAjp5U6s2CXoKi/2MtlOAyqaDRcmutzJaM?= =?utf-8?q?DZqRRRtiy+gPHdIEvG0mHz8LtykLj4pdwC5voxCLi4hgsOEfapKKC5oUgCU3VQaFV?= =?utf-8?q?1c7pdbVBGhJy5cR5/VS78rWaMPRYvUvaOoXzFWWkjLgL2+CcWWLKPgqSzubC3xpS+?= =?utf-8?q?wVsTyk1Wd+JwJkAFPYcHWB2jBX35F9Rc1CXgGhLuMs488lNCv6x4s/UosRUJTB9LB?= =?utf-8?q?5hGuYsyUpWkShy80m6i/U2rfmfD67XMklAy5mPWhByvWpHdAOGPhcNF2XvnOcNUpP?= =?utf-8?q?VNqp7Kqp70UoDe6tK0UShQiL4KNB0s+aEIt7PFKNZ2EgYvm7AayOKV5N8RGZgy45A?= =?utf-8?q?6KrvCQeMvWXhQz3Jlfs5TwopGyWkIochKyz3SNAoIKDFWNjVT96M1J3mZA8O4AmKG?= =?utf-8?q?2qX+e5PS6xjC7A6Y7V9RyaYHwGYbEByTmLhcUShOh8efd86fSZvLGIqkqbXrx+JvF?= =?utf-8?q?47/TnzSi/4A0cPHWa5Ln2fOGvhBXiJFfBtRdoxC1bnxIwR4Yg3Vcq1/PjkCPK8RzU?= =?utf-8?q?B8Cb3tgsulyqddniFL87QYAd0W969AQqHY97uC0qdCttALF68pnlM2XHtxGZmGKbN?= =?utf-8?q?x4km4UOOjU9UTpABfzYlF3jlwiMRdT1YD8G6l5JAMwO3zs7ZO1RxuiqSsueP9lmQ5?= =?utf-8?q?3K4zVYf9o0pijEuZUJkpesyovwRLj2w9kAG39oJzV+phTmFsWirjjlOwMLPeEA4QD?= =?utf-8?q?pzOh/1eQPb326kilgyvSXga45aPNa64E0cyRT0Lm9fEwY3YJocNVManF4BNz7IRR8?= =?utf-8?q?KCOtyPx4Rtwn6JQnAiURPFWYw5UKCuJ4Ees98u5Df7XOIj7nt0uHJ0kuf7Nq3PG9W?= =?utf-8?q?xh0uPV5ynzzOJqN2qI1o9313yUPqdJhrx4C8/jtwLZz6vW3X1OhJRiTABXT7H6ds2?= =?utf-8?q?TtOZ5W4EBrzT9VM654MviN+LPxIaQs/Hc8PW8kXwhmr9KiCyXYDg7J5yR8DtZ1ibp?= =?utf-8?q?yXwnMJOQwi7ZpT6T90hivoZ5hYl0Bydjcl1Z4PgKRrF+SNOCIhlEc3EQM3VkbmyPg?= =?utf-8?q?DF/KTNQxw9A7YOGulw5DJfKo8hIEVa3ZM0kMoANHdIMhppP9smyFvydWS56avube/?= =?utf-8?q?RbMGmxHBfvzXJq+O1QkF2jap7qD9C+RDaDif1w8l05wnof7oFm/jtS2wyL1XgY39t?= =?utf-8?q?7AgYHQJFo668?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e64f8955-1f28-45f8-be06-08dda8bd3492 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2025 07:54:34.3917 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gr+15EApG50bkAv814xfdG1IBGk2qHcGatP9dfjvoE5Wqbuf70cfOshx/Kt5ayu0dz8HrbluuBNAi0ivKe9Hhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8346 From: Peng Fan PERFORMANCE_NOTIFY_LIMITS is optional, so enable perf limits notification event only when the platform supports it. Signed-off-by: Peng Fan --- drivers/cpufreq/scmi-cpufreq.c | 25 ++++++++++++++++++------- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index ef078426bfd51af6a8a4b803278dfae5d323db48..8999960574a2fc427e934553198584d2aeb14a58 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -29,6 +29,7 @@ struct scmi_data { cpumask_var_t opp_shared_cpus; struct notifier_block limit_notify_nb; struct freq_qos_request limits_freq_req; + bool perf_limit_notify; }; static struct scmi_protocol_handle *ph; @@ -310,15 +311,22 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy) goto out_free_table; } - priv->limit_notify_nb.notifier_call = scmi_limit_notify_cb; - ret = sdev->handle->notify_ops->event_notifier_register(sdev->handle, SCMI_PROTOCOL_PERF, + priv->perf_limit_notify = + perf_ops->notify_supported(ph, SCMI_EVENT_PERFORMANCE_LIMITS_CHANGED, + priv->domain_id); + + if (priv->perf_limit_notify) { + priv->limit_notify_nb.notifier_call = scmi_limit_notify_cb; + ret = sdev->handle->notify_ops->event_notifier_register(sdev->handle, + SCMI_PROTOCOL_PERF, SCMI_EVENT_PERFORMANCE_LIMITS_CHANGED, &priv->domain_id, &priv->limit_notify_nb); - if (ret) - dev_warn(&sdev->dev, - "failed to register for limits change notifier for domain %d\n", - priv->domain_id); + if (ret) + dev_warn(&sdev->dev, + "failed to register for limits change notifier for domain %d\n", + priv->domain_id); + } return 0; @@ -341,10 +349,13 @@ static void scmi_cpufreq_exit(struct cpufreq_policy *policy) struct scmi_data *priv = policy->driver_data; struct scmi_device *sdev = cpufreq_get_driver_data(); - sdev->handle->notify_ops->event_notifier_unregister(sdev->handle, SCMI_PROTOCOL_PERF, + if (priv->perf_limit_notify) { + sdev->handle->notify_ops->event_notifier_unregister(sdev->handle, + SCMI_PROTOCOL_PERF, SCMI_EVENT_PERFORMANCE_LIMITS_CHANGED, &priv->domain_id, &priv->limit_notify_nb); + } freq_qos_remove_request(&priv->limits_freq_req); dev_pm_opp_free_cpufreq_table(priv->cpu_dev, &policy->freq_table); dev_pm_opp_remove_all_dynamic(priv->cpu_dev);