From patchwork Mon Jun 23 12:43:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pan Chuang X-Patchwork-Id: 899629 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013010.outbound.protection.outlook.com [52.101.127.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD8B324888D; Mon, 23 Jun 2025 12:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.10 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682626; cv=fail; b=lBPsW5uQpCSjc9ElkqVVEXzeLiuzOaU/KP/5oOzaeoZp2hc/+/8zIwW20/Br4+99APG4o6Y9X7kjzPuBJdu1LD2xteiKoLVwgCXb1O0UVHf5hnLgoPm+kRM7nBph1nQ4jo9+la2q/vpk2b81tMMrf+7Ci3iMJN13A/IEEtVSraY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682626; c=relaxed/simple; bh=qv72uYWMjNnjUaDROC60KRs9nT8l2gVgXpP/GOyR0iQ=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=TXqJshaxKAozOhgauiQVhDzjy4TqHT5H+8ZyijEsDvZgQut55d3CtqD6+5K9y1mCaRNpvWXl2k+n9S5PR2iyLiSVoSQzAiS+TG0J5rZCWAU+KyXKAXMYUaDydV7vu4/Q7QzEiBPcPVWKNKwwJ/mW6Ffon959p4P13NA0QpA8mMw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=FjYVJoUA; arc=fail smtp.client-ip=52.101.127.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="FjYVJoUA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ABc17AJJ00v2WsCqV3rPo1eLpO+Hx2vZFXNgncIGfpkm6RsC5h+Thu98dAbDG9sD78fMjuhxUEEA2T/iCC2dMhcAsyTDTdjHHZL3HHJtz+Z+4tQqaIOK0b8JdOBHGgZCx8OPHoMokcxiNAF0/6utDzuavlozu0Rl6aQCqcWB6X0sutJA7ogSSLuq9W1mUsgWWWg3ey/QD9xdaG5yeHgr6noS2pPWM7odCI+H1yz6aD6eWhBTPUjUC6H9x8PM/1N8bbDmhkAPWMNEmvYd+Pd/GczUq/tLoFSi4C4UiXWv9N8GYEXMHZFg6xjAI5Ki9/jzJzX1dN483BH97B03OTOsJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m55j4/lBNEAJFpgAHXZuEtDyuLAH4bvJbs0juv3TjVc=; b=FnyYJ7TJl2css9CBA5M77HaWpCFXd7CpWYELY3RdIKAiSS3t+A0MdIv9Krt/gFik8ydX6pBlp6+rsuOmzdkx6Zn8w1Kj5H5wJpV76s2jQi+P86Cx6SFpHw1haXZiUPkdwryyEywMeXjSmK3WiB6FxCDEEzV/+WeGjsM0ahQstX8MoIE4nOk9sxxbUxqS73sE3xltQR/9ny5AR2wb9+Kp0WiH9LX6Hg3ze9w1GNJAdl9yERDUjXdwyvTMuVmifhmjeVk9kKwmCI94akQ1OSM8Z+cxKe6VHLSApFc5LjqnJfGiMkPPYzQ34+X08+qkEZsx/3l4h0m9IMKf0wqZMQMuFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m55j4/lBNEAJFpgAHXZuEtDyuLAH4bvJbs0juv3TjVc=; b=FjYVJoUAg3EUwnxbd7nkN2YwBFEDzLMieoCvopBWI2PVAjY6LK7c8Vql1r+lx7wB9kyoRDprY2jrF39p43+aLuPqlkJv8kEtF8yysVgpykGAU7OeEYq0wDNzordyWyj9itTg3OOU6bd3dRXi22AsHwMz0j4Xw3NwEht5xsuLLOUIwiJ9wOsDkMTZ1qF4KHl50tsFQUgGInmBPHWy2rWQTnML8Bw2n+y89hFQ8YkS59Xqr5MejnjsV5YCTPC8mW6pXqrjFL3hC+0JBgS3SkHOx7+9XGHfz7HK7uQwlQMXjG74dPtqkW8InqEy8XpwRTTqSsParq46/KtW6r18L+pINg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) by SEZPR06MB6611.apcprd06.prod.outlook.com (2603:1096:101:18a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Mon, 23 Jun 2025 12:43:42 +0000 Received: from OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49]) by OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49%3]) with mapi id 15.20.8857.026; Mon, 23 Jun 2025 12:43:42 +0000 From: Pan Chuang To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: frank.li@vivo.com, Pan Chuang , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno Subject: [PATCH v6 24/24] thermal/drivers/airoha: convert to use devm_request*_irq_probe() Date: Mon, 23 Jun 2025 20:43:29 +0800 Message-Id: <20250623124329.475147-1-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SI2PR02CA0048.apcprd02.prod.outlook.com (2603:1096:4:196::23) To OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS8PR06MB7663:EE_|SEZPR06MB6611:EE_ X-MS-Office365-Filtering-Correlation-Id: 04b2f066-59a7-433e-11f9-08ddb25395bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|366016|7416014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?JlxOR3FGtr2Vj7E+50xTxrY8fpYmoGm?= =?utf-8?q?2Ykt5Hb5FNtDnmks039oRO5rK2E7pk/P3+CJFowz4V0l8VUJV7F5wqd4FrCnukCgE?= =?utf-8?q?0SDtYEfnfxmsYoCXKXtTW1h3eHdAdLApQId476/W9ZIcRubNyIF6RepF6HuPCyVcw?= =?utf-8?q?ONYs6Z/gUUKdCROANIHjALYbpBzUrO5pHWwOn1nVZBAaGVgACcAKWCB8dj3WvtjIZ?= =?utf-8?q?5kGNmAukhHRMJEd4EZEO8W8eaGA9lILWQ2NNrP/VLR9+52kfPvhbTgvcolicdcGEV?= =?utf-8?q?Fq9IDiVdPvnmQVFASGhtEkIbJcAbj9glCrBcZOx0Yk2mYkUrAES26c3og5k4KASRt?= =?utf-8?q?VJBeaop70PvitdUOoS2M2N9qciz+m3ipvB5Qzuy3QGCh0DE7sH+T1dw6B8ZNochsK?= =?utf-8?q?/7EYhz98cy1WKUruyDpCpySW3u5bsUuEFoeMyRfwVmWj2YHI6ARnKVwMJ+SLmtiqJ?= =?utf-8?q?HR7xNTHA7NAhBCHsvqAPM3Lg3tZlRY6cbC1rbe6ydiGVy8lTbq+q/sGJH4HNygz7E?= =?utf-8?q?QA7sZ+2T1r77WZj1dJdEqZop6iMs/CBmOQ1/GvmLOmwHyzjYqmgmT6g/hlXRqhfo3?= =?utf-8?q?C9MytX6Tr0XWLEmmsYh5BCr8ZWzZn8SXJjiG2UuFOXp7UVOqCSQnaanXE7T1uuI+W?= =?utf-8?q?NuY7GhEBqzI4Vr5P0ADktmqbp2wuPMyZMh15TMHFEcTridzmowAHc56kPkWxyNezf?= =?utf-8?q?iJ5FX0kgnYRL+MU6TG63XwJxy7VM7DfDCelXAuk3QBIDCvi9tqVl+a/fVa/9sDEOR?= =?utf-8?q?PMn/6iCeU69r6UMEK8E6M8zIubrOp/Uxmb6ql4wfws3x9Bee27g+fxtPHOrYKUlp2?= =?utf-8?q?Ws0W+ilZkowxxyjcPq/DXrFfmxFdWQQwZxl48+t2NYjhaQHBoeTIX/T6UL4ugLQj4?= =?utf-8?q?0uzCamj8+jhvxSsvLn6IZ8kn2yuPMDimiYe9tt5rdz3vkhRL9/3pFbIy5hYT8SmN5?= =?utf-8?q?EXPkykwm4e4YNo21rSG/Y5bR1v4cu+3kpsZ4wnsMzXYdXq66LL7hECa+TlJUyFgpk?= =?utf-8?q?C4UYlMWR7rLe+yzFcRgNuqN7C6dn4KeN/3fXs/woG8yDGwgshFsMK5YAMX3F46zvw?= =?utf-8?q?xmEbG9f5eO/JO7+C6mUO5SDwVR+1tf5oirScnChWTiK/8MR9pngtIhvQlSdDV/BMy?= =?utf-8?q?mwKI9yVXTEfsPhKjzwU/zLDAYROxenXRa6CtGFHCgofVl18G2v4P5GB2VmJASF2So?= =?utf-8?q?gZHiMrS6PLbvMbv/ldU8c+nQZPsFZke0ryKg7G9tbdMp5eflAHfXdUr2Cd7NVyu3u?= =?utf-8?q?is4E/WmbmEHabGTZFuNjWw+QUJoxFXlM74tEzkICAz24BKWBx+QpYrV8czJJPwGEe?= =?utf-8?q?Hyl26Ly2jLD1YuAybXsi5qQZwUlvibRJYrofSc2TB3akBXDKaCtpqzLFwsHuvMACi?= =?utf-8?q?z0d30mk3eRvBNFD1iIJxg/pnEV15o6xIQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS8PR06MB7663.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(366016)(7416014)(376014)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?qv0cj5QQfnHvgQu7+Jo8ls2zUq30?= =?utf-8?q?3elN2jh6V2xMj+osxmyjqXEKAM+43r04x4HpPkxKXJJbfjGihJScnwijlJ8O5VKuv?= =?utf-8?q?FOj9rAboZ2iKlYRIovievtnPcNJyYEbDhETJd8iPYPwd2/T8DyCA7Vdlv548sN4xS?= =?utf-8?q?1il43ASFzjZFQ8uUUewZbKpPnqrSGgJT0TfZHzumawX4tzrnMlzlVtTzwxBJnHrbk?= =?utf-8?q?Rr7sZRdUIzXmyDJow0R26RAgs8dp0Sbm3gGapbJiskM7uOkTUpaLAlVdLgp7Z/35L?= =?utf-8?q?6lueNrknbOlEq+vde9gOEuWybqYo5nVBp7ZveyDHL9mdJc01nMxQQfHHDKQvqjNwI?= =?utf-8?q?A5eSxliNwSBuybb8yFZp0c2F5a6yIz1o+ZaB7blcwOyJdPC+y4pf2qJeszrccvTG3?= =?utf-8?q?ty2rPuxwJXsxp2cfMXmk+jJATdWlPXinPMA8i17Zc296UOhUYQaf/XyJfDlWormFm?= =?utf-8?q?QSorFjPkxge+GLsfU03cKFDdydwt+NeyDul4MxDKURjpW9Vu2+oF9n/E1grwQJ/tI?= =?utf-8?q?ZpFzORDiZBpkNHYOGZajgNHBaKQ/O9PG5YVdnJHwSdv0DoJcYtBPgMqjPanhvHHYz?= =?utf-8?q?+UJB4IARc06k8DexqwkusUZwM9Mtsb4zpcxRagTbN2ILWdrjpU81s3u9PvA65TxBI?= =?utf-8?q?lExepB3NE6cG+md6Ck2FKkg5ch12FNI+j7ll0qLy+FYNsuAHhTMF9H+wj/n+qv94c?= =?utf-8?q?NjMBZ1MCrfhMUu9dVhrDOYgK7eC/viwFG2Ym+98J6HqqBRh0LHTOf/8xvR4WrO4BZ?= =?utf-8?q?Iwltc3K2Jqm+155KUkLZzDP6uj2VMkP7tJmZTkpj7khiOtbIkNCPk2J3OWrgj0MyG?= =?utf-8?q?IQO9CBz+iwSV/6qyR+wbz6G7e5GD/bUJccCeVq0AAFb7uTarurechPeG5hoDHtGog?= =?utf-8?q?PL8Z78nZPxS+3zmnPiudox0YZNmrxvvOSrSH5OHfdNITWGaex5owIYRbHc72gyKrD?= =?utf-8?q?Bf8o+/vysi40CcL1RpF32puhrkG6aZAKRqELrDpOZeheuzx2+0wBuk5FkXQlOeC0u?= =?utf-8?q?uzfjXbtg5O5/nIOCz5hP90VYBE2z9ZGinyV71LVRwOsWbI5/Rfegen6bEcV0mjhVQ?= =?utf-8?q?Ns9itxLRLVchQZ3JzlZ3zc4xFjrk4x7A2bBtl1sIcIsmJ5tfqXohqWlYnCoRuKAqD?= =?utf-8?q?3UNSsfoK20LeBVsxOdFmIRyfBIOj3p0iN2SJEFKuMFKaepJOLafteLMXcsP25XT8X?= =?utf-8?q?MwPm6v5mcrUGuvTCzd5IHL1wc/df7MGJqRE0PkTXatg+N7Np/Q1mTpgof75Xt0adm?= =?utf-8?q?FajDZZkaCUq0X9/8LUQWWKfCbmJcD/edE/Ir8C9LcUyFKlGqz8jjNmChFCpDHYpmx?= =?utf-8?q?oOba4hGn/IDfgS6MueWptG4Yld1IlvyGZzmGFT6gQ4pgLkSqHou9b3GQuv/2P1/00?= =?utf-8?q?zfhsJHAPmpj4fc/tSWQS+46njFfR67Dv9uW1Fcnd1qpJVZGI7luyuiagJIHtbw9cd?= =?utf-8?q?4hUDi2eaqFoO06QU7BOElAAZf4LY9MTrYa2g6Dvx+URrY1P8y9hia5oInbzTV1o+8?= =?utf-8?q?boeA7mROPfl1?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04b2f066-59a7-433e-11f9-08ddb25395bb X-MS-Exchange-CrossTenant-AuthSource: OS8PR06MB7663.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 12:43:42.3334 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UGtQ8GPa+MVyv35MgorhQzEWKWq6tGcA+C4R6w5HZblTYCzu5gHcLEakgbf67jV+gViWA0Fl4Oop8Gk1R30sTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6611 The new devm_request_*irq_probe API prints an error message by default when the request fails, and consumers can provide custom error messages. Converting drivers to use this API has the following benefits: 1.More than 2,000 lines of code can be saved by removing redundant error messages in drivers. 2.Upper-layer functions can directly return error codes without missing debugging information. 3.Having proper and consistent information about why the device cannot be used is useful. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Pan Chuang --- drivers/thermal/airoha_thermal.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/airoha_thermal.c b/drivers/thermal/airoha_thermal.c index b9fd6bfc88e5..6918043c8630 100644 --- a/drivers/thermal/airoha_thermal.c +++ b/drivers/thermal/airoha_thermal.c @@ -441,13 +441,11 @@ static int airoha_thermal_probe(struct platform_device *pdev) if (irq < 0) return irq; - ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, - airoha_thermal_irq, IRQF_ONESHOT, - pdev->name, priv); - if (ret) { - dev_err(dev, "Can't get interrupt working.\n"); + ret = devm_request_threaded_irq_probe(&pdev->dev, irq, NULL, + airoha_thermal_irq, IRQF_ONESHOT, + pdev->name, priv, NULL); + if (ret) return ret; - } airoha_thermal_setup_monitor(priv); airoha_thermal_setup_adc_val(dev, priv);