From patchwork Wed Nov 6 13:28:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 178701 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp608251ilf; Wed, 6 Nov 2019 05:29:02 -0800 (PST) X-Google-Smtp-Source: APXvYqzGVUDloKuUkLaspLHEeyr/B7700lHPZgtpd5IelOncnBRjCd8ghTE9vFNJZD7Y8ltZQY6J X-Received: by 2002:a17:906:b74c:: with SMTP id fx12mr26122131ejb.324.1573046942457; Wed, 06 Nov 2019 05:29:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573046942; cv=none; d=google.com; s=arc-20160816; b=YxctgA4CYHhI3Qi6JFo9yY4WVz/nvJ4cy3e1GZVW/GE8VxZ3NUPoJlOHphmRwiIxv6 n1gQLvOLdt+JDBns3lMbYJ6AQhq8m1bI4QrlDPlc9qVDj3gug/+47G4Y2e0PR9PsFv5g cSaZN0BhreK9pa9brh8JC7XXlMexvCSU8/wohtzk5omj4FnV6YebP7zRtC6IrosoLf/o IJd+rqCXdYF5NMhIvceTQOlcFGJUPEw7i24f9VTSi4pTdlvUi01jOI8s839YrdQGHxLd VKblOFP5pXdw0nnKKdkCuso5DbfVdaqqoKILYwW7eYEIjBkbo9e7EHMWFJ/UMA5qme6D wbkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=2JC2BSAON2aTYfWnY286zBqdcBgF1dUkhFpgqH52P8A=; b=y/usahUjyPNom6HLlN5Bgb1fJaVJ3eEOtC4o5HlXRI8CnYYcvKgFi4TaZ3VHAPFrfr rv32oGeUlFi7ztU3uauhrqdOnluz2sZ8lkELM+CDbLRUYm9rZkMgOz40qPhsAfleWNtK atac/HPPG+LK4Epro1Vw/I6X8ISdtV65Lx3oqVgYHTqgbyVkQ2gAFpxdC5wWUq+mWvNR d7fuc7K0pQ9ntqNx+LRhQ4jb9xmmuRs3S81nbj7+/w9cTYfnmT9pfpxi1T/wNEVRkO8P 8PZVLK92UAda1hlVprylZLKbP4RbHUX1IeN0/DDWonABiZfr9C4X4Q8nDraJB8K06FDT gyMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GmREb2gA; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h5si3394467ejq.374.2019.11.06.05.29.02; Wed, 06 Nov 2019 05:29:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GmREb2gA; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731827AbfKFN3B (ORCPT + 10 others); Wed, 6 Nov 2019 08:29:01 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:41999 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731803AbfKFN3A (ORCPT ); Wed, 6 Nov 2019 08:29:00 -0500 Received: by mail-pg1-f195.google.com with SMTP id q17so1694581pgt.9 for ; Wed, 06 Nov 2019 05:29:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=2JC2BSAON2aTYfWnY286zBqdcBgF1dUkhFpgqH52P8A=; b=GmREb2gAFzVBw1JzE2epBfRKDBD9/8BHb4WsdWVr5lOtzpidmIw5GF3ZoJMBmiR2Lc hkiJAEHW0blLAPRX292U+12+AsV/FjNwUbuecXH9XavsxZR5ZGdmfy8qUOiga8JBaCHQ rCdQcLyLGFupMzXBlQpqtMxOpCb8qylIQELk0s8wrkVmGkfF79umn2K6WDk4xLVOpiLI 5RJyH9RUJzoadMkubpIwpy0T4PfwtaRawxNZF/W2TAMXRAOFzifYXQJu6tRRIoAW2IM2 ZhYtAHd6FSX09lWSsG6PADFFgZ4VKpmYAIPfmwW7hzVEJ1wgNQYi8uk7j2YsIzi3VNI/ dNYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=2JC2BSAON2aTYfWnY286zBqdcBgF1dUkhFpgqH52P8A=; b=FT7xos9IiPMT+I9FmVZxJlYldtUqrDWsZgU0sBcjsxvsDyYbLdFnPM78a23+foScE8 CaRxNsgf9fAFDkDOkhzUHU249p/seDpahpCXabVy0d1HKCAbhkUk2OurmUvh81yRxkMp 1RbLWAQ0iISlB1SH2Lq8mlWuUm3V9uLOHIpYqUAvNDJtWBPROBU/yVrCBxC52OmmrQgx Krczv55beyEuwOQxgno3+p0y2eQI+WN05ko3hwuZagyX4/0EY4rQHjIWXCUkaXdB0VJm iI/oq7oaa16Z23hXMF0Cc46t+YjwK79R5GMQnA05DkhgOv6GcmtgSlUTmNSQnVHPQuhc MY6A== X-Gm-Message-State: APjAAAVjqQIUaPkJqRK4QGqb5k+z1wwJILjyHRGP3ahtm4yQjDuVoSlc 30tIUMUWHyuLLL1pJC7KUsDpQw== X-Received: by 2002:aa7:9192:: with SMTP id x18mr3340660pfa.229.1573046939554; Wed, 06 Nov 2019 05:28:59 -0800 (PST) Received: from localhost ([49.248.202.230]) by smtp.gmail.com with ESMTPSA id q8sm20785909pgg.15.2019.11.06.05.28.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Nov 2019 05:28:59 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH 06/11] thermal: mediatek: Appease the kernel-doc deity Date: Wed, 6 Nov 2019 18:58:22 +0530 Message-Id: <2961e4ac4b32ea7db8b5f6916751a5c02ee85960.1573046440.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Replace a comment starting with /** by simply /* to avoid having it interpreted as a kernel-doc comment. Describe missing function parameters where needed. Fixes up the following warnings when compiled with make W=1: linux.git/drivers/thermal/mtk_thermal.c:374: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt8173_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:413: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt2701_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:443: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt2712_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:499: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt8183_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:529: warning: Function parameter or member 'sensno' not described in 'raw_to_mcelsius' Signed-off-by: Amit Kucheria --- drivers/thermal/mtk_thermal.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.17.1 Reviewed-by: Viresh Kumar diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c index acf4854cbb8b8..76e30603d4d58 100644 --- a/drivers/thermal/mtk_thermal.c +++ b/drivers/thermal/mtk_thermal.c @@ -358,7 +358,7 @@ static const int mt7622_mux_values[MT7622_NUM_SENSORS] = { 0, }; static const int mt7622_vts_index[MT7622_NUM_SENSORS] = { VTS1 }; static const int mt7622_tc_offset[MT7622_NUM_CONTROLLER] = { 0x0, }; -/** +/* * The MT8173 thermal controller has four banks. Each bank can read up to * four temperature sensors simultaneously. The MT8173 has a total of 5 * temperature sensors. We use each bank to measure a certain area of the @@ -400,7 +400,7 @@ static const struct mtk_thermal_data mt8173_thermal_data = { .sensor_mux_values = mt8173_mux_values, }; -/** +/* * The MT2701 thermal controller has one bank, which can read up to * three temperature sensors simultaneously. The MT2701 has a total of 3 * temperature sensors. @@ -430,7 +430,7 @@ static const struct mtk_thermal_data mt2701_thermal_data = { .sensor_mux_values = mt2701_mux_values, }; -/** +/* * The MT2712 thermal controller has one bank, which can read up to * four temperature sensors simultaneously. The MT2712 has a total of 4 * temperature sensors. @@ -484,7 +484,7 @@ static const struct mtk_thermal_data mt7622_thermal_data = { .sensor_mux_values = mt7622_mux_values, }; -/** +/* * The MT8183 thermal controller has one bank for the current SW framework. * The MT8183 has a total of 6 temperature sensors. * There are two thermal controller to control the six sensor. @@ -495,7 +495,6 @@ static const struct mtk_thermal_data mt7622_thermal_data = { * data, and this indeed needs the temperatures of the individual banks * for making better decisions. */ - static const struct mtk_thermal_data mt8183_thermal_data = { .auxadc_channel = MT8183_TEMP_AUXADC_CHANNEL, .num_banks = MT8183_NUM_SENSORS_PER_ZONE, @@ -519,7 +518,8 @@ static const struct mtk_thermal_data mt8183_thermal_data = { /** * raw_to_mcelsius - convert a raw ADC value to mcelsius - * @mt: The thermal controller + * @mt: The thermal controller + * @sensno: sensor number * @raw: raw ADC value * * This converts the raw ADC value to mcelsius using the SoC specific