diff mbox series

[V2,01/17] thermal: cpu_cooling: Avoid accessing potentially freed structures

Message ID b75219c6511ff0cf9a4c9c7603091286b803ae22.1492408342.git.viresh.kumar@linaro.org
State Accepted
Commit 289d72afddf83440117c35d864bf0c6309c1d011
Headers show
Series [V2,01/17] thermal: cpu_cooling: Avoid accessing potentially freed structures | expand

Commit Message

Viresh Kumar April 17, 2017, 6:01 a.m. UTC
After the lock is dropped, it is possible that the cpufreq_dev gets
freed before we call get_level() and that can cause kernel to crash.

Drop the lock after we are done using the structure.

Cc: 4.2+ <stable@vger.kernel.org> # 4.2+
Fixes: 02373d7c69b4 ("thermal: cpu_cooling: fix lockdep problems in cpu_cooling")
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

 drivers/thermal/cpu_cooling.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff mbox series


diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index 69d0f430b2d1..be29489dd247 100644
--- a/drivers/thermal/cpu_cooling.c
+++ b/drivers/thermal/cpu_cooling.c
@@ -153,8 +153,10 @@  unsigned long cpufreq_cooling_get_level(unsigned int cpu, unsigned int freq)
 	list_for_each_entry(cpufreq_dev, &cpufreq_dev_list, node) {
 		if (cpumask_test_cpu(cpu, &cpufreq_dev->allowed_cpus)) {
+			unsigned long level = get_level(cpufreq_dev, freq);
-			return get_level(cpufreq_dev, freq);
+			return level;