From patchwork Mon Jan 21 15:40:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 156218 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp6517740jaa; Mon, 21 Jan 2019 07:45:59 -0800 (PST) X-Google-Smtp-Source: ALg8bN6tpNKGnK4JpOV+YS6Tg8sOndsy0u8OdXMkREiVcVeEadu/HCu2n56RBMkvT1HWb8s7qPY6 X-Received: by 2002:a63:b105:: with SMTP id r5mr28776351pgf.442.1548085559519; Mon, 21 Jan 2019 07:45:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548085559; cv=none; d=google.com; s=arc-20160816; b=GNtfPL1LKuoqf8bDtimL2AUjBgDeoLRtZ9YIx6Fgc46XZ0pFLkYj3YqnuGIbrPx6fv jTytPuSc44cNYVjKrSTlhaGhNQzPwKUPSHZL/ieH905lZ3vzYTTJXfb38BAd6MkYuZ0X UvAYpqrzG/yztJCsAsKtu6KUqlI5OhERXvFq6fzMWfjPHh6x2Pfrb3urutt4Lvxo3rwu 0B1w2d1x+7uwB4cIs2pWCfyup8/anZnDY2mJFL7bTkLSbcjHiAds5bTxlW5at+aGjPuT ouOLMWblxms1G7Elfl9C027XJ/95fUf1JlEiwda9UmUot594WgC6KEoVB7DnK4M9Lr8s hJeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=xA//1FlkdsXmsx5auTFeNL+jjZLqfN7vDldrYpONvm4=; b=i/eqLqqpza8x/1NzIkACkzie9pDVxVUssTBGEsAVqo0vtg3O4ZTRKyOio7sNkHtAMX tlKv/6MEBpL/mv37oUUPjuljpGBq+ssUrZpdARISgy6TAU7h8uFFqeYjQTNH0wvQcPcW sbv/PYgvAQCjTBgP1BHB3Hh437bm4zJlxIE1HoTJ8JHyXg3XTHpdk882WbExSZ2Pk4iB icQWOYkRX48Hqeq45N1ZR4O81OQl8pOTaNVL8zeTbNVjAfnBych4GbtbjXnuReyFih4n 6yLVU4CVHg8dLTOQUbzXHR2aBDBTuyHVlFX0Yoc65xOpzSAZZz6ckJLlN7bxYxfiD5RC CNLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UYm41OgY; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v2si13649288pgn.451.2019.01.21.07.45.59; Mon, 21 Jan 2019 07:45:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UYm41OgY; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729880AbfAUPp6 (ORCPT + 11 others); Mon, 21 Jan 2019 10:45:58 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:38962 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728965AbfAUPp6 (ORCPT ); Mon, 21 Jan 2019 10:45:58 -0500 Received: by mail-wr1-f68.google.com with SMTP id t27so23920651wra.6 for ; Mon, 21 Jan 2019 07:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=xA//1FlkdsXmsx5auTFeNL+jjZLqfN7vDldrYpONvm4=; b=UYm41OgYi5vribcT/yRgVmTyOKfonDp1gCSdYoN5JVhxHQmtv7NPmG0xORTgY7t3pS T/H16ms5FnaubeVeQ/LqMlVCQyiGAXxiRrCooF7w9UuIa95pNlZAADkVBU6OMzCwfbPW Q82riebXP2V8q6m/jnTlG9XdykRzGvtKsBwIg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=xA//1FlkdsXmsx5auTFeNL+jjZLqfN7vDldrYpONvm4=; b=DvjdtgsuQQ+P7McwUoZGdY+OhVtVksRnU4h0mChASpfXL0cYj3u2MVaqrA072J9mRW q6pmaw7ilFF09j8t/bNxIFXdHQC8hfTNTrchAagGMs3UmDS7PJRppl07jRpWk5A3UW1k bB0F/dfcKZ5+FimUusebNA0VeORI+3rhqJN1JuMiLxsnAIX7bQWpg4mhu57SuIM3J3CQ b9QxniCutdtPR2SAVTpfosLBbmU5PG3QXZ2jB5n+FGyKnMFM/+/1Pl1fAKpZ0dN1+2fx 5KD569oe1IyQVcIbxIJB2FQm66M6ZPMMSQEX/0YjHjBhOEW7gxBLJ3xbBWmUfiwN7XOp JJLg== X-Gm-Message-State: AJcUukeWLK0Hx9Ct7p9x4BN+X16Pv5ORy6ae1ZRyk3lhDF0qX8NDl3DF n0lua3mtw4mU6iA7++rwx0TPkA== X-Received: by 2002:adf:d243:: with SMTP id o3mr29691751wri.66.1548085556785; Mon, 21 Jan 2019 07:45:56 -0800 (PST) Received: from localhost ([49.248.61.1]) by smtp.gmail.com with ESMTPSA id g188sm64972795wmf.32.2019.01.21.07.45.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jan 2019 07:45:56 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, viresh.kumar@linaro.org, edubezval@gmail.com, swboyd@chromium.org, dianders@chromium.org, mka@chromium.org, Sudeep Holla , "Rafael J. Wysocki" , Wei Yongjun , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: [PATCH v2 8/9] cpufreq: scmi: Use auto-registration of thermal cooling device Date: Mon, 21 Jan 2019 21:10:33 +0530 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Use the CPUFREQ_AUTO_REGISTER_COOLING_DEV flag to allow cpufreq core to automatically register as a thermal cooling device. This allows removal of boiler plate code from the driver. Signed-off-by: Amit Kucheria Acked-by: Sudeep Holla --- drivers/cpufreq/scmi-cpufreq.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) -- 2.17.1 diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index 242c3370544e..b19e9d129f8f 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include @@ -22,7 +21,6 @@ struct scmi_data { int domain_id; struct device *cpu_dev; - struct thermal_cooling_device *cdev; }; static const struct scmi_handle *handle; @@ -185,7 +183,6 @@ static int scmi_cpufreq_exit(struct cpufreq_policy *policy) { struct scmi_data *priv = policy->driver_data; - cpufreq_cooling_unregister(priv->cdev); dev_pm_opp_free_cpufreq_table(priv->cpu_dev, &policy->freq_table); kfree(priv); dev_pm_opp_remove_all_dynamic(priv->cpu_dev); @@ -193,17 +190,11 @@ static int scmi_cpufreq_exit(struct cpufreq_policy *policy) return 0; } -static void scmi_cpufreq_ready(struct cpufreq_policy *policy) -{ - struct scmi_data *priv = policy->driver_data; - - priv->cdev = of_cpufreq_cooling_register(policy); -} - static struct cpufreq_driver scmi_cpufreq_driver = { .name = "scmi", .flags = CPUFREQ_STICKY | CPUFREQ_HAVE_GOVERNOR_PER_POLICY | - CPUFREQ_NEED_INITIAL_FREQ_CHECK, + CPUFREQ_NEED_INITIAL_FREQ_CHECK | + CPUFREQ_AUTO_REGISTER_COOLING_DEV, .verify = cpufreq_generic_frequency_table_verify, .attr = cpufreq_generic_attr, .target_index = scmi_cpufreq_set_target, @@ -211,7 +202,6 @@ static struct cpufreq_driver scmi_cpufreq_driver = { .get = scmi_cpufreq_get_rate, .init = scmi_cpufreq_init, .exit = scmi_cpufreq_exit, - .ready = scmi_cpufreq_ready, }; static int scmi_cpufreq_probe(struct scmi_device *sdev)