From patchwork Wed Nov 29 09:34:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomas Glozar X-Patchwork-Id: 749966 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PZwgYlPk" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF969170B for ; Wed, 29 Nov 2023 01:37:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701250628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1UD4K9NrvPh5PjVlqNQCosFn3UsjtI7bo5Ml54xCjyo=; b=PZwgYlPkMS/rCO7q3ua1uOdaUL7DtIAdSBon1Ue0eV9hHrK5xRDjXx4xsZrwyelLl7qVXa 76+288IqHYImZ6ub29mQdBRB0YDs0wAiwS6+l5kMQkzdD98Q5rYNpUzE62b4bB6Bu1Rp4K 5hVXV4/G59R8jYQOiaz8qyvLWVcNMkg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-rXnzi2SrMSq3RPmE5_FP0A-1; Wed, 29 Nov 2023 04:37:06 -0500 X-MC-Unique: rXnzi2SrMSq3RPmE5_FP0A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 788C4185A780 for ; Wed, 29 Nov 2023 09:37:06 +0000 (UTC) Received: from fedora.brq.redhat.com (unknown [10.43.17.244]) by smtp.corp.redhat.com (Postfix) with ESMTP id E16CA40C6EB9; Wed, 29 Nov 2023 09:37:05 +0000 (UTC) From: tglozar@redhat.com To: linux-rt-users@vger.kernel.org Cc: jkacur@redhat.com, Tomas Glozar Subject: [PATCH 4/4] rteval: Add relative cpulists for measurements Date: Wed, 29 Nov 2023 10:34:57 +0100 Message-ID: <20231129093457.17984-5-tglozar@redhat.com> In-Reply-To: <20231129093457.17984-1-tglozar@redhat.com> References: <20231129093457.17984-1-tglozar@redhat.com> Precedence: bulk X-Mailing-List: linux-rt-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 From: Tomas Glozar Instead of specifying an absolute list of CPUs to run measurements on in --measurement-cpulist, implement an option to specify a relative list with respect to the current cpuset of rteval. The relative cpulist can include CPUs both for addition and for removal, e.g. +0,1,-7,8. Also move the logic for processing cpulists specified by the user as a string into cpulists usable by rteval to a single function. Signed-off-by: Tomas Glozar --- rteval-cmd | 26 +++++++----- rteval/cpulist_utils.py | 33 ++++++++++++++++ rteval/modules/measurement/__init__.py | 9 +---- rteval/modules/measurement/cyclictest.py | 50 +++--------------------- rteval/systopology.py | 33 ++++++++++++++++ 5 files changed, 90 insertions(+), 61 deletions(-) diff --git a/rteval-cmd b/rteval-cmd index 56b2c95..dd7d645 100755 --- a/rteval-cmd +++ b/rteval-cmd @@ -30,7 +30,7 @@ from rteval import RtEval, rtevalConfig from rteval.modules.loads import LoadModules from rteval.modules.measurement import MeasurementModules from rteval.version import RTEVAL_VERSION -from rteval.systopology import SysTopology +from rteval.systopology import SysTopology, parse_cpulist_from_config from rteval.modules.loads.kcompile import ModuleParameters import rteval.cpulist_utils as cpulist_utils @@ -336,26 +336,32 @@ if __name__ == '__main__': ldcfg = config.GetSection('loads') msrcfg = config.GetSection('measurement') - if ldcfg.cpulist and msrcfg.cpulist: + msrcfg_cpulist_present = msrcfg.cpulist != "" + # Parse measurement cpulist using parse_cpulist_from_config to account for run-on-isolcpus + # and relative cpusets + cpulist = parse_cpulist_from_config(msrcfg.cpulist, msrcfg.run_on_isolcpus) + if msrcfg_cpulist_present and not cpulist_utils.is_relative(msrcfg.cpulist) and msrcfg.run_on_isolcpus: + logger.log(Log.WARN, "ignoring --measurement-run-on-isolcpus, since cpulist is specified") + msrcfg.cpulist = cpulist_utils.collapse_cpulist(cpulist) + if ldcfg.cpulist: ldcfg.cpulist = remove_offline(ldcfg.cpulist) - msrcfg.cpulist = remove_offline(msrcfg.cpulist) # if we only specified one set of cpus (loads or measurement) # default the other to the inverse of the specified list - if not ldcfg.cpulist and msrcfg.cpulist: + if not ldcfg.cpulist and msrcfg_cpulist_present: tmplist = cpulist_utils.expand_cpulist(msrcfg.cpulist) tmplist = SysTopology().invert_cpulist(tmplist) - ldcfg.cpulist = cpulist_utils.compress_cpulist(tmplist) - msrcfg.cpulist = remove_offline(msrcfg.cpulist) - if not msrcfg.cpulist and ldcfg.cpulist: + tmplist = cpulist_utils.online_cpulist(tmplist) + ldcfg.cpulist = cpulist_utils.collapse_cpulist(tmplist) + if not msrcfg_cpulist_present and ldcfg.cpulist: tmplist = cpulist_utils.expand_cpulist(ldcfg.cpulist) tmplist = SysTopology().invert_cpulist(tmplist) - msrcfg.cpulist = cpulist_utils.compress_cpulist(tmplist) - ldcfg.cpulist = remove_offline(ldcfg.cpulist) + tmplist = cpulist_utils.online_cpulist(tmplist) + msrcfg.cpulist = cpulist_utils.collapse_cpulist(tmplist) if ldcfg.cpulist: logger.log(Log.DEBUG, f"loads cpulist: {ldcfg.cpulist}") # if --onlyload is specified msrcfg.cpulist is unused - if msrcfg.cpulist and not rtevcfg.onlyload: + if msrcfg_cpulist_present and not rtevcfg.onlyload: logger.log(Log.DEBUG, f"measurement cpulist: {msrcfg.cpulist}") logger.log(Log.DEBUG, f"workdir: {rtevcfg.workdir}") diff --git a/rteval/cpulist_utils.py b/rteval/cpulist_utils.py index 402d579..7abc45a 100644 --- a/rteval/cpulist_utils.py +++ b/rteval/cpulist_utils.py @@ -126,3 +126,36 @@ def nonisolated_cpulist(cpulist): isolated_cpulist = sysread(cpupath, "isolated") isolated_cpulist = expand_cpulist(isolated_cpulist) return list(set(cpulist).difference(set(isolated_cpulist))) + + +def is_relative(cpulist): + return cpulist.startswith("+") or cpulist.startswith("-") + + +def expand_relative_cpulist(cpulist): + """ + Expand a relative cpulist into a tuple of lists. + :param cpulist: Relative cpulist of form +1,2,3,-4,5,6 + :return: Tuple of two lists, one for added CPUs, one for removed CPUs + """ + added_cpus = [] + removed_cpus = [] + + if not cpulist: + return added_cpus, removed_cpus + + cpus = None + + for part in cpulist.split(','): + if part.startswith('+') or part.startswith('-'): + cpus = added_cpus if part[0] == '+' else removed_cpus + part = part[1:] + if '-' in part: + a, b = part.split('-') + a, b = int(a), int(b) + cpus.extend(list(range(a, b + 1))) + else: + a = int(part) + cpus.append(a) + + return list(set(added_cpus)), list(set(removed_cpus)) diff --git a/rteval/modules/measurement/__init__.py b/rteval/modules/measurement/__init__.py index 66dc9c5..11bd7b0 100644 --- a/rteval/modules/measurement/__init__.py +++ b/rteval/modules/measurement/__init__.py @@ -5,7 +5,7 @@ import libxml2 from rteval.modules import RtEvalModules, ModuleContainer -from rteval.systopology import SysTopology as SysTop +from rteval.systopology import parse_cpulist_from_config import rteval.cpulist_utils as cpulist_utils class MeasurementProfile(RtEvalModules): @@ -183,12 +183,7 @@ measurement profiles, based on their characteristics""" rep_n = libxml2.newNode("Measurements") cpulist = self.__cfg.GetSection("measurement").cpulist run_on_isolcpus = self.__cfg.GetSection("measurement").run_on_isolcpus - if cpulist: - # Convert str to list and remove offline cpus - cpulist = cpulist_utils.expand_cpulist(cpulist) - cpulist = cpulist_utils.online_cpulist(cpulist) - else: - cpulist = SysTop().online_cpus() if run_on_isolcpus else SysTop().default_cpus() + cpulist = parse_cpulist_from_config(cpulist, run_on_isolcpus) rep_n.newProp("measurecpus", cpulist_utils.collapse_cpulist(cpulist)) for mp in self.__measureprofiles: diff --git a/rteval/modules/measurement/cyclictest.py b/rteval/modules/measurement/cyclictest.py index dcfca0b..87fa9d8 100644 --- a/rteval/modules/measurement/cyclictest.py +++ b/rteval/modules/measurement/cyclictest.py @@ -16,8 +16,7 @@ import math import libxml2 from rteval.Log import Log from rteval.modules import rtevalModulePrototype -from rteval.systopology import cpuinfo -from rteval.systopology import SysTopology +from rteval.systopology import cpuinfo, parse_cpulist_from_config import rteval.cpulist_utils as cpulist_utils @@ -192,39 +191,9 @@ class Cyclictest(rtevalModulePrototype): self.__priority = int(self.__cfg.setdefault('priority', 95)) self.__buckets = int(self.__cfg.setdefault('buckets', 2000)) self.__numcores = 0 - self.__cpus = [] self.__cyclicdata = {} - self.__sparse = False - self.__run_on_isolcpus = bool(self.__cfg.setdefault('run-on-isolcpus', False)) - - if self.__cfg.cpulist: - self.__cpulist = self.__cfg.cpulist - self.__cpus = cpulist_utils.expand_cpulist(self.__cpulist) - # Only include online cpus - self.__cpus = cpulist_utils.online_cpulist(self.__cpus) - # Reset cpulist from the newly calculated self.__cpus - self.__cpulist = cpulist_utils.collapse_cpulist(self.__cpus) - self.__cpus = [str(c) for c in self.__cpus] - self.__sparse = True - if self.__run_on_isolcpus: - self._log(Log.WARN, "ignoring --measurement-run-on-isolcpus, since cpulist is specified") - else: - self.__cpus = SysTopology().online_cpus_str() - # Get the cpuset from the environment - cpuset = os.sched_getaffinity(0) - # Convert the elements to strings - cpuset = [str(c) for c in cpuset] - # Get isolated CPU list - isolcpus = [str(c) for c in SysTopology().isolated_cpus()] - # Only include cpus that are in the cpuset and isolated CPUs if run_on_isolcpus is enabled - self.__cpus = [c for c in self.__cpus if c in cpuset or self.__run_on_isolcpus and c in isolcpus] - if self.__run_on_isolcpus: - self.__sparse = True - self.__cpulist = cpulist_utils.collapse_cpulist([int(c) for c in self.__cpus]) - - # Sort the list of cpus to align with the order reported by cyclictest - self.__cpus.sort(key=int) - + self.__cpulist = self.__cfg.cpulist + self.__cpus = [str(c) for c in cpulist_utils.expand_cpulist(self.__cpulist)] self.__numcores = len(self.__cpus) info = cpuinfo() @@ -241,10 +210,7 @@ class Cyclictest(rtevalModulePrototype): logfnc=self._log) self.__cyclicdata['system'].description = (f"({self.__numcores} cores) ") + info['0']['model name'] - if self.__sparse: - self._log(Log.DEBUG, f"system using {self.__numcores} cpu cores") - else: - self._log(Log.DEBUG, f"system has {self.__numcores} cpu cores") + self._log(Log.DEBUG, f"system using {self.__numcores} cpu cores") self.__started = False self.__cyclicoutput = None self.__breaktraceval = None @@ -279,12 +245,8 @@ class Cyclictest(rtevalModulePrototype): f'-h {self.__buckets}', f"-p{int(self.__priority)}", ] - if self.__sparse: - self.__cmd.append(f'-t{self.__numcores}') - self.__cmd.append(f'-a{self.__cpulist}') - else: - self.__cmd.append('-t') - self.__cmd.append('-a') + self.__cmd.append(f'-t{self.__numcores}') + self.__cmd.append(f'-a{self.__cpulist}') if 'threads' in self.__cfg and self.__cfg.threads: self.__cmd.append(f"-t{int(self.__cfg.threads)}") diff --git a/rteval/systopology.py b/rteval/systopology.py index 9db1a80..40ac5ab 100644 --- a/rteval/systopology.py +++ b/rteval/systopology.py @@ -241,6 +241,39 @@ class SysTopology: """ return a list of online cpus in cpulist """ return [c for c in self.online_cpus() if c in cpulist] + +def parse_cpulist_from_config(cpulist, run_on_isolcpus=False): + """ + Generates a cpulist based on --*-cpulist argument given by user + :param cpulist: Value of --*-cpulist argument + :param run_on_isolcpus: Value of --*-run-on-isolcpus argument + :return: Sorted list of CPUs as integers + """ + if cpulist and not cpulist_utils.is_relative(cpulist): + result = cpulist_utils.expand_cpulist(cpulist) + # Only include online cpus + result = cpulist_utils.online_cpulist(result) + else: + result = SysTopology().online_cpus() + # Get the cpuset from the environment + cpuset = os.sched_getaffinity(0) + # Get isolated CPU list + isolcpus = SysTopology().isolated_cpus() + if cpulist and cpulist_utils.is_relative(cpulist): + # Include cpus that are not removed in relative cpuset and are either in cpuset from affinity, + # isolcpus (with run_on_isolcpus enabled, or added by relative cpuset + added_cpus, removed_cpus = cpulist_utils.expand_relative_cpulist(cpulist) + result = [c for c in result + if (c in cpuset or + c in added_cpus or + run_on_isolcpus and c in isolcpus) and + c not in removed_cpus] + else: + # Only include cpus that are in the cpuset and isolated CPUs if run_on_isolcpus is enabled + result = [c for c in result if c in cpuset or run_on_isolcpus and c in isolcpus] + return result + + if __name__ == "__main__": def unit_test():