| Message ID | 1454079040-3567945-1-git-send-email-arnd@arndb.de |
|---|---|
| Headers | show |
| Series | ARM: samsung warning fixes | expand |
On 29.01.2016 23:50, Arnd Bergmann wrote: > EEPROM_AT24 depends on both I2C and SYSFS. We have in the past > added I2C 'select' statements to avoid build problems with the > first, but we still get a warning because of the second: > > warning: (MACH_DAVINCI_EVM && MACH_SFFSDR && MACH_DAVINCI_DM6467_EVM && MACH_DAVINCI_DM365_EVM && MACH_DAVINCI_DA830_EVM && MACH_MITYOMAPL138 && MACH_MINI2440) selects EEPROM_AT24 which has unmet direct dependencies (I2C && SYSFS) > > This removes the 'select' statements again, and forces users to > enable the driver in their configuration files, as we do for > most other drivers. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/configs/mini2440_defconfig | 1 + > arch/arm/configs/s3c2410_defconfig | 1 + > arch/arm/mach-s3c24xx/Kconfig | 1 - > 3 files changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 29.01.2016 23:50, Arnd Bergmann wrote: > The S3C2440_XTAL_16934400 and S3C2440_XTAL_12000000 symbols are used > for both s3c2442 and s3c2440, but Kconfig only allows it to be selected > if CPU_S3C2440 is enabled, which can lead to a warning otherwise: > > warning: (MACH_RX1950) selects S3C2440_XTAL_16934400 which has unmet direct dependencies (ARCH_S3C24XX && CPU_S3C2440) > > This changes the dependencies to make it possible also for CPU_S3C2442-only > configurations. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/mach-s3c24xx/Kconfig | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 29.01.2016 23:50, Arnd Bergmann wrote: > Bluetooth is only supported when network support is part of the kernel, > so it is a bit pointless to build the hi1940-bt support without networking. > If we try anyway, we get a Kconfig warning: > > warning: (TOSA_BT && H1940BT) selects RFKILL which has unmet direct dependencies (NET) > > This adds a dependency on CONFIG_NET to avoid that case. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/mach-s3c24xx/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig > index 5884bbb7952e..bf66c8334822 100644 > --- a/arch/arm/mach-s3c24xx/Kconfig > +++ b/arch/arm/mach-s3c24xx/Kconfig > @@ -227,7 +227,7 @@ config ARCH_H1940 > > config H1940BT > tristate "Control the state of H1940 bluetooth chip" > - depends on ARCH_H1940 > + depends on ARCH_H1940 && NET > select RFKILL > help > This is a simple driver that is able to control I think there shouldn't be a reverse dependency for RFKILL but instead just: depends on ARCH_H1940 && RFKILL This makes it simpler and RFKILL is a user-visible symbol. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 29.01.2016 23:50, Arnd Bergmann wrote: > We cannot select a symbol that has disabled dependencies, so > we get a warning if we ever enable EXYNOS_THERMAL without > also turning on THERMAL_OF: > > warning: (ARCH_EXYNOS) selects EXYNOS_THERMAL which has unmet direct dependencies (THERMAL && (ARCH_EXYNOS || COMPILE_TEST) && THERMAL_OF) > > This adds another 'select' in the platform code to avoid that > case. Alternatively, we could decide to not select EXYNOS_THERMAL > here and instead make it a user option. We want EXYNOS_THERMAL because we are using boost cpufreq on Exynos4x12 (through turbo frequencies in DTS and cpufreq-dt) so your current solution is a proper fix for: Fixes: f87e6bd3f740 ("thermal: exynos: Add the dependency of CONFIG_THERMAL_OF instead of CONFIG_OF") Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/mach-exynos/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 652a0bb11578..5189bcecad12 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS > select S5P_DEV_MFC > select SRAM > select THERMAL > + select THERMAL_OF > select MFD_SYSCON > select CLKSRC_EXYNOS_MCT > select POWER_RESET > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html