mbox series

[v4,0/5] Add DW PCIe support for Exynos5433 SoCs

Message ID 20201113170139.29956-1-m.szyprowski@samsung.com
Headers show
Series Add DW PCIe support for Exynos5433 SoCs | expand

Message

Marek Szyprowski Nov. 13, 2020, 5:01 p.m. UTC
Dear All,

This patchset is a resurrection of the DW PCIe support for the Exynos5433
SoCs posted long time ago here: https://lkml.org/lkml/2016/12/26/6 and
later here: https://lkml.org/lkml/2017/12/21/296 .

In meantime the support for the Exynos5440 SoCs has been completely
dropped from mainline kernel, as those SoCs never reached the market. The
PCIe driver for Exynos5440 variant however has not been removed yet. This
patchset simply reworks it to support the Exynos5433 variant. The lack of
the need to support both variants significantly simplifies the driver
code.

This patchset is based on the commit b90c53b06597 ("PCI: dwc: Detect
number of iATU windows") available on the following branch:
git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git pci-more-dwc-cleanup

Best regards,
Marek Szyprowski


Changelog:

v4:
- fixed topics to better match the common style of the each subsystem
- rebased onto "[PATCH v2 00/16] PCI: dwc: Another round of clean-ups"
- collected tags, dropped merged dts patch

v3: https://lore.kernel.org/linux-samsung-soc/20201029134017.27400-1-m.szyprowski@samsung.com/
- rebased onto "[00/13] PCI: dwc: Another round of clean-ups" patchset:
  https://patchwork.kernel.org/project/linux-samsung-soc/cover/20201028204646.356535-1-robh@kernel.org/
- fixed issues pointed by Rob in the driver logic:
  * removed DBI_RO_WR_EN register poking
  * made driver a standard module
- fixed section mismatch issue
- added "num-viewport = <3>" property to dts and bindings to fix warning

v2: https://lore.kernel.org/linux-samsung-soc/20201023075744.26200-1-m.szyprowski@samsung.com/
- fixed issues in dt-bindings pointed by Krzysztof and Rob

v1: https://lore.kernel.org/linux-samsung-soc/20201019094715.15343-1-m.szyprowski@samsung.com/
- initial version of this resurrected patchset


Patch summary:

Jaehoon Chung (2):
  phy: samsung: phy-exynos-pcie: rework driver to support Exynos5433
    PCIe PHY
  PCI: dwc: exynos: Rework the driver to support Exynos5433 variant

Marek Szyprowski (3):
  dt-bindings: PCI: exynos: drop samsung,exynos5440-pcie binding
  dt-bindings: PCI: exynos: add the samsung,exynos-pcie binding
  dt-bindings: phy: exynos: add the samsung,exynos-pcie-phy binding

 .../bindings/pci/samsung,exynos-pcie.yaml     | 119 ++++++
 .../bindings/pci/samsung,exynos5440-pcie.txt  |  58 ---
 .../bindings/phy/samsung,exynos-pcie-phy.yaml |  51 +++
 drivers/pci/controller/dwc/Kconfig            |  10 +-
 drivers/pci/controller/dwc/pci-exynos.c       | 353 +++++++-----------
 drivers/pci/quirks.c                          |   1 +
 drivers/phy/samsung/phy-exynos-pcie.c         | 304 ++++++---------
 7 files changed, 429 insertions(+), 467 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml
 delete mode 100644 Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt
 create mode 100644 Documentation/devicetree/bindings/phy/samsung,exynos-pcie-phy.yaml

-- 
2.17.1

Comments

Marek Szyprowski Nov. 20, 2020, 9:58 a.m. UTC | #1
Hi Vinod,

On 20.11.2020 10:41, Vinod Koul wrote:
> On 13-11-20, 18:01, Marek Szyprowski wrote:
>> From: Jaehoon Chung <jh80.chung@samsung.com>
>>
>> Exynos5440 SoC support has been dropped since commit 8c83315da1cf ("ARM:
>> dts: exynos: Remove Exynos5440"). Rework this driver to support PCIe PHY
>> variant found in the Exynos5433 SoCs.
> I am expecting this series to go thru PCI tree, so:
>
> Acked-By: Vinod Koul <vkoul@kernel.org>

Frankly, the PHY driver can also go via PHY tree without causing any 
issue. The old driver is not used at all, so there is no runtime 
dependency. This will help avoiding the merge conflict: yesterday I've 
noticed that this patch conflicts with the commit 2f0c9fac3be6 ("phy: 
samsung: convert to devm_platform_ioremap_resource") in phy-next. The 
resolution is simple (use all the code from the new driver), but if 
needed I can resend the PHY driver after a rebase onto the current next 
tree.

Best regards
Lorenzo Pieralisi Nov. 23, 2020, 9:53 a.m. UTC | #2
On Fri, 13 Nov 2020 18:01:34 +0100, Marek Szyprowski wrote:
> This patchset is a resurrection of the DW PCIe support for the Exynos5433
> SoCs posted long time ago here: https://lkml.org/lkml/2016/12/26/6 and
> later here: https://lkml.org/lkml/2017/12/21/296 .
> 
> In meantime the support for the Exynos5440 SoCs has been completely
> dropped from mainline kernel, as those SoCs never reached the market. The
> PCIe driver for Exynos5440 variant however has not been removed yet. This
> patchset simply reworks it to support the Exynos5433 variant. The lack of
> the need to support both variants significantly simplifies the driver
> code.
> 
> [...]

Applied to pci/dwc, thanks!

[1/5] dt-bindings: PCI: exynos: drop samsung,exynos5440-pcie binding
      https://git.kernel.org/lpieralisi/pci/c/83fbffcd13
[2/5] dt-bindings: PCI: exynos: add the samsung,exynos-pcie binding
      https://git.kernel.org/lpieralisi/pci/c/eea23e4a00
[3/5] dt-bindings: phy: exynos: add the samsung,exynos-pcie-phy binding
      https://git.kernel.org/lpieralisi/pci/c/a7b4dba9a7
[4/5] phy: samsung: phy-exynos-pcie: rework driver to support Exynos5433 PCIe PHY
      https://git.kernel.org/lpieralisi/pci/c/46bc965df0
[5/5] PCI: dwc: exynos: Rework the driver to support Exynos5433 variant
      https://git.kernel.org/lpieralisi/pci/c/f0a6743028

Thanks,
Lorenzo