mbox series

[0/2] clk: samsung: Update PLL locktime and samsung function

Message ID 20240926144513.71349-1-v.pavani@samsung.com
Headers show
Series clk: samsung: Update PLL locktime and samsung function | expand

Message

Varada Pavani Sept. 26, 2024, 2:45 p.m. UTC 
This patch series updates samsung clock driver with common samsung
CCF function and defines locktime value for PLL142XX controller.

Varada Pavani (2):
  clk: samsung: Use samsung CCF common function
  clk: samsung: Fixes PLL locktime for PLL142XX used on FSD platfom

 drivers/clk/samsung/clk-exynos4.c | 78 +++++++++++++++++--------------
 drivers/clk/samsung/clk-pll.c     |  7 ++-
 2 files changed, 50 insertions(+), 35 deletions(-)

Comments

Krzysztof Kozlowski Sept. 30, 2024, 10:37 a.m. UTC | #1 
On 26/09/2024 16:45, Varada Pavani wrote:
> Add PLL locktime for PLL142XX controller.

You marked it as fixes. Please describe the observable bug and its
impact. See submitting patches and stable kernel rules.

> 
> Fixes: 4f346005aaed ("clk: samsung: fsd: Add initial clock support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Varada Pavani <v.pavani@samsung.com>
> ---
Best regards,
Krzysztof
Krzysztof Kozlowski Sept. 30, 2024, 10:38 a.m. UTC | #2 
On 26/09/2024 16:45, Varada Pavani wrote:
> This patch series updates samsung clock driver with common samsung
> CCF function and defines locktime value for PLL142XX controller.
> 
> Varada Pavani (2):
>   clk: samsung: Use samsung CCF common function

Where is this patch?

>   clk: samsung: Fixes PLL locktime for PLL142XX used on FSD platfom

Best regards,
Krzysztof
Varada Pavani Oct. 1, 2024, 1:30 p.m. UTC | #3 
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzk@kernel.org]
> Sent: 30 September 2024 16:07
> To: Varada Pavani <v.pavani@samsung.com>; aswani.reddy@samsung.com;
> pankaj.dubey@samsung.com; s.nawrocki@samsung.com;
> cw00.choi@samsung.com; alim.akhtar@samsung.com;
> mturquette@baylibre.com; sboyd@kernel.org; linux-samsung-
> soc@vger.kernel.org; linux-clk@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Cc: gost.dev@samsung.com; stable@vger.kernel.org
> Subject: Re: [PATCH 2/2] clk: samsung: Fixes PLL locktime for PLL142XX used
> on FSD platfom
> 
> On 26/09/2024 16:45, Varada Pavani wrote:
> > Add PLL locktime for PLL142XX controller.
> 
> You marked it as fixes. Please describe the observable bug and its impact.
> See submitting patches and stable kernel rules.
> 

We marked it fixes because there is a software bug.  Both PLL142XX and
PLL35XX have same configurations with only change in locktime period
which is 150*PDIV . Hence updated locktime as per the defined spec.
Will update this information in the commit message and push V2 version.

Regards,
Varada Pavani

> >
> > Fixes: 4f346005aaed ("clk: samsung: fsd: Add initial clock support")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Varada Pavani <v.pavani@samsung.com>
> > ---
> Best regards,
> Krzysztof