From patchwork Mon May 26 15:29:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shukla X-Patchwork-Id: 30932 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qc0-f198.google.com (mail-qc0-f198.google.com [209.85.216.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 468AB20491 for ; Mon, 26 May 2014 15:30:45 +0000 (UTC) Received: by mail-qc0-f198.google.com with SMTP id m20sf29032772qcx.1 for ; Mon, 26 May 2014 08:30:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=yva1At1D35YKh0VminbwG49ebdBPo/Lpqu7QbHwZ7/I=; b=e4TwrqZDmRHc6X0uTh6bYceHy6Hr1rpJtG6meTz8Td0LGHuxH/ee191by6cuNsTJaN ZenaRED/3qUR5nA1GfwpIoF9OQ4nR1fIW+D+Bxowc4F8e0EdXy3LWZMqBhOI5lQnMEST Azfleo6m1MjwEwk9snFX5rQesY6zJa1GoysICn2vLPsN6r33DGFWAWu/okzJEympCeS3 277XHgMIwe+mQHlXHgh14n0gPgUwkHdXZAk86jl1Xe0Cqkab9jkzjz8cNEcyyvWb8Hdt b0M46OhHz8MAVtNRf+zIw/Rw0RfJZ2WmN2uoVQlRnvO2+/htlIDPULr1r/uPyrkpGn7v Am9Q== X-Gm-Message-State: ALoCoQlc+b7tbdSE7B/MdTQENbRVhRiwvzcBcBjbz6Y6FYm53mnsDf2dS0oquzvJM4d4k4fG6SaN X-Received: by 10.58.236.5 with SMTP id uq5mr10119555vec.35.1401118244862; Mon, 26 May 2014 08:30:44 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.80.81 with SMTP id b75ls2873819qgd.34.gmail; Mon, 26 May 2014 08:30:44 -0700 (PDT) X-Received: by 10.220.10.2 with SMTP id n2mr22177095vcn.26.1401118244759; Mon, 26 May 2014 08:30:44 -0700 (PDT) Received: from mail-vc0-f169.google.com (mail-vc0-f169.google.com [209.85.220.169]) by mx.google.com with ESMTPS id iy12si6446179vec.61.2014.05.26.08.30.44 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 26 May 2014 08:30:44 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.169 as permitted sender) client-ip=209.85.220.169; Received: by mail-vc0-f169.google.com with SMTP id ij19so9462180vcb.0 for ; Mon, 26 May 2014 08:30:44 -0700 (PDT) X-Received: by 10.58.29.234 with SMTP id n10mr22325125veh.16.1401118244681; Mon, 26 May 2014 08:30:44 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp52294vcb; Mon, 26 May 2014 08:30:44 -0700 (PDT) X-Received: by 10.68.186.130 with SMTP id fk2mr29223942pbc.60.1401118243920; Mon, 26 May 2014 08:30:43 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gq8si15077885pbc.50.2014.05.26.08.30.43; Mon, 26 May 2014 08:30:43 -0700 (PDT) Received-SPF: none (google.com: linux-samsung-soc-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752334AbaEZPal (ORCPT + 9 others); Mon, 26 May 2014 11:30:41 -0400 Received: from mail-pb0-f51.google.com ([209.85.160.51]:56887 "EHLO mail-pb0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751984AbaEZPai (ORCPT ); Mon, 26 May 2014 11:30:38 -0400 Received: by mail-pb0-f51.google.com with SMTP id ma3so7904823pbc.10 for ; Mon, 26 May 2014 08:30:38 -0700 (PDT) X-Received: by 10.66.142.233 with SMTP id rz9mr29178089pab.71.1401118237949; Mon, 26 May 2014 08:30:37 -0700 (PDT) Received: from santosh-Latitude-E5530-non-vPro.mvista.com ([111.93.218.67]) by mx.google.com with ESMTPSA id ue3sm14280965pbc.49.2014.05.26.08.30.34 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 26 May 2014 08:30:36 -0700 (PDT) From: Santosh Shukla To: viresh.kumar@linaro.org, kgene.kim@samsung.com, thomas.abraham@linaro.org, t.figa@samsung.com, linux-samsung-soc@vger.kernel.org Cc: linaro-kernel@lists.linaro.org, santosh shukla Subject: [PATCH v2] ARM: Exynos : Fix build error with thumb2 Date: Mon, 26 May 2014 20:59:47 +0530 Message-Id: <1401118187-10844-1-git-send-email-santosh.shukla@linaro.org> X-Mailer: git-send-email 1.7.9.5 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: santosh.shukla@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.169 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: santosh shukla add non-global symbol .LLl2x0_regs_phys to avoid build break in thumb2 mode. IIUC, arm assembler fail to load value of "global" variable l2xo_regs_phys for thum2 mode and wrapping it in non-global symbol like .Ll2x0_regs_phys solves the build break issue. arch/arm/mach-exynos/sleep.S: Assembler messages: arch/arm/mach-exynos/sleep.S:57: Error: invalid immediate for address calculation (value = 0x00000004) fix inspired from [1] [1] : https://lkml.org/lkml/2010/3/31/235 Signed-off-by: santosh shukla --- arch/arm/mach-exynos/sleep.S | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-exynos/sleep.S b/arch/arm/mach-exynos/sleep.S index a2613e9..dc8c6b6 100644 --- a/arch/arm/mach-exynos/sleep.S +++ b/arch/arm/mach-exynos/sleep.S @@ -54,7 +54,7 @@ ENTRY(exynos_cpu_resume) ldr r1, =CPU_CORTEX_A9 cmp r0, r1 bne skip_l2_resume - adr r0, l2x0_regs_phys + adr r0, .Ll2x0_regs_phys ldr r0, [r0] cmp r0, #0 beq skip_l2_resume @@ -79,6 +79,8 @@ skip_l2_resume: b cpu_resume ENDPROC(exynos_cpu_resume) #ifdef CONFIG_CACHE_L2X0 + +.Ll2x0_regs_phys: .globl l2x0_regs_phys l2x0_regs_phys: .long 0