From patchwork Wed Feb 3 12:42:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 61080 Delivered-To: patch@linaro.org Received: by 10.112.43.199 with SMTP id y7csp269963lbl; Wed, 3 Feb 2016 04:48:45 -0800 (PST) X-Received: by 10.98.68.73 with SMTP id r70mr1853919pfa.136.1454503406496; Wed, 03 Feb 2016 04:43:26 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w18si9144894pfi.224.2016.02.03.04.43.26; Wed, 03 Feb 2016 04:43:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933680AbcBCMnY (ORCPT + 4 others); Wed, 3 Feb 2016 07:43:24 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:54372 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933679AbcBCMnS (ORCPT ); Wed, 3 Feb 2016 07:43:18 -0500 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O1Z005I12031F90@mailout3.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Wed, 03 Feb 2016 12:43:15 +0000 (GMT) X-AuditID: cbfec7f4-f79026d00000418a-bf-56b1f5e39b98 Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 31.0D.16778.3E5F1B65; Wed, 3 Feb 2016 12:43:15 +0000 (GMT) Received: from amdc1339.digital.local ([106.116.147.30]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O1Z00B561ZTMTA0@eusync3.samsung.com>; Wed, 03 Feb 2016 12:43:15 +0000 (GMT) From: Marek Szyprowski To: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Andrzej Hajda , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz Subject: [PATCH 10/10] drm/exynos: exynos5433_decon: fix wrong state in decon_vblank_enable Date: Wed, 03 Feb 2016 13:42:54 +0100 Message-id: <1454503374-16382-11-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.2 In-reply-to: <1454503374-16382-1-git-send-email-m.szyprowski@samsung.com> References: <1454503374-16382-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprILMWRmVeSWpSXmKPExsVy+t/xq7qPv24MM7h0k93i1rpzrBYbZ6xn tbjy9T2bxaT7E1gsXty7yGLx+oWhxYzz+5gs1h65y24xY/JLNgdOj/vdx5k8+rasYvT4vEku gDmKyyYlNSezLLVI3y6BK2P/jslMBcfZK+ZePsbSwHiArYuRg0NCwESiZ5djFyMnkCkmceHe eqAwF4eQwFJGiVcnFjGCJIQEmpgk/k/JALHZBAwlut52sYHYIgJuEk2HZ7KCNDALbGGSaN+1 kQkkISwQK/Hq/x9mEJtFQFXiZ3sbmM0r4Clx68NMZohtchL/X64Aq+cEiu/p6GQBOUhIwENi zi3/CYy8CxgZVjGKppYmFxQnpeca6hUn5haX5qXrJefnbmKEBNSXHYyLj1kdYhTgYFTi4WX4 sSFMiDWxrLgy9xCjBAezkgiv0eeNYUK8KYmVValF+fFFpTmpxYcYpTlYlMR55+56HyIkkJ5Y kpqdmlqQWgSTZeLglGpgbHj5STBCfr3/RYlDOeZmzSmXp7/Ljd1+2ktF6PaXog7dDSsapq1/ tj3t4KF0Tc0PhfMzdR7Yyp7bqlacKXV02vTpZxuneYQlSRl8yyqt1z0d+9yGPyXJxvibi3q6 9a/q/4df75qvdM1PwjR8u90RDvX89CuM3RUcoTsaD9psO/NY8dr/Kwz3lFiKMxINtZiLihMB +6SfKSQCAAA= Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org BIT_IRQS_ENABLED was never set because of incorrect test in decon_vlank_enable() function, what resulted in lack of enabling vblank support. This patch fixes this issue. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.2 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c index c793316..107224a 100644 --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c @@ -93,7 +93,7 @@ static int decon_enable_vblank(struct exynos_drm_crtc *crtc) if (test_bit(BIT_SUSPENDED, &ctx->flags)) return -EPERM; - if (test_and_set_bit(BIT_IRQS_ENABLED, &ctx->flags)) { + if (!test_and_set_bit(BIT_IRQS_ENABLED, &ctx->flags)) { val = VIDINTCON0_INTEN; if (ctx->out_type == IFTYPE_I80) val |= VIDINTCON0_FRAMEDONE;