From patchwork Thu Jun 7 11:06:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 137862 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp1948387lji; Thu, 7 Jun 2018 04:06:25 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJ7CFembShDkOsRArHLv2OJgormePZMiTPT5cUGTWk4ZZesy+/OQ0rOrXY3asf2fu67HgPh X-Received: by 2002:a17:902:bd8f:: with SMTP id q15-v6mr1498611pls.161.1528369585347; Thu, 07 Jun 2018 04:06:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528369585; cv=none; d=google.com; s=arc-20160816; b=C00c5xwz4/ft4yn8Kq9qtxQRDg1WnqbffPwuaiV9eW9Zd5GYwWrx1x4RzG9lGSmAsC X0Ww91V9B/fEbECqYPG5C/TAtOJJKPacz+Hc1fEiuO7oNWs+BxVdTdDJ5KykgYbXINVe EFFAo8jOu7EkJQOZKPpHbRYb7hzWNK3MfaDExj2K3sewERcsFIXQYrPCKoOxgxcJUHj/ kM1qr2cUZxCoZmTCfJYNLqZk1H5yztIEqfZrf8TLfiVQQ6qZFJw5828oVxFwadKF8J6q R/zsgUZJF7pWItXqW0JBNCRL6MhTviUzCkQlr0VrJ6ybnBGGzuhw3O5PlfFaCmGYDsE9 zjnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:cms-type:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=Iaact/gYqsZo4P9qApTtTjc9uQBaa2MvN9nBrMNx4WI=; b=ZHXNi/JrGJ2S1G0Mp5QX11NIzecxAyIZ01BRNOWo/NQhM6kGjoK3dHloQ/7Tohe7Ak RUxl/mRMOE3+7j5AeghjAMz5CM1A7rjxZzUhVzYUQpaHgHHewNsavuCbx1F9f8jkIQV/ 2+LeShNhn8o6hyuWgpvWQ1HmgDJ+ybQlzajjFoGANhjpnNAzJQL3zsYV7xV18qD5ZcxT WGyU1Yyr7+LFx5fPqgjrlhKWH3e10AY1TxIPdIFiD/LqNKITg1OS2mIh7+rFhALesTMv THJpd26Glc0l7irpspUhGLtTVjxHhT1VCRC/6ZT1N7LTQEawavjJJFG1MEuLXsQ754oI GjHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@samsung.com header.s=mail20170921 header.b=s1yNaEu2; spf=pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p8-v6si15144102pgd.96.2018.06.07.04.06.25; Thu, 07 Jun 2018 04:06:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@samsung.com header.s=mail20170921 header.b=s1yNaEu2; spf=pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753324AbeFGLGY (ORCPT + 3 others); Thu, 7 Jun 2018 07:06:24 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:33804 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753169AbeFGLGX (ORCPT ); Thu, 7 Jun 2018 07:06:23 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20180607110621euoutp0282c6f1ebddd0629536c0d9c6bcf5bb9f~13Al6XUiy2943629436euoutp02e; Thu, 7 Jun 2018 11:06:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180607110621euoutp0282c6f1ebddd0629536c0d9c6bcf5bb9f~13Al6XUiy2943629436euoutp02e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1528369581; bh=bBNZo6MOYTz7gricZRAKnzAyGKAT3xFkljLldm/ITqE=; h=From:To:Cc:Subject:Date:In-reply-to:References:From; b=s1yNaEu2zfp9JbfAYUKxM+FepuQJBROs0lcZcOLNkgDWr6tPxhNzCvBfj1B1+Zo/W jEmsKTFDvVMmRWSztXCf/VucwhihAzMh147YBrGOZ++2BQlw7ko3YyfJAjNSmLDAmT dz4XL1llc85z9O4eD5ioFmSuYg0XEftXPWC+dVys= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20180607110621eucas1p11c10a2659e138887c0ad8858a87cc4ed~13AlcoXGE2075920759eucas1p1z; Thu, 7 Jun 2018 11:06:21 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id E0.A6.17380.CA1191B5; Thu, 7 Jun 2018 12:06:21 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20180607110620eucas1p1b43ac889bab07152bc20b97116b7ade4~13AksvbTX0961309613eucas1p1S; Thu, 7 Jun 2018 11:06:20 +0000 (GMT) X-AuditID: cbfec7f4-6f9ff700000043e4-75-5b1911ac65ee Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id AF.BB.04183.CA1191B5; Thu, 7 Jun 2018 12:06:20 +0100 (BST) Received: from AMDC2765.digital.local ([106.116.147.25]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0P9Y0097E9IGLAA0@eusync1.samsung.com>; Thu, 07 Jun 2018 12:06:20 +0100 (BST) From: Marek Szyprowski To: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Inki Dae , Seung-Woo Kim , Bartlomiej Zolnierkiewicz , Andrzej Pietrasiewicz Subject: [PATCH 2/9] drm/exynos: rotator: Fix DRM_MODE_REFLECT_{X,Y} interpretation Date: Thu, 07 Jun 2018 13:06:07 +0200 Message-id: <20180607110614.335-3-m.szyprowski@samsung.com> X-Mailer: git-send-email 2.17.1 In-reply-to: <20180607110614.335-1-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsWy7djP87prBSWjDRYdZLKY9bKdxWLjjPWs Fle+vmezmHR/AovFjPP7mCzWHrnLbjFj8ks2B3aP+93HmTz6tqxi9Pi8SS6AOYrLJiU1J7Ms tUjfLoEr4+XXRSwFV9grJs1Zx9rAeJKti5GTQ0LARGLH0/NMXYxcHEICKxgl1r75wgzhfGaU 2P3lEzNM1fQH11hAbCGBZYwSPZOKIYoamCTuTpzLDpJgEzCU6HrbBTZWRMBNounwTFaQImaB x0Bjd28GKxIWCJW4fuIGWBGLgKrExVfNYDavgLXE9LVLmCC2yUus3nAAbDOngI3E+WWbwO6T EPjKKjHn/DeoIheJrXM/Q50nLPHq+BZ2CFtG4vLkbhaIhmZGifYZs9ghnB5Gia1zdkC9bS1x +PhFVhCbWYBPYtK26UCTOIDivBIdbUIQJR4SWx7fgoZMP6NE47WfTBMYJRcwMqxiFE8tLc5N Ty02ykst1ytOzC0uzUvXS87P3cQIjLjT/45/2cG460/SIUYBDkYlHt6G++LRQqyJZcWVuYcY JTiYlUR4Ey+JRQvxpiRWVqUW5ccXleakFh9ilOZgURLnjdOoixISSE8sSc1OTS1ILYLJMnFw SjUwTvKZlrGeTyGpeeakzfO7Q9tzLn/2j/jjk//D67GbaotYyeXSVp5XPV8l1tyzn2mZfOXU 1f3nfA4XMx/lt97omfCHT+vN5WelVzclmk7n1/u4Jv4625Lcicd2pwmvcamxvOPUOfmYYEqr 7f17h4sZdwmnFTOJWM/3eX1eef50xf283/x5mf/uVWIpzkg01GIuKk4EAOGat2y0AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHJMWRmVeSWpSXmKPExsVy+t/xy7prBCWjDTadlbKY9bKdxWLjjPWs Fle+vmezmHR/AovFjPP7mCzWHrnLbjFj8ks2B3aP+93HmTz6tqxi9Pi8SS6AOYrLJiU1J7Ms tUjfLoEr4+XXRSwFV9grJs1Zx9rAeJKti5GTQ0LARGL6g2ssXYxcHEICSxglpi07xQrhNDFJ PFxwkBWkik3AUKLrbRdYh4iAm0TT4ZlgRcwCjxklPm47BVYkLBAqcf3EDbAiFgFViYuvmsFs XgFrielrlzBBrJOXWL3hADOIzSlgI3F+2SawuBBQzdsHp9knMPIsYGRYxSiSWlqcm55bbKRX nJhbXJqXrpecn7uJERgq24793LKDsetd8CFGAQ5GJR7eGw/Fo4VYE8uKK3MPMUpwMCuJ8CZe EosW4k1JrKxKLcqPLyrNSS0+xCjNwaIkznveoDJKSCA9sSQ1OzW1ILUIJsvEwSnVwCi4ZBmH wozY/BNMPieWf9aKUp3/K3zS3yNvTNMXW6coGCVlBXDE/MxaaNzXoVL1+etiO+/5r27Jvv7q e3hB5gZflVUHI89MSFFn0V3flHpvQaEaQ+D3uCnGqTOZFvHd7/k1IYTxbYiiyuSg0JbgQ6sX awv+2G9R9+1y9K/5Qa53Aoxf/6qSKlRiKc5INNRiLipOBADYqLKYEQIAAA== X-CMS-MailID: 20180607110620eucas1p1b43ac889bab07152bc20b97116b7ade4 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180607110620eucas1p1b43ac889bab07152bc20b97116b7ade4 References: <20180607110614.335-1-m.szyprowski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Horizontal (DRM_MODE_REFLECT_Y) and vertical (DMR_MODE_REFLECT_Y) flip were swapped in Rotator driver. Fix this by swapping code for interpreting them. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_drm_rotator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c b/drivers/gpu/drm/exynos/exynos_drm_rotator.c index 1a76dd3d52e1..a820a68429b9 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_rotator.c +++ b/drivers/gpu/drm/exynos/exynos_drm_rotator.c @@ -168,9 +168,9 @@ static void rotator_dst_set_transf(struct rot_context *rot, val &= ~ROT_CONTROL_FLIP_MASK; if (rotation & DRM_MODE_REFLECT_X) - val |= ROT_CONTROL_FLIP_HORIZONTAL; - if (rotation & DRM_MODE_REFLECT_Y) val |= ROT_CONTROL_FLIP_VERTICAL; + if (rotation & DRM_MODE_REFLECT_Y) + val |= ROT_CONTROL_FLIP_HORIZONTAL; val &= ~ROT_CONTROL_ROT_MASK;