diff mbox series

[2/2] usb: dwc3-exynos: add support for ExynosAutov920

Message ID 20250514140741.415981-3-pritam.sutar@samsung.com
State New
Headers show
Series initial usb support for ExynosAutov920 soc | expand

Commit Message

Pritam Manohar Sutar May 14, 2025, 2:07 p.m. UTC
This SoC has a DWC3 compatible controllers. It needs "ref" and
"susp_clk" for it's operation.

Add required changes in exynos dwc3 glue layer to support this SoC.

Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
---
 drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Thinh Nguyen May 14, 2025, 10:48 p.m. UTC | #1
On Wed, May 14, 2025, Pritam Manohar Sutar wrote:
> This SoC has a DWC3 compatible controllers. It needs "ref" and
> "susp_clk" for it's operation.
> 
> Add required changes in exynos dwc3 glue layer to support this SoC.
> 
> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> ---
>  drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
> index 20abc6a4e824..a8f97d2b31ae 100644
> --- a/drivers/usb/dwc3/dwc3-exynos.c
> +++ b/drivers/usb/dwc3/dwc3-exynos.c
> @@ -187,6 +187,12 @@ static const struct dwc3_exynos_driverdata gs101_drvdata = {
>  	.suspend_clk_idx = 1,
>  };
>  
> +static const struct dwc3_exynos_driverdata exynosautov920_drvdata = {
> +	.clk_names = { "ref", "susp_clk"},
> +	.num_clks = 2,
> +	.suspend_clk_idx = 1,
> +};
> +
>  static const struct of_device_id exynos_dwc3_match[] = {
>  	{
>  		.compatible = "samsung,exynos2200-dwusb3",
> @@ -209,6 +215,9 @@ static const struct of_device_id exynos_dwc3_match[] = {
>  	}, {
>  		.compatible = "google,gs101-dwusb3",
>  		.data = &gs101_drvdata,
> +	}, {
> +		.compatible = "samsung,exynosautov920-dwusb3",
> +		.data = &exynosautov920_drvdata,

Would be nice to group this compatible string along with the other
samsung compatibles above and in order.

Regardless,

Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

BR,
Thinh

>  	}, {
>  	}
>  };
> -- 
> 2.34.1
>
Alim Akhtar May 15, 2025, 9:30 a.m. UTC | #2
Hi Pritam

> -----Original Message-----
> From: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> Sent: Wednesday, May 14, 2025 7:38 PM
> To: pritam.sutar@samsung.com; gregkh@linuxfoundation.org;
> robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> 
[snip]
>  static const struct of_device_id exynos_dwc3_match[] = {
>  	{
>  		.compatible = "samsung,exynos2200-dwusb3", @@ -209,6
> +215,9 @@ static const struct of_device_id exynos_dwc3_match[] = {
>  	}, {
>  		.compatible = "google,gs101-dwusb3",
>  		.data = &gs101_drvdata,
> +	}, {
> +		.compatible = "samsung,exynosautov920-dwusb3",
> +		.data = &exynosautov920_drvdata,

Should go below " samsung,exynos2200-dwusb3" entry (as already pointed by Thinh)
With that fixed

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
diff mbox series

Patch

diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
index 20abc6a4e824..a8f97d2b31ae 100644
--- a/drivers/usb/dwc3/dwc3-exynos.c
+++ b/drivers/usb/dwc3/dwc3-exynos.c
@@ -187,6 +187,12 @@  static const struct dwc3_exynos_driverdata gs101_drvdata = {
 	.suspend_clk_idx = 1,
 };
 
+static const struct dwc3_exynos_driverdata exynosautov920_drvdata = {
+	.clk_names = { "ref", "susp_clk"},
+	.num_clks = 2,
+	.suspend_clk_idx = 1,
+};
+
 static const struct of_device_id exynos_dwc3_match[] = {
 	{
 		.compatible = "samsung,exynos2200-dwusb3",
@@ -209,6 +215,9 @@  static const struct of_device_id exynos_dwc3_match[] = {
 	}, {
 		.compatible = "google,gs101-dwusb3",
 		.data = &gs101_drvdata,
+	}, {
+		.compatible = "samsung,exynosautov920-dwusb3",
+		.data = &exynosautov920_drvdata,
 	}, {
 	}
 };