From patchwork Wed Jun 4 15:25:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 894657 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0BCD1C4A20 for ; Wed, 4 Jun 2025 15:25:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749050755; cv=none; b=Amlakc9Bx/uTWeg8RUxGcES4O7X6q1DZdFLrrDT+R38NagrB+vdw2ISGOIUQmPEnUgzPkETAfY4qY+x1KaWQTx1fkuAwAUr6yaugnzSmNiSprt492mk2r5tzj99ZQim+Tn/XsSx4WXxYNljwHES8VblXXsFCriZASSbvkVpdYSk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749050755; c=relaxed/simple; bh=c2aRLM4UNSTnoEX6tceyJE+UXM8XBojhYH6J3V4X4cc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DqXwJPZYK1LBw9EsG6DB7LWUWZe1h5J5Xhx/8v9zCar7ljptB5OmjJ3GgiTEzwJILY48Yg9tCphBbnkeuBG/Wz+chaEe/Lo4CNaroZ7p3LLn2svv7a4e291am3Ig8ZAQhODdamslh++iS3Qmiu4JdY/D5+Ntf599lHlDbFi0/Jk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RCTdkX5y; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RCTdkX5y" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-60461fc88d7so14038361a12.0 for ; Wed, 04 Jun 2025 08:25:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749050751; x=1749655551; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Nr/ud4zCPtVSNmlxUwtSLJlr6giftd88C51EN2S0gME=; b=RCTdkX5y6y61cZ1/PjbmEFR4csWju1gNFmE54iz2BB5eDX4D1FXMr/SI6PQCIdqxJT SF412z/fJheyqeizghdYJMKsUFjck4D4FnZcP3RsxgMBhqj6Xv3+B3YsZqY4Z5f7VCvt dCaOUZ1RHULFMxVzzZdGyVZpeBDyS/8WKsyCbSvn3I+BcnuhTL4ZOyuI6bcUc9tisMr3 GN/zEaRCE95NokJO0KeXqcha40ceRDbwyZZ96PlgXAVNIJqvKuoF9U/2KhmFQ/8MPj4w Cfp7bHxSJjsjDpX9RZE4sYF5lP3NcxrXZGnlfTubwqgchwTOWE/fheqU3wasEaCzZBCq AZjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749050751; x=1749655551; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nr/ud4zCPtVSNmlxUwtSLJlr6giftd88C51EN2S0gME=; b=u+7Scn4OoJW32jGCcahxuaPoh+cQl7EecVEt02GlT8xz2hN0DqEtvNdu7gJsMr+mFI Ihmrgg8xlKIRlZLG0GmgMOGtoogrmczZ8PiNuMl9eDp+Lr5osixjNsruza2HKKS/lEUg oC99wSooLcuAHcbHfIrshZ24asFdDBa4gCRd6a7NlQ/LmBZ8L9cnYk7if1RQhliYqkwb YU6w/JqsM0sC6uzzv2WuGQbJ02EcSvhbiD4Yqbvk0nqd1IpIfDL3oYi96neGLd6P3gGL JOU2girYqLKWQY25YSn+2MdwMIkErI67+RJFTnvFeBS4QPJVbTKowH/9HSmDXMGfFi5M Ifaw== X-Forwarded-Encrypted: i=1; AJvYcCVT484qbqUai34zfzkERihRE+4W59iRxOOPozkvcfi2AWNFCbSqa3I6apmQKj1OI4CXhGZ/ddA94H6KteFn5HiEHQ==@vger.kernel.org X-Gm-Message-State: AOJu0YzRBXJvnKqkHzOZUJegrLVo0nRwD0fbQlDKoXRTwZS5mCxGax6e QEAS42jWOkuGILpTi7ZfvExyAuJiaciocJ+6IxmF4HKh+MKUwxyI0gdoSpx7cheiTLk= X-Gm-Gg: ASbGncvHIiYIngkuhCO3WoLwY4kLelbStI6KqYJqR7ZX98eHKsoGH060eEItaC1vxNT a50zr89Vi3iU5JllXoBkoMCnQe+pb48ZJKUin1fMd87tcF0CyOf4Bk6HTFCB3bqADi6jzhS01wC 3fS69DP1Btd/YvIl16q00Rrmpr/0Bj6exJCJzC0QIMImR7TxX26Q9tXnRxvIy16vPJt0f3HPURG FtmebnAjpm35Ksw9VWLZPU1zdu5bqh3zMxxVYCn83pjH0T5iODaEpHk5A5la0Esfh8/EoAU4lqx CZu4jfJAn4dptPS8sK/FIP5TtLEtKoI1/Lob94f2+zuIW+NXsksXBbESpphtn0SPCcieIYs5nuS BJWrFpGeW4TsWDNaHFsh0BJfjCnsimMosPM8= X-Google-Smtp-Source: AGHT+IFqvldrqbeuGwwG4MXV9h4Mso8s2QOVanNgW1TR6F0t21NbLRfi956cnkhEqPoH4VqrXxVIDA== X-Received: by 2002:a05:6402:40ca:b0:601:89d4:968e with SMTP id 4fb4d7f45d1cf-606f0ed4379mr2974440a12.27.1749050750975; Wed, 04 Jun 2025 08:25:50 -0700 (PDT) Received: from puffmais.c.googlers.com (140.20.91.34.bc.googleusercontent.com. [34.91.20.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-606ed984f63sm1051640a12.58.2025.06.04.08.25.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jun 2025 08:25:50 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 04 Jun 2025 16:25:49 +0100 Subject: [PATCH 10/17] regulator: s2mps11: use dev_err_probe() where appropriate Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250604-s2mpg1x-regulators-v1-10-6038740f49ae@linaro.org> References: <20250604-s2mpg1x-regulators-v1-0-6038740f49ae@linaro.org> In-Reply-To: <20250604-s2mpg1x-regulators-v1-0-6038740f49ae@linaro.org> To: Tudor Ambarus , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Lee Jones , Linus Walleij , Bartosz Golaszewski Cc: Peter Griffin , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, =?utf-8?q?Andr?= =?utf-8?q?=C3=A9_Draszik?= X-Mailer: b4 0.14.2 dev_err_probe() exists to simplify code and harmonise error messages, there's no reason not to use it here. While at it, harmonise some error messages to add regulator name and ID like in other messages in this driver, and update messages to be more similar to other child-drivers of this PMIC (e.g. RTC). Signed-off-by: AndrĂ© Draszik --- drivers/regulator/s2mps11.c | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index 1f51fbc6c7b6e158f9707c04d9f030b9eee5e842..30586e9884bfb998ff07e3148813344b307506c0 100644 --- a/drivers/regulator/s2mps11.c +++ b/drivers/regulator/s2mps11.c @@ -1249,9 +1249,9 @@ static int s2mps11_pmic_probe(struct platform_device *pdev) BUILD_BUG_ON(S2MPS_REGULATOR_MAX < ARRAY_SIZE(s2mpu05_regulators)); break; default: - dev_err(&pdev->dev, "Invalid device type: %u\n", - s2mps11->dev_type); - return -EINVAL; + return dev_err_probe(&pdev->dev, -ENODEV, + "Unsupported device type %d\n", + s2mps11->dev_type); } s2mps11->ext_control_gpiod = devm_kcalloc(&pdev->dev, rdev_num, @@ -1290,21 +1290,20 @@ static int s2mps11_pmic_probe(struct platform_device *pdev) devm_gpiod_unhinge(&pdev->dev, config.ena_gpiod); regulator = devm_regulator_register(&pdev->dev, ®ulators[i], &config); - if (IS_ERR(regulator)) { - dev_err(&pdev->dev, "regulator init failed for %d\n", - i); - return PTR_ERR(regulator); - } + if (IS_ERR(regulator)) + return dev_err_probe(&pdev->dev, PTR_ERR(regulator), + "regulator init failed for %d/%s\n", + regulators[i].id, + regulators[i].name); if (config.ena_gpiod) { ret = s2mps14_pmic_enable_ext_control(s2mps11, - regulator); - if (ret < 0) { - dev_err(&pdev->dev, - "failed to enable GPIO control over %s: %d\n", - regulator->desc->name, ret); - return ret; - } + regulator); + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, + "failed to enable GPIO control over %d/%s\n", + regulator->desc->id, + regulator->desc->name); } }