From patchwork Wed May 25 17:54:34 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kukjin Kim X-Patchwork-Id: 1617 Return-Path: Delivered-To: unknown Received: from imap.gmail.com (74.125.159.109) by localhost6.localdomain6 with IMAP4-SSL; 08 Jun 2011 14:53:36 -0000 Delivered-To: patches@linaro.org Received: by 10.52.181.230 with SMTP id dz6cs242173vdc; Wed, 25 May 2011 10:54:42 -0700 (PDT) Received: by 10.52.173.168 with SMTP id bl8mr1982682vdc.106.1306346081936; Wed, 25 May 2011 10:54:41 -0700 (PDT) Received: from mail-pz0-f50.google.com (mail-pz0-f50.google.com [209.85.210.50]) by mx.google.com with ESMTPS id n12si1545334vdu.133.2011.05.25.10.54.41 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 May 2011 10:54:41 -0700 (PDT) Received-SPF: pass (google.com: domain of kgene.kim@gmail.com designates 209.85.210.50 as permitted sender) client-ip=209.85.210.50; Authentication-Results: mx.google.com; spf=pass (google.com: domain of kgene.kim@gmail.com designates 209.85.210.50 as permitted sender) smtp.mail=kgene.kim@gmail.com; dkim=pass (test mode) header.i=@gmail.com Received: by pzk2 with SMTP id 2so4321547pzk.37 for ; Wed, 25 May 2011 10:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=tlf92NwSsS3xRX+nOY+fOacdDLUePr/fsXW9wHb5IPk=; b=MQMqkJM7XBAATxqyXCrKgqrQNQtxlyc3BaQR+kqVcaf3pT81yqdDuFWR0a9QvDxqt3 8hYNXILysV8S+q7EbC3MoRuyPensv/TWhw8xuzJEMwoatJwy/RzaF/XmS9V7b4LLQ9gw xsiZaDstKwQXuOAt7qRaD3zuFcpW4OC8y3rn4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=oPpUUC8YNxhzGB9KsYG4yOj7sb6WE7jpijAYi0NNYIWvRfBEbmekjn5kEJciYlpN7V ZryIw56uWM9VSKx2bCitKXr1m61aiBwKQ6oTCNFUwtD4orB3oC2eIFkS7I5+HDIUBs6Q XfF/Gzv0xBc1UXuId1RutOioMm/rna5De8nhI= Received: by 10.68.40.69 with SMTP id v5mr3515450pbk.148.1306346080135; Wed, 25 May 2011 10:54:40 -0700 (PDT) Received: from [192.168.1.104] ([216.239.45.19]) by mx.google.com with ESMTPS id q19sm5803452pbt.88.2011.05.25.10.54.38 (version=SSLv3 cipher=OTHER); Wed, 25 May 2011 10:54:38 -0700 (PDT) Sender: Kukjin Kim Message-ID: <4DDD425A.1070202@samsung.com> Date: Wed, 25 May 2011 10:54:34 -0700 From: Kukjin Kim User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Thunderbird/3.1.10 MIME-Version: 1.0 To: Angus Ainslie CC: linux-samsung-soc@vger.kernel.org, Giridhar Maruthy , samsung@lists.linaro.org, kgene.kim@samsung.com, patches@linaro.org, jassisinghbrar@gmail.com, lrg@slimlogic.co.uk, broonie@opensource.wolfsonmicro.com Subject: Re: [PATCH] ARM: EXYNOS4: Enable WM8994 MFD on I2S selection References: <1306298370-24997-1-git-send-email-angus.ainslie@linaro.org> In-Reply-To: <1306298370-24997-1-git-send-email-angus.ainslie@linaro.org> On 05/24/11 21:39, Angus Ainslie wrote: > From: Giridhar Maruthy > > Whenever I2S is selected, select MFD for WM8994 and I2C > to avoid manual enabling of the codec and I2C. > > Signed-off-by: Giridhar Maruthy > Signed-off-by: Angus Ainslie > --- > sound/soc/samsung/Kconfig | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > Hi Angus :) Hmm...first of all, should add proper maintainers in Cc. In this case, Jassi, Liam, and Mark should be added in Cc. (Cc'ed them) > diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig > index a3fdfb6..a80eeb1 100644 > --- a/sound/soc/samsung/Kconfig > +++ b/sound/soc/samsung/Kconfig > @@ -65,6 +65,9 @@ config SND_SOC_SAMSUNG_SMDK_WM8994 > tristate "SoC I2S Audio support for WM8994 on SMDK" > depends on SND_SOC_SAMSUNG&& (MACH_SMDKV310 || MACH_SMDKC210) > select SND_SOC_WM8994 > + select MFD_SUPPORT > + select I2C_S3C2410 > + select MFD_WM8994 I'm not sure about MFD configs, but if "select I2C_S3C2410" is required, it should be moved into regarding Kconfig of arch/arm, because it is related to dependency of ARCH. Maybe in this case, arch/arm/mach-exynos4/Kconfig? > select SND_SAMSUNG_I2S > help > Say Y if you want to add support for SoC audio on the SMDKs. diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig index e849f67..30b716e 100644 --- a/arch/arm/mach-exynos4/Kconfig +++ b/arch/arm/mach-exynos4/Kconfig @@ -12,6 +12,7 @@ if ARCH_EXYNOS4 config CPU_EXYNOS4210 bool select S3C_PL330_DMA + select I2C_S3C2410 help Enable EXYNOS4210 CPU support