mbox series

[v2,00/29] Fix a bunch more SCSI related W=1 warnings

Message ID 20200713074645.126138-1-lee.jones@linaro.org
Headers show
Series Fix a bunch more SCSI related W=1 warnings | expand

Message

Lee Jones July 13, 2020, 7:46 a.m. UTC
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Slowly working through the SCSI related ones.  There are many.

Change-log:

v1 => v2
 - Collected *-by tags
 - Squashed patch 13 => 11
   - Suggested by Johannes Thumshirn

Lee Jones (29):
  scsi: libfc: fc_exch: Supply some missing kerneldoc struct/function
    attributes/params
  include: scsi: scsi_transport_fc: Match HBA Attribute Length with
    HBAAPI V2.0 definitions
  scsi: libfc: fc_disc: trivial: Fix spelling mistake of 'discovery'
  scsi: fcoe: fcoe: Fix various kernel-doc infringements
  scsi: fcoe: fcoe_ctlr: Fix a myriad of documentation issues
  scsi: fcoe: fcoe_transport: Correct some kernel-doc issues
  scsi: bnx2fc: bnx2fc_fcoe: Repair a range of kerneldoc issues
  scsi: qedf: qedf_main: Demote obvious misuse of kerneldoc to standard
    comment blocks
  scsi: qedf: qedf_main: Remove set but not checked variable 'tmp'
  scsi: libfc: fc_lport: Repair function parameter documentation
  scsi: libfc: fc_rport: Fix a couple of misdocumented function
    parameters
  scsi: libfc: fc_fcp: Provide missing and repair existing function
    documentation
  scsi: bnx2fc: bnx2fc_hwi: Fix a couple  of bitrotted function
    documentation headers
  scsi: arcmsr: arcmsr_hba: Remove some set but unused variables
  scsi: arcmsr: arcmsr_hba: Make room for the trailing NULL, even if it
    is over-written
  scsi: qedf: qedf_io: Remove a whole host of unused variables
  scsi: bnx2fc: bnx2fc_tgt: Demote obvious misuse of kerneldoc to
    standard comment blocks
  scsi: aic7xxx: aic7xxx_osm: Remove unused variable 'tinfo'
  scsi: aic7xxx: aic7xxx_osm: Remove unused variable 'ahc'
  scsi: aic7xxx: aic7xxx_osm: Remove unused variable 'targ'
  scsi: aic7xxx: aic7xxx_osm: Fix 'amount_xferred' set but not used
    issue
  scsi: qedf: qedf_debugfs: Demote obvious misuse of kerneldoc to
    standard comment blocks
  scsi: aacraid: linit: Provide suggested curly braces around empty body
    of if()
  scsi: aacraid: linit: Fix a couple of small kerneldoc issues
  scsi: aic94xx: aic94xx_init: Demote seemingly unintentional kerneldoc
    header
  scsi: pm8001: pm8001_init: Demote obvious misuse of kerneldoc and
    update others
  scsi: aic94xx: aic94xx_hwi: Repair kerneldoc formatting error and
    remove extra param
  scsi: aacraid: aachba: Fix a bunch of function doc formatting errors
  scsi: qla4xxx: ql4_init: Provide a missing function param description
    and fix formatting

 drivers/scsi/aacraid/aachba.c       | 17 +++-------------
 drivers/scsi/aacraid/linit.c        |  6 +++---
 drivers/scsi/aic7xxx/aic7xxx_osm.c  | 13 ++----------
 drivers/scsi/aic94xx/aic94xx_hwi.c  |  3 +--
 drivers/scsi/aic94xx/aic94xx_init.c |  2 +-
 drivers/scsi/arcmsr/arcmsr_hba.c    | 31 ++++++++++++-----------------
 drivers/scsi/bnx2fc/bnx2fc_fcoe.c   | 18 ++++++++---------
 drivers/scsi/bnx2fc/bnx2fc_hwi.c    |  6 +++---
 drivers/scsi/bnx2fc/bnx2fc_tgt.c    |  7 +++----
 drivers/scsi/fcoe/fcoe.c            | 10 ++++------
 drivers/scsi/fcoe/fcoe_ctlr.c       | 26 ++++++++++++------------
 drivers/scsi/fcoe/fcoe_transport.c  |  4 +++-
 drivers/scsi/libfc/fc_disc.c        |  2 +-
 drivers/scsi/libfc/fc_exch.c        |  7 ++++++-
 drivers/scsi/libfc/fc_fcp.c         | 11 ++++++----
 drivers/scsi/libfc/fc_lport.c       |  7 +++++--
 drivers/scsi/libfc/fc_rport.c       |  4 ++--
 drivers/scsi/pm8001/pm8001_init.c   | 30 ++++++++++++++--------------
 drivers/scsi/qedf/qedf_debugfs.c    | 18 ++++++++---------
 drivers/scsi/qedf/qedf_io.c         | 30 ++++------------------------
 drivers/scsi/qedf/qedf_main.c       | 10 ++++------
 drivers/scsi/qla4xxx/ql4_init.c     |  7 ++++---
 include/scsi/fc/fc_ms.h             |  4 ++--
 23 files changed, 115 insertions(+), 158 deletions(-)

-- 
2.25.1

Comments

Martin K. Petersen July 15, 2020, 10:14 p.m. UTC | #1
On Mon, 13 Jul 2020 08:46:16 +0100, Lee Jones wrote:

> This set is part of a larger effort attempting to clean-up W=1

> kernel builds, which are currently overwhelmingly riddled with

> niggly little warnings.

> 

> Slowly working through the SCSI related ones.  There are many.

> 

> Change-log:

> 

> [...]


Applied to 5.9/scsi-queue, thanks!

[01/29] scsi: libfc: Supply some missing kerneldoc struct/function attributes/params
        https://git.kernel.org/mkp/scsi/c/74341d35b901
[02/29] scsi: scsi_transport_fc: Match HBA Attribute Length with HBAAPI V2.0 definitions
        https://git.kernel.org/mkp/scsi/c/e721eb0616f6
[03/29] scsi: libfc: trivial: Fix spelling mistake of 'discovery'
        https://git.kernel.org/mkp/scsi/c/ee9ec5c9af94
[04/29] scsi: fcoe: Fix various kernel-doc infringements
        https://git.kernel.org/mkp/scsi/c/54888649bec7
[05/29] scsi: fcoe: Fix a myriad of documentation issues
        https://git.kernel.org/mkp/scsi/c/3052652326dc
[06/29] scsi: fcoe: Correct some kernel-doc issues
        https://git.kernel.org/mkp/scsi/c/f2db5efefa89
[07/29] scsi: bnx2fc: Repair a range of kerneldoc issues
        https://git.kernel.org/mkp/scsi/c/ca63d8e2e9ef
[08/29] scsi: qedf: Demote obvious misuse of kerneldoc to standard comment blocks
        https://git.kernel.org/mkp/scsi/c/a9d4aece2255
[09/29] scsi: qedf: Remove set but not checked variable 'tmp'
        https://git.kernel.org/mkp/scsi/c/c6e2f4bd794a
[10/29] scsi: libfc: Repair function parameter documentation
        https://git.kernel.org/mkp/scsi/c/9865a04d528c
[11/29] scsi: libfc: Fix a couple of misdocumented function parameters
        https://git.kernel.org/mkp/scsi/c/f636acae8d0d
[12/29] scsi: libfc: Provide missing and repair existing function documentation
        https://git.kernel.org/mkp/scsi/c/ebb40ab68118
[13/29] scsi: bnx2fc: Fix a couple of bitrotted function documentation headers
        https://git.kernel.org/mkp/scsi/c/4db2ac3e0392
[14/29] scsi: arcmsr: Remove some set but unused variables
        https://git.kernel.org/mkp/scsi/c/18bc435e0a1d
[16/29] scsi: qedf: Remove a whole host of unused variables
        https://git.kernel.org/mkp/scsi/c/50efc51cb9ff
[17/29] scsi: bnx2fc: Demote obvious misuse of kerneldoc to standard comment blocks
        https://git.kernel.org/mkp/scsi/c/2bd92b33643e
[18/29] scsi: aic7xxx: Remove unused variable 'tinfo'
        https://git.kernel.org/mkp/scsi/c/e3f58eeedb55
[19/29] scsi: aic7xxx: Remove unused variable 'ahc'
        https://git.kernel.org/mkp/scsi/c/614fc2f9883e
[20/29] scsi: aic7xxx: Remove unused variable 'targ'
        https://git.kernel.org/mkp/scsi/c/7097a517446f
[21/29] scsi: aic7xxx: Fix 'amount_xferred' set but not used issue
        https://git.kernel.org/mkp/scsi/c/aa89d74e040a
[22/29] scsi: qedf: Demote obvious misuse of kerneldoc to standard comment blocks
        https://git.kernel.org/mkp/scsi/c/ce7e0a84e5d7
[23/29] scsi: aacraid: Provide suggested curly braces around empty body of if()
        https://git.kernel.org/mkp/scsi/c/8558d5a4f38c
[24/29] scsi: aacraid: Fix a couple of small kerneldoc issues
        https://git.kernel.org/mkp/scsi/c/00a72e8cd267
[25/29] scsi: aic94xx: Demote seemingly unintentional kerneldoc header
        https://git.kernel.org/mkp/scsi/c/2862a3a26c2d
[26/29] scsi: pm8001: Demote obvious misuse of kerneldoc and update others
        https://git.kernel.org/mkp/scsi/c/e802fc43ba36
[27/29] scsi: aic94xx: Repair kerneldoc formatting error and remove extra param
        https://git.kernel.org/mkp/scsi/c/bb458974e063
[28/29] scsi: aacraid: Fix a bunch of function doc formatting errors
        https://git.kernel.org/mkp/scsi/c/e7eb414c653d
[29/29] scsi: qla4xxx: Provide a missing function param description and fix formatting
        https://git.kernel.org/mkp/scsi/c/7ec772d0c3e6

-- 
Martin K. Petersen	Oracle Linux Engineering