mbox series

[v7,00/11] Add Host control mode to HPB

Message ID 20210331073952.102162-1-avri.altman@wdc.com
Headers show
Series Add Host control mode to HPB | expand

Message

Avri Altman March 31, 2021, 7:39 a.m. UTC 
v6 -> v7:
 - attend CanG's comments
 - add one more patch to transform set_dirty to iterate_rgn
 - rebase on Daejun's v32

v5 -> v6:
 - attend CanG's comments
 - rebase on Daejun's v29

v4 -> v5:
 - attend Daejun's comments
 - Control the number of inflight map requests

v3 -> v4:
 - rebase on Daejun's v25

v2 -> v3:
 - Attend Greg's and Can's comments
 - rebase on Daejun's v21

v1 -> v2:
 - attend Greg's and Daejun's comments
 - add patch 9 making host mode parameters configurable
 - rebase on Daejun's v19


The HPB spec defines 2 control modes - device control mode and host
control mode. In oppose to device control mode, in which the host obey
to whatever recommendation received from the device - In host control
mode, the host uses its own algorithms to decide which regions should
be activated or inactivated.

We kept the host managed heuristic simple and concise.

Aside from adding a by-spec functionality, host control mode entails
some further potential benefits: makes the hpb logic transparent and
readable, while allow tuning / scaling its various parameters, and
utilize system-wide info to optimize HPB potential.

This series is based on Samsung's V32 device-control HPB2.0 driver

This version was tested on Galaxy S20, and Xiaomi Mi10 pro.
Your meticulous review and testing is mostly welcome and appreciated.

Thanks,
Avri


Avri Altman (11):
  scsi: ufshpb: Cache HPB Control mode on init
  scsi: ufshpb: Add host control mode support to rsp_upiu
  scsi: ufshpb: Transform set_dirty to iterate_rgn
  scsi: ufshpb: Add reads counter
  scsi: ufshpb: Make eviction depends on region's reads
  scsi: ufshpb: Region inactivation in host mode
  scsi: ufshpb: Add hpb dev reset response
  scsi: ufshpb: Add "Cold" regions timer
  scsi: ufshpb: Limit the number of inflight map requests
  scsi: ufshpb: Add support for host control mode
  scsi: ufshpb: Make host mode parameters configurable

 Documentation/ABI/testing/sysfs-driver-ufs |  84 ++-
 drivers/scsi/ufs/ufshcd.h                  |   2 +
 drivers/scsi/ufs/ufshpb.c                  | 568 ++++++++++++++++++++-
 drivers/scsi/ufs/ufshpb.h                  |  44 ++
 4 files changed, 663 insertions(+), 35 deletions(-)

Comments

Daejun Park April 5, 2021, 9:29 a.m. UTC | #1 
> The HPB spec defines 2 control modes - device control mode and host

> control mode. In oppose to device control mode, in which the host obey

> to whatever recommendation received from the device - In host control

> mode, the host uses its own algorithms to decide which regions should

> be activated or inactivated.

>  

> We kept the host managed heuristic simple and concise.

>  

> Aside from adding a by-spec functionality, host control mode entails

> some further potential benefits: makes the hpb logic transparent and

> readable, while allow tuning / scaling its various parameters, and

> utilize system-wide info to optimize HPB potential.

>  

> This series is based on Samsung's V32 device-control HPB2.0 driver

>  

> This version was tested on Galaxy S20, and Xiaomi Mi10 pro.

> Your meticulous review and testing is mostly welcome and appreciated.

>  

> Thanks,

> Avri

>  

>  

> Avri Altman (11):

>   scsi: ufshpb: Cache HPB Control mode on init

>   scsi: ufshpb: Add host control mode support to rsp_upiu

>   scsi: ufshpb: Transform set_dirty to iterate_rgn

>   scsi: ufshpb: Add reads counter

>   scsi: ufshpb: Make eviction depends on region's reads

>   scsi: ufshpb: Region inactivation in host mode

>   scsi: ufshpb: Add hpb dev reset response

>   scsi: ufshpb: Add "Cold" regions timer

>   scsi: ufshpb: Limit the number of inflight map requests

>   scsi: ufshpb: Add support for host control mode

>   scsi: ufshpb: Make host mode parameters configurable

>  

>  Documentation/ABI/testing/sysfs-driver-ufs |  84 ++-

>  drivers/scsi/ufs/ufshcd.h                  |   2 +

>  drivers/scsi/ufs/ufshpb.c                  | 568 ++++++++++++++++++++-

>  drivers/scsi/ufs/ufshpb.h                  |  44 ++

>  4 files changed, 663 insertions(+), 35 deletions(-)

>  


The patches in this series look good to me.

Reviewed-by: Daejun Park <daejun7.park@samsung.com>