mbox series

[v2,00/10] qla2xxx driver bug fixes

Message ID 20210908164622.19240-1-njavali@marvell.com
Headers show
Series qla2xxx driver bug fixes | expand

Message

Nilesh Javali Sept. 8, 2021, 4:46 p.m. UTC 
Martin,

Please apply the qla2xxx driver bug fixes to the scsi tree at your
earliest convenience.

v2:
- Added Fixes and Cc tags for few fixes
- Replace hb with heartbeat to make more readable
- Added Reviewed-by tag

Thanks,
Nilesh

Arun Easi (2):
  qla2xxx: Fix crash in NVME abort path
  qla2xxx: Fix kernel crash when accessing port_speed sysfs file

Bikash Hazarika (1):
  qla2xxx: Add support for mailbox passthru

Manish Rangankar (1):
  qla2xxx: Move heart beat handling from dpc thread to workqueue

Nilesh Javali (1):
  qla2xxx: Update version to 10.02.07.100-k

Quinn Tran (2):
  qla2xxx: edif: Use link event to wake up app
  qla2xxx: Fix use after free in eh_abort path

Saurav Kashyap (2):
  qla2xxx: Display 16G only as supported speeds for 3830c card
  qla2xxx: Check for firmware capability before creating QPair

Shreyas Deodhar (1):
  qla2xxx: Call process_response_queue() in Tx path

 drivers/scsi/qla2xxx/qla_attr.c    | 24 +++++++-
 drivers/scsi/qla2xxx/qla_bsg.c     | 48 ++++++++++++++++
 drivers/scsi/qla2xxx/qla_bsg.h     |  7 +++
 drivers/scsi/qla2xxx/qla_def.h     |  4 +-
 drivers/scsi/qla2xxx/qla_gbl.h     |  4 ++
 drivers/scsi/qla2xxx/qla_gs.c      |  3 +-
 drivers/scsi/qla2xxx/qla_init.c    | 17 +++---
 drivers/scsi/qla2xxx/qla_mbx.c     | 33 +++++++++++
 drivers/scsi/qla2xxx/qla_nvme.c    | 20 ++++++-
 drivers/scsi/qla2xxx/qla_os.c      | 90 +++++++++++++++---------------
 drivers/scsi/qla2xxx/qla_version.h |  6 +-
 11 files changed, 193 insertions(+), 63 deletions(-)


base-commit: 9b5ac8ab4e8bf5636d1d425aee68ddf45af12057

Comments

Nilesh Javali Sept. 14, 2021, 7:15 a.m. UTC | #1 
Bart,

> -----Original Message-----

> From: Bart Van Assche <bvanassche@acm.org>

> Sent: Wednesday, September 8, 2021 11:58 PM

> To: Nilesh Javali <njavali@marvell.com>; martin.petersen@oracle.com

> Cc: linux-scsi@vger.kernel.org; GR-QLogic-Storage-Upstream <GR-QLogic-

> Storage-Upstream@marvell.com>; djeffery@redhat.com;

> loberman@redhat.com

> Subject: [EXT] Re: [PATCH v2 01/10] qla2xxx: Add support for mailbox

> passthru

> 

> External Email

> 

> ----------------------------------------------------------------------

> On 9/8/21 9:46 AM, Nilesh Javali wrote:

> > +struct qla_mbx_passthru {

> > +	uint16_t reserved1[2];

> > +	uint16_t mbx_in[32];

> > +	uint16_t mbx_out[32];

> > +	uint32_t reserved2[16];

> > +} __packed;

> 

> Why does this data structure start with 4 reserved bytes?


Specifically, more than the driver, the reserved bytes would be used by the application,
and driver uses only the mbx_in and mbx_out fields to access 32 register content.

Thanks,
Nilesh
Martin K. Petersen Sept. 15, 2021, 2:59 a.m. UTC | #2 
Nilesh,

> Please apply the qla2xxx driver bug fixes to the scsi tree at your

> earliest convenience.


Applied to 5.16/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering
Martin K. Petersen Sept. 22, 2021, 4:45 a.m. UTC | #3 
On Wed, 8 Sep 2021 09:46:12 -0700, Nilesh Javali wrote:

> Martin,

> 

> Please apply the qla2xxx driver bug fixes to the scsi tree at your

> earliest convenience.

> 

> v2:

> - Added Fixes and Cc tags for few fixes

> - Replace hb with heartbeat to make more readable

> - Added Reviewed-by tag

> 

> [...]


Applied to 5.16/scsi-queue, thanks!

[01/10] qla2xxx: Add support for mailbox passthru
        https://git.kernel.org/mkp/scsi/c/9e1c3206960f
[02/10] qla2xxx: Display 16G only as supported speeds for 3830c card
        https://git.kernel.org/mkp/scsi/c/52cca50d35f8
[03/10] qla2xxx: Check for firmware capability before creating QPair
        https://git.kernel.org/mkp/scsi/c/8192817efbc3
[04/10] qla2xxx: Fix crash in NVME abort path
        https://git.kernel.org/mkp/scsi/c/e6e22e6cc296
[05/10] qla2xxx: edif: Use link event to wake up app
        https://git.kernel.org/mkp/scsi/c/527d46e0b014
[06/10] qla2xxx: Fix kernel crash when accessing port_speed sysfs file
        https://git.kernel.org/mkp/scsi/c/3ef68d4f0c9e
[07/10] qla2xxx: Call process_response_queue() in Tx path
        https://git.kernel.org/mkp/scsi/c/38c61709e662
[08/10] qla2xxx: Move heart beat handling from dpc thread to workqueue
        https://git.kernel.org/mkp/scsi/c/3a4e1f3b3a3c
[09/10] qla2xxx: Fix use after free in eh_abort path
        https://git.kernel.org/mkp/scsi/c/3d33b303d4f3
[10/10] qla2xxx: Update version to 10.02.07.100-k
        https://git.kernel.org/mkp/scsi/c/b0fe235dad77

-- 
Martin K. Petersen	Oracle Linux Engineering