mbox series

[v4,00/17] UFS patches for kernel v5.17

Message ID 20211203231950.193369-1-bvanassche@acm.org
Headers show
Series UFS patches for kernel v5.17 | expand

Message

Bart Van Assche Dec. 3, 2021, 11:19 p.m. UTC 
Hi Martin,

This patch series includes the following changes:
- Fix a deadlock in the UFS error handler.
- Add polling support in the UFS driver.
- Several smaller fixes for the UFS driver.

Please consider these UFS driver kernel patches for kernel v5.17.

Thanks,

Bart.

Changes compared to v3:
- Dropped patch "scsi: core: Fix a race between scsi_done() and
  scsi_times_out()" since the conversation around that patch is still ongoing.
- Added patch "scsi: ufs: Remove hba->cmd_queue".
- Modified patch "scsi: ufs: Optimize the command queueing code".

Changes compared to v2:
- Dropped SCSI core patches that add support for internal commands.
- Reworked patch "Fix a deadlock in the error handler" such that it uses a
  reserved tag as proposed by Adrian.
- Split patch "ufs: Introduce ufshcd_release_scsi_cmd()" into two patches.

Changes compared to v1:
- Add internal command support to the SCSI core.
- Reworked patch "ufs: Optimize the command queueing code".

Bart Van Assche (17):
  scsi: core: Fix scsi_device_max_queue_depth()
  scsi: ufs: Rename a function argument
  scsi: ufs: Remove is_rpmb_wlun()
  scsi: ufs: Remove the sdev_rpmb member
  scsi: ufs: Remove dead code
  scsi: ufs: Fix race conditions related to driver data
  scsi: ufs: Remove ufshcd_any_tag_in_use()
  scsi: ufs: Rework ufshcd_change_queue_depth()
  scsi: ufs: Fix a deadlock in the error handler
  scsi: ufs: Remove hba->cmd_queue
  scsi: ufs: Remove the 'update_scaling' local variable
  scsi: ufs: Introduce ufshcd_release_scsi_cmd()
  scsi: ufs: Improve SCSI abort handling further
  scsi: ufs: Fix a kernel crash during shutdown
  scsi: ufs: Stop using the clock scaling lock in the error handler
  scsi: ufs: Optimize the command queueing code
  scsi: ufs: Implement polling support

 drivers/scsi/scsi.c                |   4 +-
 drivers/scsi/ufs/tc-dwc-g210-pci.c |   1 -
 drivers/scsi/ufs/ufs-exynos.c      |   4 +-
 drivers/scsi/ufs/ufshcd-pci.c      |   2 -
 drivers/scsi/ufs/ufshcd-pltfrm.c   |   2 -
 drivers/scsi/ufs/ufshcd.c          | 300 ++++++++++++++++-------------
 drivers/scsi/ufs/ufshcd.h          |   9 +-
 7 files changed, 174 insertions(+), 148 deletions(-)

Comments

Martin K. Petersen Dec. 7, 2021, 3:31 a.m. UTC | #1 
Bart,

> This patch series includes the following changes:
> - Fix a deadlock in the UFS error handler.
> - Add polling support in the UFS driver.
> - Several smaller fixes for the UFS driver.

Applied to 5.17/scsi-staging, thanks!
Martin K. Petersen Dec. 14, 2021, 4:40 a.m. UTC | #2 
On Fri, 3 Dec 2021 15:19:33 -0800, Bart Van Assche wrote:

> This patch series includes the following changes:
> - Fix a deadlock in the UFS error handler.
> - Add polling support in the UFS driver.
> - Several smaller fixes for the UFS driver.
> 
> Please consider these UFS driver kernel patches for kernel v5.17.
> 
> [...]

Applied to 5.17/scsi-queue, thanks!

[01/17] scsi: core: Fix scsi_device_max_queue_depth()
        https://git.kernel.org/mkp/scsi/c/4bc3bffc1a88
[02/17] scsi: ufs: Rename a function argument
        https://git.kernel.org/mkp/scsi/c/b427609e11ee
[03/17] scsi: ufs: Remove is_rpmb_wlun()
        https://git.kernel.org/mkp/scsi/c/d656dc9b0b79
[04/17] scsi: ufs: Remove the sdev_rpmb member
        https://git.kernel.org/mkp/scsi/c/59830c095cf0
[05/17] scsi: ufs: Remove dead code
        https://git.kernel.org/mkp/scsi/c/d77ea8226b3b
[06/17] scsi: ufs: Fix race conditions related to driver data
        https://git.kernel.org/mkp/scsi/c/21ad0e49085d
[07/17] scsi: ufs: Remove ufshcd_any_tag_in_use()
        https://git.kernel.org/mkp/scsi/c/bd0b35383193
[08/17] scsi: ufs: Rework ufshcd_change_queue_depth()
        https://git.kernel.org/mkp/scsi/c/fc21da8a840a
[09/17] scsi: ufs: Fix a deadlock in the error handler
        https://git.kernel.org/mkp/scsi/c/945c3cca05d7
[10/17] scsi: ufs: Remove hba->cmd_queue
        https://git.kernel.org/mkp/scsi/c/511a083b8b6b
[11/17] scsi: ufs: Remove the 'update_scaling' local variable
        https://git.kernel.org/mkp/scsi/c/3eb9dcc027e2
[12/17] scsi: ufs: Introduce ufshcd_release_scsi_cmd()
        https://git.kernel.org/mkp/scsi/c/6f8dafdee6ae
[13/17] scsi: ufs: Improve SCSI abort handling further
        https://git.kernel.org/mkp/scsi/c/1fbaa02dfd05
[14/17] scsi: ufs: Fix a kernel crash during shutdown
        https://git.kernel.org/mkp/scsi/c/3489c34bd02b
[15/17] scsi: ufs: Stop using the clock scaling lock in the error handler
        https://git.kernel.org/mkp/scsi/c/5675c381ea51
[16/17] scsi: ufs: Optimize the command queueing code
        https://git.kernel.org/mkp/scsi/c/8d077ede48c1
[17/17] scsi: ufs: Implement polling support
        https://git.kernel.org/mkp/scsi/c/eaab9b573054
Avri Altman Dec. 14, 2021, 7:14 a.m. UTC | #3 
Martin hi,

> On Fri, 3 Dec 2021 15:19:33 -0800, Bart Van Assche wrote:
> 
> > This patch series includes the following changes:
> > - Fix a deadlock in the UFS error handler.
> > - Add polling support in the UFS driver.
> > - Several smaller fixes for the UFS driver.
> >
> > Please consider these UFS driver kernel patches for kernel v5.17.
> >
> > [...]
> 
> Applied to 5.17/scsi-queue, thanks!
16/17 is causing a deadlock - maybe you can wait for v5 that will fix it?

Thanks,
Avri
Martin K. Petersen Dec. 14, 2021, 7:18 a.m. UTC | #4 
Avri,

> 16/17 is causing a deadlock - maybe you can wait for v5 that will fix
> it?

I'll just amend it.