| Message ID | 20221209-dt-binding-ufs-v4-0-14ced60f3d1b@fairphone.com |
|---|---|
| Headers | show |
| Series | Fix some issues in QCOM UFS bindings | expand |
On 26/06/2023 10:15, Luca Weiss wrote: > The code in ufs-qcom-ice.c needs the ICE reg to be named "ice". Add this > in the bindings so the existing dts can validate successfully. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Eric Biggers <ebiggers@google.com> > Reviewed-by: Iskren Chernev <me@iskren.info> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > index eb3de2fde6b0..b5fc686cb3a1 100644 > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > @@ -80,6 +80,10 @@ properties: > minItems: 1 > maxItems: 2 > > + reg-names: > + minItems: 1 > + maxItems: 2 > + > required-opps: > maxItems: 1 > > @@ -135,6 +139,8 @@ allOf: > reg: > minItems: 1 > maxItems: 1 > + reg-names: > + maxItems: 1 I see I reviewed, but I don't think the patch is correct. It allows any reg-names. I think my advice from v1 was not understood. The names should be defined in top-level. Best regards, Krzysztof
On Mon Jun 26, 2023 at 10:26 AM CEST, Krzysztof Kozlowski wrote: > On 26/06/2023 10:15, Luca Weiss wrote: > > The code in ufs-qcom-ice.c needs the ICE reg to be named "ice". Add this > > in the bindings so the existing dts can validate successfully. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Reviewed-by: Eric Biggers <ebiggers@google.com> > > Reviewed-by: Iskren Chernev <me@iskren.info> > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > --- > > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > index eb3de2fde6b0..b5fc686cb3a1 100644 > > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > @@ -80,6 +80,10 @@ properties: > > minItems: 1 > > maxItems: 2 > > > > + reg-names: > > + minItems: 1 > > + maxItems: 2 > > + > > required-opps: > > maxItems: 1 > > > > @@ -135,6 +139,8 @@ allOf: > > reg: > > minItems: 1 > > maxItems: 1 > > + reg-names: > > + maxItems: 1 > > I see I reviewed, but I don't think the patch is correct. It allows any > reg-names. I think my advice from v1 was not understood. The names > should be defined in top-level. Thanks for your review, I hope it's resolved in v5 of this series. Please check :) Regards Luca > > Best regards, > Krzysztof
This series has been pending for quite some time, please somebody pick this up. Also has plenty of reviews by now (3-4 for each patch which should be plenty). Validation will fail without patch 1/5 from [0] so this depends on that patch at least for the check. [0] https://lore.kernel.org/linux-arm-msm/20230623113009.2512206-2-abel.vesa@linaro.org/ Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- Changes in v4: - Pick up tags - Rebase on linux-next (again) - Link to v3: https://lore.kernel.org/r/20221209-dt-binding-ufs-v3-0-499dff23a03c@fairphone.com Changes in v3: - Drop applied patch - Pick up sm6115 patch from v5 https://lore.kernel.org/all/20221030094258.486428-2-iskren.chernev@gmail.com/ - Rebase on linux-next - Link to v2: https://lore.kernel.org/r/20221209-dt-binding-ufs-v2-0-dc7a04699579@fairphone.com Changes in v2: - Add new patch adding reg-names to sm6115 & rebase series on top of sm6115 addition - Fix binding example after sm8450 move, split this patch from original patch since it became too big - Move reg-names definition to top-level - Link to v1: https://lore.kernel.org/r/20221209-dt-binding-ufs-v1-0-8d502f0e18d5@fairphone.com --- Iskren Chernev (1): dt-bindings: ufs: qcom: Add sm6115 binding Luca Weiss (2): dt-bindings: ufs: qcom: Add reg-names property for ICE dt-bindings: ufs: qcom: Fix sm8450 bindings .../devicetree/bindings/ufs/qcom,ufs.yaml | 61 ++++++++++++++++++++-- 1 file changed, 56 insertions(+), 5 deletions(-) --- base-commit: 3178cc4b7c9de986d63383cb59ee6570347002db change-id: 20221209-dt-binding-ufs-2d7f64797ff2 Best regards,