mbox series

[v4,0/5] scsi: libsas: Some coding style fixes and cleanups

Message ID 20221214133808.1649122-1-yanaijie@huawei.com
Headers show
Series scsi: libsas: Some coding style fixes and cleanups | expand

Message

Jason Yan Dec. 14, 2022, 1:38 p.m. UTC
A few coding style fixes and cleanups. There should be no functional
changes in this series besides the debug log prints.

v1->v2:
  1. Drop patch #2 in v1.
  2. Other misc changes suggested by John.

v2->v3:
  1. Add John's tag for patch #1 #3 #5.
  2. /s/sata/SATA/
  3. Make a global macro for prints of CONFIG_SCSI_SAS_ATA=N

v3->v4:
  1. Add John and Jack's tag.
  2. Change the macro for prints of CONFIG_SCSI_SAS_ATA=N to a function.

Jason Yan (5):
  scsi: libsas: move sas_get_ata_command_set() up to save the
    declaration
  scsi: libsas: change the coding style of sas_discover_sata()
  scsi: libsas: remove useless dev_list delete in
    sas_ex_discover_end_dev()
  scsi: libsas: factor out sas_ata_add_dev()
  scsi: libsas: factor out sas_ex_add_dev()

 drivers/scsi/libsas/sas_ata.c      |  88 ++++++++++++++++----
 drivers/scsi/libsas/sas_discover.c |   6 --
 drivers/scsi/libsas/sas_expander.c | 125 ++++++++++-------------------
 include/scsi/libsas.h              |   1 -
 include/scsi/sas_ata.h             |  20 +++++
 5 files changed, 134 insertions(+), 106 deletions(-)

Comments

Martin K. Petersen Dec. 30, 2022, 9:05 p.m. UTC | #1
Jason,

> A few coding style fixes and cleanups. There should be no functional
> changes in this series besides the debug log prints.

Applied to 6.3/scsi-staging, thanks!