[v3,0/5] scsi: mpi3mr: fix issues found by KASAN

Message ID	20230110015538.201332-1-shinichiro.kawasaki@wdc.com
Headers	show Return-Path: <linux-scsi-owner@vger.kernel.org> IronPort-SDR: yzV/Qq/3DNOFqTRgIebmZm3sCVpWdyDwHt1FeOZdXb/ZmrQv0xVCNLV5nq7E/AmGox+YVB2FtG NmdQ7z295dxLvw0d1nih5PdZGdQ9Qou/uTROm8mxu72twxlZuZkg0l0RE2GbT5vaToLOQ09yDM rixNK3HkLhfN6wkGQ6QBMtznK2JOGB/xQuYb4neABsecy5b/X68H7Wwi11w+ryPnf4bHr8VtVc y9MeMQXkQge3U406UuOR0XBJUuuM/w5CxLTuO6gojQFmlTi31YqtT/yx9NyoEqlBuAWAJGE8bO +rs= IronPort-SDR: c9gcBu/BQ1w6z33nTxIQiBnxF6sRnFb+E/XUZApdiR1uyYDYjy7I3T1Oomyfo7aCxDhNcEe2zK fLme073P8h/OSvZankdePIiLpW1yVB4YLDjkeiLKKTFfudIiE+qoMK2AX9h4zV1vNGv7g9Cdg+ 8avWxNsVDSOVb01y4ogdNmf1rSynBJvcOmDMQJbc27lJnZLjAEKw9izL0EWsTKFpao2VqeQHOH qX94wMUB1Y9ksrreQM71POdAF1cpD9lDoiPcPf1nWyQaRipTCLltMqG1Yb1Y9WZa7/Vfq31iAU 15g= WDCIronportException: Internal From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> To: linux-scsi@vger.kernel.org, mpi3mr-linuxdrv.pdl@broadcom.com Cc: Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>, Kashyap Desai <kashyap.desai@broadcom.com>, Sumit Saxena <sumit.saxena@broadcom.com>, Sreekanth Reddy <sreekanth.reddy@broadcom.com>, "Martin K . Petersen" <martin.petersen@oracle.com>, Damien Le Moal <damien.lemoal@opensource.wdc.com>, Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> Subject: [PATCH v3 0/5] scsi: mpi3mr: fix issues found by KASAN Date: Tue, 10 Jan 2023 10:55:33 +0900 Message-Id: <20230110015538.201332-1-shinichiro.kawasaki@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	scsi: mpi3mr: fix issues found by KASAN \| expand [v3,0/5] scsi: mpi3mr: fix issues found by KASAN [v3,1/5] scsi: mpi3mr: remove unnecessary memcpy [v3,2/5] scsi: mpi3mr: fix calculation of valid entry length in alltgt_info [v3,3/5] scsi: mpi3mr: fix alltgt_info copy size [v3,4/5] scsi: mpi3mr: use number of bits to manage bitmap sizes [v3,5/5] scsi: mpi3mr: fix missing mrioc->evtack_cmds initialization

Message ID

20230110015538.201332-1-shinichiro.kawasaki@wdc.com

Headers

IronPort-SDR: 
 yzV/Qq/3DNOFqTRgIebmZm3sCVpWdyDwHt1FeOZdXb/ZmrQv0xVCNLV5nq7E/AmGox+YVB2FtG
 NmdQ7z295dxLvw0d1nih5PdZGdQ9Qou/uTROm8mxu72twxlZuZkg0l0RE2GbT5vaToLOQ09yDM
 rixNK3HkLhfN6wkGQ6QBMtznK2JOGB/xQuYb4neABsecy5b/X68H7Wwi11w+ryPnf4bHr8VtVc
 y9MeMQXkQge3U406UuOR0XBJUuuM/w5CxLTuO6gojQFmlTi31YqtT/yx9NyoEqlBuAWAJGE8bO
 +rs=
IronPort-SDR: 
 c9gcBu/BQ1w6z33nTxIQiBnxF6sRnFb+E/XUZApdiR1uyYDYjy7I3T1Oomyfo7aCxDhNcEe2zK
 fLme073P8h/OSvZankdePIiLpW1yVB4YLDjkeiLKKTFfudIiE+qoMK2AX9h4zV1vNGv7g9Cdg+
 8avWxNsVDSOVb01y4ogdNmf1rSynBJvcOmDMQJbc27lJnZLjAEKw9izL0EWsTKFpao2VqeQHOH
 qX94wMUB1Y9ksrreQM71POdAF1cpD9lDoiPcPf1nWyQaRipTCLltMqG1Yb1Y9WZa7/Vfq31iAU
 15g=
WDCIronportException: Internal
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: linux-scsi@vger.kernel.org, mpi3mr-linuxdrv.pdl@broadcom.com
Cc: Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>,
        Kashyap Desai <kashyap.desai@broadcom.com>,
        Sumit Saxena <sumit.saxena@broadcom.com>,
        Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: [PATCH v3 0/5] scsi: mpi3mr: fix issues found by KASAN
Date: Tue, 10 Jan 2023 10:55:33 +0900
Message-Id: <20230110015538.201332-1-shinichiro.kawasaki@wdc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

scsi: mpi3mr: fix issues found by KASAN | expand

Message

Shin'ichiro Kawasaki Jan. 10, 2023, 1:55 a.m. UTC

While I downloaded new firmware to eHBA-9600 on KASAN enabled kernel, I observed
three BUGs. During patch review for the BUG fixes, two more related issues were
found. The first two patches address the two issues found during review, and the
last three patches address the three BUGs respectively.

Changes from v2:
* Added 1st and 2nd patches to address issues found during review
* 3rd patch: changed fix approach per comment on the list
* Added Acked-by and Reviewed-by tags

Changes from v1:
* 2nd patch: Modified to use bitmap helper functions and number of bits
* 1st/3rd patches: Reflected a comment on the list and added Reviewed-by tags

Shin'ichiro Kawasaki (5):
  scsi: mpi3mr: remove unnecessary memcpy
  scsi: mpi3mr: fix calculation of valid entry length in alltgt_info
  scsi: mpi3mr: fix alltgt_info copy size
  scsi: mpi3mr: use number of bits to manage bitmap sizes
  scsi: mpi3mr: fix missing mrioc->evtack_cmds initialization

 drivers/scsi/mpi3mr/mpi3mr.h     | 10 +----
 drivers/scsi/mpi3mr/mpi3mr_app.c | 18 +++------
 drivers/scsi/mpi3mr/mpi3mr_fw.c  | 68 +++++++++++++-------------------
 drivers/scsi/mpi3mr/mpi3mr_os.c  |  4 ++
 4 files changed, 39 insertions(+), 61 deletions(-)