| Message ID | 20250326-topic-ufs-use-threaded-irq-v2-0-7b3e8a5037e6@linaro.org |
|---|---|
| Headers | show |
| Series | ufs: core: cleanup and threaded irq handler | expand |
On 3/26/25 4:36 AM, Neil Armstrong wrote: > Drop last_intr_status & last_intr_ts drop the ufs_stats struct, > and the associated debug code. Patch descriptions should not only explain what has been changed but also why a change is being made. In this case, this change prepares for making an interrupt handler threaded. If this patch series has to be resent, please add this information to the patch description. Anyway, since the patch itself looks good to me: Reviewed-by: Bart Van Assche <bvanassche@acm.org>
On 27/03/2025 12:40, Bart Van Assche wrote: > On 3/26/25 4:36 AM, Neil Armstrong wrote: >> Drop last_intr_status & last_intr_ts drop the ufs_stats struct, >> and the associated debug code. > > Patch descriptions should not only explain what has been changed but > also why a change is being made. In this case, this change prepares for > making an interrupt handler threaded. If this patch series has to be resent, please add this information to the patch description. Anyway, > since the patch itself looks good to me: > > Reviewed-by: Bart Van Assche <bvanassche@acm.org> > Ack will update the commit msg Thanks, Neil
On systems with a large number request slots and unavailable MCQ, the current design of the interrupt handler can delay handling of other subsystems interrupts causing display artifacts, GPU stalls or system firmware requests timeouts. Example of errors reported on a loaded system: [drm:dpu_encoder_frame_done_timeout:2706] [dpu error]enc32 frame done timeout msm_dpu ae01000.display-controller: [drm:hangcheck_handler [msm]] *ERROR* 67.5.20.1: hangcheck detected gpu lockup rb 2! msm_dpu ae01000.display-controller: [drm:hangcheck_handler [msm]] *ERROR* 67.5.20.1: completed fence: 74285 msm_dpu ae01000.display-controller: [drm:hangcheck_handler [msm]] *ERROR* 67.5.20.1: submitted fence: 74286 Error sending AMC RPMH requests (-110) Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- Changes in v2: - Removed last_intr_status/last_intr_ts stats - Handle irq in prinmary handler for MCQ case - Stop touching REG_INTERRUPT_ENABLE register - Link to v1: https://lore.kernel.org/r/20250321-topic-ufs-use-threaded-irq-v1-1-7a55816a4b1d@linaro.org --- Neil Armstrong (2): ufs: core: drop last_intr_status/ts stats ufs: core: delegate the interrupt service routine to a threaded irq handler drivers/ufs/core/ufshcd.c | 45 ++++++++++++++++++++++++++++++++++----------- include/ufs/ufshcd.h | 5 ----- 2 files changed, 34 insertions(+), 16 deletions(-) --- base-commit: ff7f9b199e3f4cc7d61df5a9a26a7cbb5c1492e6 change-id: 20250321-topic-ufs-use-threaded-irq-53af30f2529f Best regards,