| Message ID | 20250503162440.2954-1-quic_nitirawa@quicinc.com |
|---|---|
| Headers | show |
| Series | Refactor ufs phy powerup sequence | expand |
On Sat, May 03, 2025 at 09:54:36PM +0530, Nitin Rawat wrote: > qmp_ufs_exit() is a wrapper function. It only calls qmp_ufs_com_exit(). > Remove it to simplify the ufs phy driver. > > Additonally partial Inline(dropping the reset assert) qmp_ufs_com_exit > into qmp_ufs_power_off function to avoid unnecessary function call. > > Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com> > --- > drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 29 +++++-------------------- > 1 file changed, 5 insertions(+), 24 deletions(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
On Sat, May 03, 2025 at 09:54:37PM +0530, Nitin Rawat wrote: > In qmp_ufs_power_off, the PHY is already powered down by asserting > QPHY_PCS_POWER_DOWN_CONTROL. Therefore, additional phy_reset and > stopping SerDes are unnecessary. Also this approach does not > align with the phy HW programming guide. > > Thus, refactor qmp_ufs_power_off to remove the phy_reset and stop > SerDes calls to simplify the code and ensure alignment with the PHY > HW programming guide. > > Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com> > --- > drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 7 ------- > 1 file changed, 7 deletions(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
In Current code regulators enable, clks enable, calibrating UFS PHY, start_serdes and polling PCS_ready_status are part of phy_power_on. UFS PHY registers are retained after power collapse, meaning calibrating UFS PHY, start_serdes and polling PCS_ready_status can be done only when hba is powered_on, and not needed every time when phy_power_on is called during resume. Hence keep the code which enables PHY's regulators & clks in phy_power_on and move the rest steps into phy_calibrate function. Since phy_power_on is separated out from phy calibrate, make separate calls to phy_power_on and phy_calibrate calls from ufs qcom driver. Also for better power saving, remove the phy_power_on/off calls from resume/suspend path and put them to ufs_qcom_setup_clocks, so that PHY's regulators & clks can be turned on/off along with UFS's clocks. This patch series is tested on SM8550 QRD, SM8650 MTP , SM8750 MTP. Note: Patch 1 of this series is a requirement for the rest of the PHY patches for the functional dependency. Changes in v4: 1. Addressed Dmitry's comment to update cover letter to mention patch1 as a requirement for the rest of the PHY patches. 2. Addressed Dmitry's comment to move parsing UFS PHY reset handle logic to init from probe to avoid probe failure. 3. Addressed Dmitry's comment to update commit text to reflect reason to remove qmp_ufs_com_init() (Patch 7 of current series) 4. Addrssed Konrad's comment to return failure from power up sequence when phy_calibrate return failure and modify the debug print. Changes in v3: 1. Addresed neil and bjorn comment to align the order of the patch to maintain the bisectability compliance within the patch. 2. Addressed neil comment to move qmp_ufs_get_phy_reset() in a separate patch, inline qmp_ufs_com_init() inline. Changes in v2: 1. Addressed vinod koul and manivannan comment to split the phy patch into multiple patches. 2. Addressed vinod's comment to reuse SW_PWRDN instead of creating new macros SW_PWRUP in phy-qcom-qmp-ufs.c. 3. Addressed Konrad's comment to optimize mutex lock in ufs-qcom.c 4. Addressed konrad and Manivannan comment to clean debug print in ufs-qcom.c Nitin Rawat (11): scsi: ufs: qcom: add a new phy calibrate API call phy: qcom-qmp-ufs: Rename qmp_ufs_enable and qmp_ufs_power_on phy: qcom-qmp-ufs: Refactor phy_power_on and phy_calibrate callbacks phy: qcom-qmp-ufs: Refactor UFS PHY reset phy: qcom-qmp-ufs: Remove qmp_ufs_com_init() phy: qcom-qmp-ufs: Rename qmp_ufs_power_off phy: qcom-qmp-ufs: Remove qmp_ufs_exit() and Inline qmp_ufs_com_exit() phy: qcom-qmp-ufs: refactor qmp_ufs_power_off scsi: ufs: qcom : Refactor phy_power_on/off calls scsi: ufs: qcom : Introduce phy_power_on/off wrapper function scsi: ufs: qcom: Prevent calling phy_exit before phy_init drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 145 ++++++++---------------- drivers/ufs/host/ufs-qcom.c | 96 ++++++++++------ drivers/ufs/host/ufs-qcom.h | 4 + 3 files changed, 111 insertions(+), 134 deletions(-) -- 2.48.1