| Message ID | cover.1667330271.git.nabijaczleweli@nabijaczleweli.xyz |
|---|---|
| Headers | show |
| Series | magic-number.rst funeral rites | expand |
On Wed, 2 Nov 2022 00:04:54 +0100 Ahelenia Ziemiańska wrote: > This is a follow-up for the 18+1-patch series ( > https://lore.kernel.org/linux-kernel/8389a7b85b5c660c6891b1740b5dacc53491a41b.1663280877.git.nabijaczleweli@nabijaczleweli.xyz/ > https://lore.kernel.org/linux-kernel/20220927003727.slf4ofb7dgum6apt@tarta.nabijaczleweli.xyz/ > ) I sent in September, and the same reasoning applies: No idea how you want this to get merged, but FWIW you can add my Acked-by: Jakub Kicinski <kuba@kernel.org> to patches 1, 2, 11 and 12.
This is a follow-up for the 18+1-patch series ( https://lore.kernel.org/linux-kernel/8389a7b85b5c660c6891b1740b5dacc53491a41b.1663280877.git.nabijaczleweli@nabijaczleweli.xyz/ https://lore.kernel.org/linux-kernel/20220927003727.slf4ofb7dgum6apt@tarta.nabijaczleweli.xyz/ ) I sent in September, and the same reasoning applies: The entire file blames back to the start of git (minus whitespace from the RST translation and a typo fix): * there are changelog comments for March 1994 through to Linux 2.5.74 * struct tty_ldisc is two pointers nowadays, so naturally no magic * GDA_MAGIC is defined but unused, and it's been this way since start-of-git * M3_CARD_MAGIC isn't defined, because commit d56b9b9c464a ("[PATCH] The scheduled removal of some OSS drivers") removed the entire driver in 2006 * CS_CARD_MAGIC likewise since commit b5d425c97f7d ("more scheduled OSS driver removal") in 2007 * KMALLOC_MAGIC and VMALLOC_MAGIC were removed in commit e38e0cfa48ac ("[ALSA] Remove kmalloc wrappers"), six months after start of git * SLAB_C_MAGIC has never even appeared in git (removed in 2.4.0-test3pre6) * &c., &c., &c. magic-number.rst is a low-value historial relic at best and misleading cruft at worst. This latter half cleans out the remaining entries (either by recognising that they aren't actually magic numbers or by cutting them out entirely) and inters the file. amd64 allyesconfig builds; this largely touches code that would be exceedingly expensive to test (and largely untouched since the git import), but is very receptive to static analysis. v2: Messages restyled Moved printk() in synclink_cs.c became pr_warn (__func__ instead of prescribed hard function name per checkpatch.pl) Ahelenia Ziemiańska (15): hamradio: baycom: remove BAYCOM_MAGIC hamradio: yam: remove YAM_MAGIC pcmcia: synclink_cs: remove MGSLPC_MAGIC pcmcia: synclink_cs: remove dead paranoia_check, warn for missing line coda: remove CODA_MAGIC Documentation: remove PG_MAGIC (not a magic number) MIPS: IP27: clean out sn/nmi.h MIPS: IP27: remove KV_MAGIC x86/APM: remove APM_BIOS_MAGIC scsi: acorn: remove QUEUE_MAGIC_{FREE,USED} hdlcdrv: remove HDLCDRV_MAGIC drivers: net: slip: remove SLIP_MAGIC fcntl: remove FASYNC_MAGIC scsi: ncr53c8xx: replace CCB_MAGIC with bool busy Documentation: remove magic-number.rst Documentation/process/index.rst | 1 - Documentation/process/magic-number.rst | 85 ----------------- .../translations/it_IT/process/index.rst | 1 - .../it_IT/process/magic-number.rst | 91 ------------------- .../translations/zh_CN/process/index.rst | 1 - .../zh_CN/process/magic-number.rst | 74 --------------- .../translations/zh_TW/process/index.rst | 1 - .../zh_TW/process/magic-number.rst | 77 ---------------- arch/mips/include/asm/sn/klkernvars.h | 8 +- arch/mips/include/asm/sn/nmi.h | 60 ------------ arch/mips/sgi-ip27/ip27-klnuma.c | 1 - arch/x86/kernel/apm_32.c | 9 +- drivers/char/pcmcia/synclink_cs.c | 79 +--------------- drivers/net/hamradio/baycom_epp.c | 15 +-- drivers/net/hamradio/baycom_par.c | 1 - drivers/net/hamradio/baycom_ser_fdx.c | 3 +- drivers/net/hamradio/baycom_ser_hdx.c | 3 +- drivers/net/hamradio/hdlcdrv.c | 9 +- drivers/net/hamradio/yam.c | 8 +- drivers/net/slip/slip.c | 11 +-- drivers/net/slip/slip.h | 4 - drivers/scsi/arm/queue.c | 21 ----- drivers/scsi/ncr53c8xx.c | 25 ++--- fs/coda/cnode.c | 2 +- fs/coda/coda_fs_i.h | 2 - fs/coda/file.c | 1 - fs/fcntl.c | 6 -- include/linux/fs.h | 3 - include/linux/hdlcdrv.h | 2 - 29 files changed, 29 insertions(+), 575 deletions(-) delete mode 100644 Documentation/process/magic-number.rst delete mode 100644 Documentation/translations/it_IT/process/magic-number.rst delete mode 100644 Documentation/translations/zh_CN/process/magic-number.rst delete mode 100644 Documentation/translations/zh_TW/process/magic-number.rst