mbox series

[RFC,v1,0/4] ufs: core: mcq: Add ufshcd_abort() support in MCQ mode

Message ID cover.1678247309.git.quic_nguyenb@quicinc.com
Headers show
Series ufs: core: mcq: Add ufshcd_abort() support in MCQ mode | expand

Message

Bao D. Nguyen March 8, 2023, 4:01 a.m. UTC 
This patch series enable support for ufshcd_abort() in MCQ mode.
The first patch is to prepare synchronization for ufshcd_abort() and interrupt contexts.
The second patch contains the supporting functions for ufshcd_abort().
The third and fourth patches add support for MCQ abort as discussed in the UFS
host controller spec.

Bao D. Nguyen (4):
  ufs: mcq: Use ufshcd_mcq_poll_cqe_lock() in mcq mode
  ufs: mcq: Add supporting functions for mcq abort
  ufs: mcq: Add support for clean up mcq resources
  ufs: mcq: Added ufshcd_mcq_abort()

 drivers/ufs/core/ufs-mcq.c     | 299 ++++++++++++++++++++++++++++++++++++++++-
 drivers/ufs/core/ufshcd-priv.h |  19 ++-
 drivers/ufs/core/ufshcd.c      |  57 ++++++--
 drivers/ufs/host/ufs-qcom.c    |   2 +-
 include/ufs/ufshcd.h           |   5 +-
 include/ufs/ufshci.h           |  16 +++
 6 files changed, 383 insertions(+), 15 deletions(-)

Comments

Bart Van Assche March 8, 2023, 11:23 p.m. UTC | #1 
On 3/8/23 14:27, Bao D. Nguyen wrote:
> This is to give us the flexibility to override this parameter in the 
> downstream driver if needed.

Please do not introduce functionality before it is needed. See also 
https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it.

Thanks,

Bart.
Bao D. Nguyen March 8, 2023, 11:52 p.m. UTC | #2 
On 3/8/2023 3:23 PM, Bart Van Assche wrote:
> On 3/8/23 14:27, Bao D. Nguyen wrote:
>> This is to give us the flexibility to override this parameter in the 
>> downstream driver if needed.
>
> Please do not introduce functionality before it is needed. See also 
> https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it.
I will remove it. Thanks.
>
> Thanks,
>
> Bart.
>